verne.freenode.net changed the topic of #mlpack to: http://www.mlpack.org/ -- We don't respond instantly... but we will respond. Give it a few minutes. Or hours. -- Channel logs: http://www.mlpack.org/irc/
manish7294 has joined #mlpack
< manish7294>
rcurtin: Are you there?
< manish7294>
rcurtin: We want call precalculate just the time when shuffle() is called, so may be we can have an impostors() overload, to whuch we can pass labels. So, this way we will not have to pass labels everytime and can just call it from shuffle.
manish7294 has quit [Ping timeout: 260 seconds]
< rcurtin>
manish7294: that would seem fine to me if it still works correctlt
< haritha1313>
zoq: Could you please take a look at this : https://pastebin.com/Bp080DaJ . I'm using concat for merging in MLP. Adding a network to object of Concat class is giving error but as far as I can see necessary Add() methods exist to enable this operation.
< haritha1313>
Maybe I am understanding the error log wrong. It would be great if you could suggest something.
< haritha1313>
Also, I have added batch tests in #1435 as per your review yesterday. Please take a look whenever you are free.
haritha1313 has quit [Ping timeout: 260 seconds]
ImQ009 has quit [Quit: Leaving]
ImQ009 has joined #mlpack
travis-ci has joined #mlpack
< travis-ci>
manish7294/mlpack#37 (lmnn - 76d1a7f : Manish): The build has errored.
< zoq>
haritha1313: Let me know if that works for you.
wenhao has joined #mlpack
< wenhao>
zoq: I see. I will modify the benchmark code and run with different seeds, and then update the results in the gist.
< wenhao>
zoq: I'm not sure I understand what you meant by " I'm not sure I see the reason for another class". Are you referring to the idea of renaming CFType<> to CFMatrixDecompositionModel<> and adding a wrapper class CFType<ModelType>?
< wenhao>
If so, Mikhail and I have some discussion on PR#1410 which could clarify how we plan to solve the issue I mentioned:)
wenhao has quit [Quit: Page closed]
haritha1313 has joined #mlpack
< haritha1313>
zoq: It does make it possible to add networks to Concat layer. But I am getting the error log 'forced_return.hpp:49: T boost::detail::variant::forced_return() [with T = void]: Assertion `false' failed' when adding this concat layer to FFN.
haritha1313 has quit [Ping timeout: 260 seconds]
< zoq>
wenhao: I'll take a look at the PR.
< zoq>
haritha1313: When you build the code or at is this a runtime issue?
haritha1313 has joined #mlpack
< haritha1313>
zoq: It is a runtime issue.
haritha1313 has quit [Ping timeout: 260 seconds]
haritha1313 has joined #mlpack
< haritha1313>
Just realized that the batch input support changes made to subview layer is causing submat() error when the layer is used as part of a network. Most probably because I removed the condition to check if the input is already in desired form. I am correcting it right now, so it might be better to keep #1435 on hold for now.
haritha1313 has left #mlpack []
ImQ009 has quit [Quit: Leaving]
< zoq>
haritha1313: Okay, let me know if you need any help to fix the issue, just tested the code with the Subview layer that is on the master branch.