verne.freenode.net changed the topic of #mlpack to: http://www.mlpack.org/ -- We don't respond instantly... but we will respond. Give it a few minutes. Or hours. -- Channel logs: http://www.mlpack.org/irc/
wenhao has joined #mlpack
vivekp has quit [Read error: Connection reset by peer]
vivekp has joined #mlpack
ImQ009 has joined #mlpack
wenhao has quit [Ping timeout: 260 seconds]
manish7294 has joined #mlpack
< manish7294>
zoq: Things are working now but somehow accuracy prediction doesn't seems to be valid (for instance shogun's knn is predicting 100% accuracy on iris, wine and 20% on some other datasets). Can you please take a look at the code?
Guest63658 is now known as anirudhm
anirudhm has left #mlpack []
manish7294 has quit [Ping timeout: 260 seconds]
< ShikharJ>
zoq: I don't seem to get the issue with the line `outputTemp.slice(outMap) += bias(outMap);` inside the convolution layer?
< zoq>
ShikharJ: bias is of size outSize but outMap will iterate over outSize * batchSize (outMap < outSize * batchSize).
< zoq>
manish7294: I'll take a look at the code later today.
< ShikharJ>
zoq: So can I just change the bias statement to `bias(outMap)`
< ShikharJ>
zoq: Ignore the above, I guess I'm still not able to understand the problem, isn't bias called at every iteration on the output slice?
< ShikharJ>
zoq: How would that cause a problem?
< zoq>
ShikharJ: The bias has to be added for each output slice right, but we have one bias term per output so let's say the outSize is 3, the bias is of size 3 e.g. [0.1 0.5 0.3]. If I use a batchSize = 2 the for loop is iterating over 0, 1, 2, 3, 4, 5 (index), since we use the condition outMap < outSize * batchSize.
< ShikharJ>
zoq: Do you think I can simply use a `bias(outMap % outSize);` for correcting this?
< zoq>
ShikharJ: I think that should work, yes
< ShikharJ>
zoq: Thanks for explaining the issue, I really appreciate it. Your debugging skills are really good :)
< zoq>
ShikharJ: Happy to help :)
< zoq>
ShikharJ: There is another issue which we have to solve, but let's fix this one first.
< ShikharJ>
zoq: You mean with the pooling layers? I'm already finding a fix for that.
< zoq>
ShikharJ: Good, there is another batch related issue inside the GAN class, some submatrix mismatch.
< ShikharJ>
zoq: I think that must be because Gradients has not been modified as of yet. I'll let you know if I get stuck with anything.
witness_ has quit [Quit: Connection closed for inactivity]
< ShikharJ>
zoq: The BatchSupport PR has also been debugged now. Thanks a lot for your help, wouldn't have been possible without it :)
< ShikharJ>
zoq: Now with BatchSupport and DCGAN ready, we just need to focus on the GANOptimizer class, and the we're good to go with the rest of the implementations.
< zoq>
ShikharJ: Agreed, the batch support should give us some speedups.
< zoq>
manish7294: checked the wine and iris dataset and the results are reasonable, can you comment on the dataset that might produce some strange results?
manish7294 has joined #mlpack
< manish7294>
zoq: Can you try balance_scale and letters?
< manish7294>
and did you got 100% on iris and wine?
manish7294 has quit [Ping timeout: 260 seconds]
witness_ has joined #mlpack
vivekp has quit [Ping timeout: 248 seconds]
< zoq>
manish7294: The letters failed on my end, have to take a closer look into the issue, maybe it's already fixed? And yes I got 100% on wine and iris, but they are simple datasets so I'm not really surprised, do you think the results are not reasonable?
< ShikharJ>
zoq: Could you review the BatchSupport PR when you get some time?
< zoq>
ShikharJ: yes
< ShikharJ>
zoq: Thanks for reviewing on such a short notice :)
< zoq>
ShikharJ: Hope this solves the issue, MSVC is somewhat picky :)
< ShikharJ>
zoq: Yeah, hopefully that was the issue that we were facing.
ImQ009 has quit [Quit: Leaving]
witness_ has quit [Quit: Connection closed for inactivity]
< ShikharJ>
zoq: That was precisely the issue with MSVC.
sumedhghaisas_ has quit [Ping timeout: 260 seconds]
< zoq>
ShikharJ: Great, I'll take a second look at the code tomorrow, so that it can be merged in the next days.
< zoq>
manish7294: With the letter dataset I get the following error message: 'libraries/shogun/src/shogun/metric/LMNNImpl.cpp line 69: The initial transform must be a square matrix of size equal to the number of features'.