lucf117 has quit [Remote host closed the connection]
aquijoule_ has joined #jruby
richbridger has quit [Ping timeout: 268 seconds]
lucf117 has joined #jruby
lucf117 has quit [Remote host closed the connection]
<RobertNicholas[m> that's by size / packed size
<RobertNicholas[m> seems like the bulk is in stdlib (no surprise)
<RobertNicholas[m> oh lemme grab the full built jar good point
<headius> This looks like the 27MB version?
<RobertNicholas[m> totally haven't had tea yet this morning :P
<RobertNicholas[m> I have a feeling it's putting more than just jruby in there from the look of that
<headius> I hear ya, starting some coffee myself
<RobertNicholas[m> hmm, I've just remove the shadow plugin to see what the size looked like without it, gonna have to do some more digging on this one I think
<headius> wow yes
<headius> sources getting included?
<headius> ugh why is intellij crashing today
<headius> basshelal: I review fzakaria comments today and we can get that PR merged in
<headius> I'm back
<headius> once I can get into IDE 🙄
<headius> bleh, MacOS security thing
<headius> Robert Nicholas: when you say "compiled jruby" what exactly do you mean?
<RobertNicholas[m> compiled in a java project's build.gradle
<RobertNicholas[m> so it's included in another jar file
<headius> ah so basically building your own "complete" version embedded into a larger jar, with additional gems
<headius> this seems like the jruby gradle plugins could help perhaps? They are fairly minimal right now but could be enhanced
<RobertNicholas[m> essentially an end user will not download or use jruby directly
<headius> it is mostly just a matter of mimicking the layout in the complete jar but I don't think we really have a standard utility/plugin to do that
<headius> the complete jar is assembled pretty manually by the maven build
<headius> and just includes gems we have in the lib pom.rb
<headius> (we do not like how these things are built currently but have not had time to replace it)
<RobertNicholas[m> yeah, essentially I'm trying to be able to do something like:
<RobertNicholas[m> `java -jar rubycore-0.0.1.jar -S gem install rubyzip`
<RobertNicholas[m> or even installing a gem from the ruby / java code itself. An end user isn't going to have a system ruby installed, but I want to be able to install gems with the jruby located inside of my mod's jar where jruby (and the ruby scripts loaded by my java program) can access them
<headius> oooo I see
<headius> But these would not be able to go back into a jar right? They would go somewhere on filesystem?
<headius> I thought this worked already, installing into .gem or something
<headius> .gems
<RobertNicholas[m> on the filesystem is fine but the question is how can I install a gem on the system when they don't have jruby-complete.jar on their system
<headius> aha
<headius> if the jruby-complete contents get stuffed into your jar it should just be something like java -classpath yourjar.jar org.jruby.Main -S gem install rubyzip
<RobertNicholas[m> oh really I'll give that a try
<headius> it is all still there in proper paths so I think it should work
<headius> basshelal: I just commented that I think we should merge and fix/cleanup bits and pieces in separate PRs. Leaving open for one more day to hear from fzakaria and possible enebo
<headius> enebo: if you get a chance today: https://github.com/jnr/jnr-ffi/pull/247
<fzakaria[m]> headius: thanks; I think it's OK.
<fzakaria[m]> High level I think it's a bit complicated but it's building on the original code so I agree with your assessment.
<headius> ok cool
<enebo[m]> I looked at it the other week and did not see anything which stood out
<enebo[m]> so I guess I also think it is ok
<headius> ok
<headius> merging!
<basshelal[m]> Fixed the merge conflicts, ready to merge
<edipofederle[m]> <edipofederle[m] ""Morning", could someone take a "> Someone could take a quick look at this PR? Thx!
<headius> cool
<basshelal[m]> headius: Oh wow you merged today! Thanks a lot! I'm very grateful and I'm very happy to have contributed again! 😊
<headius> edipo.federle: ok will have a look
<basshelal[m]> I'll have to resolve the conflicts from my other PR, might do that today or tomorrow.
<basshelal[m]> Cool!
<basshelal[m]> headius: Regarding #251 (https://github.com/jnr/jnr-ffi/issues/251) do you have anything in particular in mind?
<headius> yeah with input from fzakaria and enebo I didn't see a reason to wait