dalley has quit [Ping timeout: 256 seconds]
dalley has joined #hpy
pmp-p has quit [Ping timeout: 268 seconds]
pmp-p has joined #hpy
pmp-p has quit [Ping timeout: 265 seconds]
pmp-p has joined #hpy
pmp-p has quit [Ping timeout: 265 seconds]
pmp-p has joined #hpy
pmp-p has quit [Ping timeout: 265 seconds]
pmp-p has joined #hpy
FFY00 has quit [Remote host closed the connection]
FFY00 has joined #hpy
<
mattip>
lgtm. Waiting for CI to pass
<
fangerer>
thank you
<
mattip>
wow, the valgrind test is exceptionally slow
<
mattip>
ubuntu is ~8 minutes, macos is ~15 min, windows ~32 min, valgrind 1hr 50 min and counting
<
fangerer>
yes, I know 😞
<
fangerer>
I'm thinking of splitting it up. We could clone the job and run each
_mode_ (i.e. universal, cpython, ...) in a separate instance.
<
fangerer>
but that would increase the overall costs (in terms of CI minutes) a bit
<
Hodgestar>
We could also run valgrind nightly and on request.
<
Hodgestar>
Although it has sometimes picked up bugs for us in individual PRs, which is nice.
<
antocuni>
catching bug early >> faster tests
<
antocuni>
if we completely delete all our tests, the speed of our CI jobs would skyrocket 😂
<
Hodgestar>
Yes, but two hours is a pretty long time to wait.
<
fangerer>
I would also keep it but as I said, I think we can split the job and run the tests in parallel
<
Hodgestar>
We should definitely keep it, but it would be great to also avoid the two hours.
<
fangerer>
agreed. I'll try to improve the situation (tomorrow)
<
antocuni>
maybe we can configure it in such a way that the build becomes green even if valgrind is still running
<
fangerer>
since I have you here: please remind that we will have our dev call on Thursday (Dec 1st, 10a CET / 9a UTC)
<
antocuni>
ouch, I forgot about it. I won't be able to attend because of a doctor visit at the exact same time