mkoubaa has quit [Ping timeout: 255 seconds]
<mattip> the pypy rpython-level debug handle manager hangs on to a universal handle manager
<mattip> is that an internal detail or a design feature: i.e. is it expected that users can mix debug and universal mode in the same process?
<Hodgestar> It's expected that one can turn on the debugging context per-module.
<mattip> ok, thanks. I think the key is that the tests need to set a set_on_invalid_handle callback to avoid the fatal error
<mattip> btw, Christian Helmes asked about abi3 and universal mode in a cpython discussion thread
<mattip> I think the answer is that "universal mode is different than abi3, and allows turning on a debug mode at runtime"
<mattip> and then a link to docs
<mattip> which would be here if this PR were already live
<phlebas> mattip: what's keeping us from merging that PR?
<mattip> I just pushed the last commit a few minutes ago, review would seem prudent
<phlebas> ah, sorry, I thought that was the old PR that stepan had opened, i now clicked and saw it's yours
<phlebas> mattip: thanks for doing this!
steve73 has joined #hpy
steve73 has quit [Quit: Client closed]
<phlebas> any thoughts we should share https://github.com/markshannon/New-C-API-for-Python/issues/6 - " Should we pass the interpreter as an explicit parameter?"
<phlebas> I keep thinking about our stack allocation discussion, but nothing else comes to mind as to why it is an explicit argument
<Hodgestar> "Explicit is better than implicit"? ;)
<Hodgestar> If one cares about performance at the level of an extra argument on the C stack, don't call the Python API?
<Hodgestar> I posted some things about where HPy is to https://github.com/markshannon/New-C-API-for-Python/issues/8
<Hodgestar> Where by "don't call the Python API" I mean "don't call the Python API all over the place and deep in the call stack". Have C code work with things you give that don't require the context.
<Hodgestar> I think HPy devs and the CPython devs are talking past each other somewhat in Mark's repo, because the CPython devs want to redevelop the C API for the core of CPython, while HPy is focussed on the API for extension development.
<cfbolz> yeah, I agree with that. I think there are really two different ways to use the C API
<phlebas> mark actually raises a good question that makes that different line of thinking clear to me here: https://github.com/markshannon/New-C-API-for-Python/issues/6#issuecomment-1227343014
<phlebas> maybe the "real" goal should be that if the API/ABI for Python is broken, they should really move to a world where the internal C API is really just unstable and version specific, and the external API is something else (like HPy)? and then the choice of the extensions is to compile in "CPython mode" oder "Universal mode" (or even "PyPy mode", "GraalPy mode", "Rust mode", if any of those should make sense and the relevant impls provide it)
<phlebas> which is kind of how we approached hpy, but maybe not how mark is approaching this right now? i am not sure I can infer that from reading the issues on the repo or the current discourse discussion
<Hodgestar> My assumption is that Mark's immediate need is to break some parts of the C API for performance gains, but that is really just a guess. And on that front I think we all agree / already knew that the current C API hampers performance for implementations other than *past* CPythons.
<cfbolz> yes
<cfbolz> but the strategy of saying "let's break the API once, in exactly the right way so that now current CPython is faster" is not very sustainable
<Hodgestar> Agreed.
steve_s_ has joined #hpy
cfbolz_ has joined #hpy
fijal_ has joined #hpy
fijal has quit [*.net *.split]
steve_s has quit [*.net *.split]
fijal_ is now known as fijal
steve_s_ is now known as steve_s
cfbolz_ is now known as cfbolz