04:11 <manio> dnkl: I can prepare a PR if you like ^^^

05:37 <dnkl> manio: please do. I have very little screen time these days and will likely forget about it otherwise

13:06 <sterni> dnkl: would you accept patches which allow for foot to attach to an existing pty?

13:08 <sterni> background is that spectrum (a somewhat Nix-related experimental OS project) has a downstream patch for this and would in principle be interested in contributing it back upstream

13:08 <dnkl> Can you describe the use case?

13:09 <sterni> it's used to attach to the pty of a vm

13:10 <sterni> it's only supported in the client atm and the exercise left would be to figure out how this could / should work for the server

13:10 <sterni> you can actually see it here https://diode.zone/w/dWAWHR38Zu3feRtDKjVEJb (starting 1:45 or so)

13:11 <sterni> ah and this is the current downstream patch https://spectrum-os.org/git/nixpkgs/tree/pkgs/applications/terminal-emulators/foot/Add-support-for-opening-an-existing-PTY.patch?h=rootfs

13:21 <dnkl> It looks small enough, but I'm unsure how useful it would be outside this specific use case. You/they are of course welcome to open a PR, to start a discussion

13:21 <dnkl> (but it _is_ a pretty cool thing they've done 🙂)

13:21 <qyliss> [patch author here] would it be okay to open a PR before I've implemented it for the server?

13:22 <qyliss> the main reason I haven't tried upstreaming so far was I thought it was borderline whether it'd be accepted upstream, and I didn't want to put the time into doing the server part (which I wouldn't use) if it was unlikely to be accepted anyway

13:23 <qyliss> (I'd then implement the server part if the discussion was favourable)

13:44 <dnkl> qyliss: for the sake of discussion, yes it would be ok to open a PR before the server part is done

13:44 <qyliss> great, thanks!

13:44 <dnkl> The idea is to show case the feature to the community

13:44 <qyliss> I'll do that when I get a chance

13:45 <dnkl> It doesn't have to be complete