<jlebon>
dustymabe: nice, stamped! knowing that the azure stuff is tested in our pipeline gives us some confidence these big code moves won't silently break anything
<dustymabe>
jlebon: you mean 'azure stuff ISN't tested' ?
<jlebon>
dustymabe: not yet for RHCOS, but hopefully we turn that on soon. and the fact it's used for FCOS means the code we're backporting was heavily tested.
<dustymabe>
right, yeah. if we turn on azure testing for RHCOS we'd probably just do it for latest and let time do it's thing
<dustymabe>
I guess what that would require is for `make-amis-public` to know how to ignore AMIs from regions that aren't valid for this set of credentials
<dustymabe>
which wouldn't be hard
<jlebon>
exactly
<jlebon>
i guess the question is where would we rather the logic exist
<dustymabe>
I think the pipeline, mostly because that's where we know if we have the govcloud credential or not
<jlebon>
having our tooling directly handle it sounds cleaner. it wouldn't be very much work either to support govcloud creds on top of the region detection thing
<jlebon>
ravanelli, dustymabe: looking at previous rhcos-4.10 PRs, I don't think it passed in a while
<ravanelli>
jlebon: a nice, 4.11 passed fine, weird this one not passing
<jlebon>
the error msgs were different, but we've merged over red or not waited for it to finish in the past
<jlebon>
so i'm inclined to just push this through; we'll get feedback from the pipeline anywy
<jlebon>
anyway*
<ravanelli>
+1
* jlebon
writes a comment
<dustymabe>
jlebon: same for the 4.9 PR?
<jlebon>
yup, writing :)
<dustymabe>
+1
<jlebon>
ok both merged
<dustymabe>
jlebon: i'll drop the hacks in the build-cosa job (unless yoiu think we should keep them for potential 4.8 backport) and update the pipecfg
<jlebon>
dustymabe: SGTM. if/when we do 4.8, we can add back the hack just for it.
<jlebon>
dustymabe: jenkins is restarting. once it's up we can start bump-lockfile
<jlebon>
brb
nalind has quit [Quit: bye for now]
jlebon has quit [Quit: leaving]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 248 seconds]
vgoyal has quit [Quit: Leaving]
gursewak_ has quit [Remote host closed the connection]