whitequark[cis] changed the topic of #amaranth-lang to: Amaranth hardware definition language · weekly meetings: Amaranth each Mon 1700 UTC, Amaranth SoC each Fri 1700 UTC · code https://github.com/amaranth-lang · logs https://libera.irclog.whitequark.org/amaranth-lang · Matrix #amaranth-lang:matrix.org
lf has quit [Ping timeout: 268 seconds]
lf_ has joined #amaranth-lang
notgull has joined #amaranth-lang
notgull has quit [Ping timeout: 252 seconds]
Degi has quit [Ping timeout: 256 seconds]
Degi has joined #amaranth-lang
Lord_Nightmare has quit [Quit: ZNC - http://znc.in]
Lord_Nightmare has joined #amaranth-lang
jfng[m] has quit [Quit: Idle timeout reached: 172800s]
zyp[m] has quit [Quit: Idle timeout reached: 172800s]
<tpw_rules> does it work to rewrite `m.submodules += EnableInserter(foo)(Bar())` as `with m.If(foo): m.submodules += EnableInserter(1)(Bar())` ?
<whitequark[cis]> nope
<whitequark[cis]> that wouldn't be a meaningful semantic to have. consider that EnableInserter(x) is a shortcut for EnableInserter({"sync": x})
<whitequark[cis]> once you have two domains, either foo is synchronous to one or to the other. mandatory CDC violation
<_whitenotifier-5> [amaranth] slagernate commented on commit 8677ced4043efd35d91fc8f99f4798e0cec29fd4 - https://github.com/amaranth-lang/amaranth/commit/8677ced4043efd35d91fc8f99f4798e0cec29fd4#commitcomment-138650305
<_whitenotifier-7> [amaranth] whitequark commented on commit 8677ced4043efd35d91fc8f99f4798e0cec29fd4 - https://github.com/amaranth-lang/amaranth/commit/8677ced4043efd35d91fc8f99f4798e0cec29fd4#commitcomment-138650423
peeps has quit [Remote host closed the connection]
peeps has joined #amaranth-lang
notgull has joined #amaranth-lang
notgull has quit [Ping timeout: 268 seconds]
peeps has quit [Quit: Connection reset by peep]
peepsalot has joined #amaranth-lang
<Wanda[cis]> alright, wrote tests for the port propagation code (and squashed some minor bugs in it)
<Wanda[cis]> 1104 should be go
<_whitenotifier-7> [amaranth] codecov[bot] commented on pull request #1104: ir: kill Fragment.ports - https://github.com/amaranth-lang/amaranth/pull/1104#issuecomment-1946017078
<Wanda[cis]> there needs to be a follow-up PR that detects inout misuse btw; the current code only detects proper output-output conflicts
<Wanda[cis]> actually I'm going to add an enum to this while I'm at it
<galibert[m]> Catherine: there’s no cdc if two domains are built from the same clock but with different enables right? There could be tight timings, but there’s a low boundary
<Wanda[cis]> alright, added an enum and also improved the auto-port feature for Component to force port direction
<whitequark[cis]> galibert: yes but we don't have EnableSignal() yet
<_whitenotifier-5> [amaranth] wanda-phi edited pull request #1142: Implement RFC 45: Move `hdl.Memory` to `lib.Memory`. - https://github.com/amaranth-lang/amaranth/pull/1142
<_whitenotifier-5> [amaranth] whitequark commented on pull request #1104: ir: kill Fragment.ports - https://github.com/amaranth-lang/amaranth/pull/1104#issuecomment-1946551133
<_whitenotifier-7> [amaranth] wanda-phi edited pull request #1142: Implement RFC 45: Move `hdl.Memory` to `lib.Memory`. - https://github.com/amaranth-lang/amaranth/pull/1142
<Wanda[cis]> heh
<Wanda[cis]> there sure are some bugs regarding the old port propagation code
<Wanda[cis]> two of those also involved someone holding Pin wrong, btw
<whitequark[cis]> most of them do, iirc
<Wanda[cis]> #596 can be closed
<whitequark[cis]> but we need a better thing than AssertionError
<Wanda[cis]> yeah the current message gives you source locations of two conflicting drivers
<whitequark[cis]> you can just put a list of Fixes #xxx in the PR body
<whitequark[cis]> there's probably going to be like 5 of them fixed
<Wanda[cis]> yeah I'm still compiling the list
<Wanda[cis]> found 5 so far, am halfway through issues list
<Wanda[cis]> 596 is a PR though
<_whitenotifier-7> [amaranth] wanda-phi edited pull request #1104: ir: kill Fragment.ports - https://github.com/amaranth-lang/amaranth/pull/1104
<Wanda[cis]> okay I think it's exactly 5
<whitequark[cis]> nice
<whitequark[cis]> i hate that i knew the number offhand lmfao
<Wanda[cis]> ... you know the situation is bad when you start remembering issue IDs
<Wanda[cis]> relatedly, found another minor bug: AssignmentLegalizer doesn't preserve source locations, so the driver-driver conflict messages tend to involve _xfrm.py
<Wanda[cis]> but then it's on the chopping block already anyway, so...
<Wanda[cis]> also conflicting with a pin gives you a source location in the bowels of XilinxPlatform or whatever instantiating the io buffer
<Wanda[cis]> I suppose that could be improved by taking the sourc location of the resource in platform definition file or something?
<Wanda[cis]> oh right, we didn't even have Instance locations before NIR
<whitequark[cis]> yeah
jjsuperpower has joined #amaranth-lang
byteit101_ has joined #amaranth-lang
<_whitenotifier-7> [amaranth] whitequark opened pull request #1144: Fix link rot in docs - https://github.com/amaranth-lang/amaranth/pull/1144
<_whitenotifier-7> [amaranth] codecov[bot] commented on pull request #1144: Fix link rot in docs - https://github.com/amaranth-lang/amaranth/pull/1144#issuecomment-1947118099
<_whitenotifier-5> [amaranth] github-merge-queue[bot] created branch gh-readonly-queue/main/pr-1144-e3324e14566f15653c119ec68ec83d71eea0c04c - https://github.com/amaranth-lang/amaranth
<_whitenotifier-7> [amaranth] whitequark edited pull request #1144: Fix link rot in docs - https://github.com/amaranth-lang/amaranth/pull/1144
<_whitenotifier-7> [amaranth] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-1144-e3324e14566f15653c119ec68ec83d71eea0c04c - https://github.com/amaranth-lang/amaranth
<_whitenotifier-7> [amaranth] whitequark created branch pr/978 - https://github.com/amaranth-lang/amaranth
<_whitenotifier-5> [amaranth] whitequark deleted branch pr/978 - https://github.com/amaranth-lang/amaranth
<_whitenotifier-7> [amaranth] github-merge-queue[bot] created branch gh-readonly-queue/main/pr-1144-e3324e14566f15653c119ec68ec83d71eea0c04c - https://github.com/amaranth-lang/amaranth
byteit101_ has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
<_whitenotifier-5> [amaranth-lang/amaranth] whitequark 52842ee - docs: fix link rot.
<_whitenotifier-7> [amaranth-lang/amaranth] github-merge-queue[bot] pushed 2 commits to main [+0/-0/±10] https://github.com/amaranth-lang/amaranth/compare/e3324e14566f...b30c87fa3eee
<_whitenotifier-5> [amaranth] whitequark closed pull request #1144: Fix link rot in docs - https://github.com/amaranth-lang/amaranth/pull/1144
<_whitenotifier-7> [amaranth-lang/amaranth] whitequark b30c87f - pyproject: suppress superfluous warning.
<_whitenotifier-7> [amaranth] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-1144-e3324e14566f15653c119ec68ec83d71eea0c04c - https://github.com/amaranth-lang/amaranth
<_whitenotifier-5> [amaranth-lang/amaranth-lang.github.io] whitequark pushed 1 commit to main [+0/-0/±46] https://github.com/amaranth-lang/amaranth-lang.github.io/compare/d4b15cb87958...40d495f89bc7
<_whitenotifier-7> [amaranth-lang/amaranth-lang.github.io] github-merge-queue[bot] 40d495f - Deploying to main from @ amaranth-lang/amaranth@b30c87fa3eeef0373a6abf68e456f5eef4154790 🚀
<_whitenotifier-7> [amaranth] whitequark reviewed pull request #1140 commit - https://github.com/amaranth-lang/amaranth/pull/1140#discussion_r1491599355
<_whitenotifier-7> [amaranth] whitequark reviewed pull request #1140 commit - https://github.com/amaranth-lang/amaranth/pull/1140#discussion_r1491612607
<_whitenotifier-7> [amaranth] whitequark reviewed pull request #1140 commit - https://github.com/amaranth-lang/amaranth/pull/1140#discussion_r1491610643
<_whitenotifier-7> [amaranth] whitequark reviewed pull request #1140 commit - https://github.com/amaranth-lang/amaranth/pull/1140#discussion_r1491599550
<_whitenotifier-7> [amaranth] whitequark reviewed pull request #1140 commit - https://github.com/amaranth-lang/amaranth/pull/1140#discussion_r1491614507
<_whitenotifier-7> [amaranth] whitequark reviewed pull request #1140 commit - https://github.com/amaranth-lang/amaranth/pull/1140#discussion_r1491599679
<_whitenotifier-7> [amaranth] whitequark reviewed pull request #1140 commit - https://github.com/amaranth-lang/amaranth/pull/1140#discussion_r1491606443
<_whitenotifier-7> [amaranth] whitequark reviewed pull request #1140 commit - https://github.com/amaranth-lang/amaranth/pull/1140#discussion_r1491608213
<whitequark[cis]> oops, the bot's gonna spam for a bit
<whitequark[cis]> only 17 more messages i think
tarmoo has joined #amaranth-lang
jess has joined #amaranth-lang
<_whitenotifier-7> [amaranth] github-merge-queue[bot] created branch gh-readonly-queue/main/pr-1140-b30c87fa3eeef0373a6abf68e456f5eef4154790 - https://github.com/amaranth-lang/amaranth
<_whitenotifier-5> [amaranth-lang/amaranth] github-merge-queue[bot] pushed 1 commit to main [+0/-0/±30] https://github.com/amaranth-lang/amaranth/compare/b30c87fa3eee...24a392887af1
<_whitenotifier-7> [amaranth-lang/amaranth] wanda-phi 24a3928 - Implement RFC 43: Rename `reset=` to `init=`.
<_whitenotifier-5> [amaranth] whitequark closed pull request #1140: Implement RFC 43: Rename `reset=` to `init=`. - https://github.com/amaranth-lang/amaranth/pull/1140
<_whitenotifier-5> [amaranth] github-merge-queue[bot] deleted branch gh-readonly-queue/main/pr-1140-b30c87fa3eeef0373a6abf68e456f5eef4154790 - https://github.com/amaranth-lang/amaranth
<_whitenotifier-5> [amaranth-lang/amaranth-lang.github.io] whitequark pushed 1 commit to main [+0/-0/±47] https://github.com/amaranth-lang/amaranth-lang.github.io/compare/40d495f89bc7...05c82cc8c954
<_whitenotifier-7> [amaranth-lang/amaranth-lang.github.io] github-merge-queue[bot] 05c82cc - Deploying to main from @ amaranth-lang/amaranth@24a392887af19a9d013252759ec209d5a91a378a 🚀
<_whitenotifier-5> [amaranth] whitequark commented on commit 8677ced4043efd35d91fc8f99f4798e0cec29fd4 - https://github.com/amaranth-lang/amaranth/commit/8677ced4043efd35d91fc8f99f4798e0cec29fd4#commitcomment-138694273
<_whitenotifier-5> [amaranth] whitequark closed pull request #596: Improve Instance driver-driver conflict error message - https://github.com/amaranth-lang/amaranth/pull/596
<_whitenotifier-5> [amaranth] whitequark commented on pull request #596: Improve Instance driver-driver conflict error message - https://github.com/amaranth-lang/amaranth/pull/596#issuecomment-1947478849
<_whitenotifier-5> [amaranth] wanda-phi edited pull request #1142: Implement RFC 45: Move `hdl.Memory` to `lib.Memory`. - https://github.com/amaranth-lang/amaranth/pull/1142
tarmoo has quit [Quit: leaving]
tarmoo has joined #amaranth-lang
tarmoo has quit [Client Quit]
tarmoo has joined #amaranth-lang
jjsuperpower has quit [Ping timeout: 264 seconds]
tarmoo has quit [Quit: leaving]