<sjg1>
lvrp16: What board is this and what is the value of "fdtfile"? Unfortunately it has to swallow the 'ret' value, but perhaps you could add log_debug() each time that the bootmeth_common_read_file() call fails?
sng has quit [Remote host closed the connection]
marc1 has quit [Read error: Connection reset by peer]
<Tartarus>
And perhaps buildman is not the right tool to shove this in
<Tartarus>
Since we really need, longer term, a tool for "what files aren't tracked by MAINTAINERS"
<Tartarus>
The issue is our tooling for checking just on defconfigs broke
FergusL has quit [Ping timeout: 252 seconds]
sng has joined #u-boot
<sjg1>
Tartarus: 1. Which one did you look at?
<sjg1>
2. It requires whole matches, but I now see that is wrong. If you change re.fullmatch to re.match in tools/buildman/boards.py it should do that, but I'll need to update the tests
<sjg1>
1. There is no configs/bcm11130_nand_defconfig
<Tartarus>
Ah
<Tartarus>
Confusing wording, "orphaned defconfig listed at line X in FILE" ?
<Tartarus>
And for the last request, it doesn't seem like the kernel has a tool today
mmu_man has quit [Ping timeout: 245 seconds]
sng has quit [Remote host closed the connection]
<Tartarus>
sjg1: So once you have "N:" handling working, I guess I'll do a pre-req series that cleans up what you can report now re defconfigs
Adrian___ has quit [Ping timeout: 252 seconds]
mmu_man has joined #u-boot
monstr has quit [Remote host closed the connection]
sng has joined #u-boot
sng has quit [Remote host closed the connection]
sng has joined #u-boot
<Tartarus>
And I think part of our problem long term is that some tool will need to be made that assembles a db and accesses it, rather than making it up for each file
<Tartarus>
ie this works, but I think will be too slow for CI even: for FILE in configs/*defconfig;do [ `./scripts/get_maintainer.pl --find-maintainer-files --maintainer-path=. --git-chief-penguins --no-git-fallback --no-l -f ${FILE} | wc -l` -eq 0 ] && echo $FILE;done
<Tartarus>
Actually it doesn't work quite right because it's quirky around my email address, as the chief penguin
<Tartarus>
(checkpatch.pl bug I think)
<Tartarus>
((Or, feature, Linus is only specifically under "THE REST", but I am listed for a handful of boards/platforms as well as THE REST))
goliath has quit [Quit: SIGSEGV]
sng has quit [Read error: Connection reset by peer]
stefanro has quit [Quit: Leaving.]
<Tartarus>
Kludged around the email thing, 4min test, not the worst, but not great
<Tartarus>
sjg1: Maybe we just drop the MAINTAINERS logic from buildman?
FergusL has joined #u-boot
FergusL has joined #u-boot
FergusL has quit [Changing host]
goliath has joined #u-boot
vagrantc has joined #u-boot
rainbyte has quit [Remote host closed the connection]
<Tartarus>
sjg1: I think that might be the right path moving forward really
frieder has quit [Remote host closed the connection]
___nick___ has joined #u-boot
sakman has quit [Read error: Connection reset by peer]
<sjg1>
Tartarus: er, so you mean, remove that stuff from the boards.cfg file since we don't need to create it?
<sjg1>
s/create/add/
<Tartarus>
sjg1: boards.cfg is just for buildman to consume
<sjg1>
Tartarus: yes that's right
<Tartarus>
So I'm saying drop everything about checking for unmaintained defconfig files
<Tartarus>
And I guess that really means all of the MAINTAINERS parsing
mmu_man has joined #u-boot
<sjg1>
OK, so what will the CI check use?
<Tartarus>
get_maintainer.pl, later
<Tartarus>
It's quick enough, for CI
jaganteki has quit [Ping timeout: 246 seconds]
FergusL has quit [Quit: FergusL]
FergusL has joined #u-boot
sng_ has joined #u-boot
sng has quit [Read error: Connection reset by peer]
sng_ has quit [Remote host closed the connection]
<Tartarus>
And, OK, I've reached out about all of the orphans, and fixed (I think) everything under configs/ otherwise, and taken a first pass at some of the "fun" under boards/
<Tartarus>
Some dead code to remove, really do need a tool to make a db of sorts to query every file vs, but also should time my try everything on the kernel and it's single MAINTAINERS vs our setup
goliath has quit [Quit: SIGSEGV]
___nick___ has quit [Ping timeout: 258 seconds]
akaWolf has quit [Ping timeout: 250 seconds]
FergusL has quit [Quit: FergusL]
FergusL has joined #u-boot
akaWolf has joined #u-boot
<sjg1>
Tartarus: OK, I have a pretty low opinion of get_maintainer.pl and I'
<sjg1>
Tartarus: I'm not sure how it can do these checks? What option are you using?
<Tartarus>
Is roughly what the gitlab CI job will become
<Tartarus>
And I've contacted people about the orphans
naoki has joined #u-boot
slobodan has quit [Ping timeout: 245 seconds]
<lvrp16>
sjg1: I'm trying to understand the logic in bootmeth_common_read_file, i'm getting enospc because size > *sizep. however we pass an uninitalized sizep to the function distro_efi_read_bootflow_file.
<lvrp16>
is the logic incorrect or am I missing something?
<lvrp16>
or is there missing logic that should pass the fdt max space to distro_efi_read_bootflow_file?
<lvrp16>
sorry bootmeth_common_read_file, not distro_efi_read_bootflow_file