Tartarus changed the topic of #u-boot to: SOURCE MOVED TO https://source.denx.de/u-boot/u-boot.git / U-Boot v2023.07 is OUT / Merge Window is OPEN, next branch is CLOSED / Release v2023.10 is scheduled for 02 October 2023 / Channel archives at https://libera.irclog.whitequark.org/u-boot
redbrain has quit [Ping timeout: 260 seconds]
redbrain has joined #u-boot
redbrain has quit [Ping timeout: 272 seconds]
urja has quit [Read error: Connection reset by peer]
urja has joined #u-boot
redbrain has joined #u-boot
vagrantc has quit [Quit: leaving]
mmu_man has quit [Ping timeout: 272 seconds]
jclsn has quit [Ping timeout: 272 seconds]
jclsn has joined #u-boot
urja has quit [Read error: Connection reset by peer]
urja has joined #u-boot
hanetzer has quit [Ping timeout: 250 seconds]
hanetzer has joined #u-boot
Wouter0100670440 has quit [Quit: The Lounge - https://thelounge.chat]
Wouter0100670440 has joined #u-boot
sng has joined #u-boot
sng has quit [Remote host closed the connection]
sng has joined #u-boot
pgreco_ has joined #u-boot
pgreco has quit [Ping timeout: 245 seconds]
wooosaiiii has quit [Quit: wooosaiiii]
wooosaiiii has joined #u-boot
Adrian___ has joined #u-boot
sng has quit [Remote host closed the connection]
sng has joined #u-boot
mncheck has joined #u-boot
sng has quit [Remote host closed the connection]
sng has joined #u-boot
dlg has quit [Ping timeout: 240 seconds]
dlg has joined #u-boot
sng has quit [Read error: Connection reset by peer]
sng has joined #u-boot
sng has quit [Remote host closed the connection]
Kwiboo has quit [Quit: .]
Kwiboo has joined #u-boot
monstr has joined #u-boot
Kwiboo has quit [Quit: .]
Kwiboo has joined #u-boot
goliath has joined #u-boot
slobodan_ has joined #u-boot
sng has joined #u-boot
ldevulder has quit [Quit: Leaving]
frieder has joined #u-boot
mckoan|away is now known as mckoan
ldevulder has joined #u-boot
eloy_ is now known as eloy
sng has quit [Remote host closed the connection]
sng has joined #u-boot
Guest26 has joined #u-boot
sng has quit [Remote host closed the connection]
sng has joined #u-boot
Guest61 has joined #u-boot
sszy has joined #u-boot
ikarso has joined #u-boot
Guest61 has quit [Quit: Client closed]
Adrian___ has quit [Read error: Connection reset by peer]
Adrian___ has joined #u-boot
Adrian___ has quit [Ping timeout: 245 seconds]
rvalue has quit [Ping timeout: 246 seconds]
rvalue has joined #u-boot
sng has quit [Remote host closed the connection]
apalos- has quit [Quit: ZNC 1.7.2 - https://znc.in]
sng has joined #u-boot
guillaume has joined #u-boot
guillaume has quit [Client Quit]
apalos has quit [Quit: ZNC 1.7.2 - https://znc.in]
apalos has joined #u-boot
jaganteki has joined #u-boot
mmu_man has joined #u-boot
Guest26 has quit [Ping timeout: 246 seconds]
apalos has quit [Read error: Connection reset by peer]
apalos has joined #u-boot
Wouter0100670440 has quit [Quit: The Lounge - https://thelounge.chat]
Wouter0100670440 has joined #u-boot
sng has quit [Remote host closed the connection]
apalos has quit [Quit: ZNC 1.7.2 - https://znc.in]
apalos has joined #u-boot
<lvrp16> sjg1: I'm using bootstd but dit doesn't seem to be using the device trees.
<lvrp16> sjg1: the logs detect the dt and then says no dt available :D
Adrian___ has joined #u-boot
<lvrp16> sjg1: the file size read is 0 instead of the actual file size which suggests that it's reading the file from the wrong location
sng has joined #u-boot
naoki has quit [Quit: naoki]
Adrian___ has quit [Ping timeout: 240 seconds]
Adrian___ has joined #u-boot
slobodan_ has quit [Ping timeout: 250 seconds]
mmu_man has quit [Ping timeout: 272 seconds]
slobodan has joined #u-boot
sng has quit [Remote host closed the connection]
mmu_man has joined #u-boot
sng has joined #u-boot
apalos- has joined #u-boot
sng has quit [Remote host closed the connection]
sng has joined #u-boot
Wouter0100670440 has quit [Quit: The Lounge - https://thelounge.chat]
Wouter0100670440 has joined #u-boot
qqq has joined #u-boot
apalos has quit [Ping timeout: 252 seconds]
apalos- has quit [Ping timeout: 245 seconds]
apalos has joined #u-boot
apalos- has joined #u-boot
<sjg1> lvrp16: What board is this and what is the value of "fdtfile"? Unfortunately it has to swallow the 'ret' value, but perhaps you could add log_debug() each time that the bootmeth_common_read_file() call fails?
sng has quit [Remote host closed the connection]
marc1 has quit [Read error: Connection reset by peer]
rockosov has joined #u-boot
marc1 has joined #u-boot
apalos- has quit [Quit: ZNC 1.7.2 - https://znc.in]
<sjg1> Tartarus: Did you get a chance to look at the latest buildman series?
sng has joined #u-boot
sng has quit [Remote host closed the connection]
<sjg1> lvrp16: We could also (with BOOTSTD_FULL) record all the filenames and what the error was for each
<lvrp16> sjg1: I will check in 12 hours. I saw the message on the ML quite a bit from you with qemu.
<lvrp16> Same issue where it detected a dt and then said no dt found.
<Tartarus> sjg1: Does it pass CI, or did you leave updating the missing maintainer files and making CI work again too as a follow-up ?
ikarso has quit [Quit: Connection closed for inactivity]
mckoan is now known as mckoan|away
<sjg1> Tartarus It passes only because I disable the maintainer check
<Tartarus> Uh, I don't understand the MAINTAINERS file warnings
<Tartarus> I looked at one of the files and it looks fine
<Tartarus> And I don't think "N:" parsing is working either
<Tartarus> ARM VERSATILE EXPRESS DRIVERS
<Tartarus> F: drivers/misc/vexpress_config.c
<Tartarus> M: Liviu Dudau <liviu.dudau@foss.arm.com>
<Tartarus> T: git git://github.com/ARM-software/u-boot.git
<Tartarus> S: Maintained
<Tartarus> N: vexpress
<Tartarus> Should catch vexpress_fvp
<Tartarus> And perhaps buildman is not the right tool to shove this in
<Tartarus> Since we really need, longer term, a tool for "what files aren't tracked by MAINTAINERS"
<Tartarus> The issue is our tooling for checking just on defconfigs broke
FergusL has quit [Ping timeout: 252 seconds]
sng has joined #u-boot
<sjg1> Tartarus: 1. Which one did you look at?
<sjg1> 2. It requires whole matches, but I now see that is wrong. If you change re.fullmatch to re.match in tools/buildman/boards.py it should do that, but I'll need to update the tests
mncheck has quit [Ping timeout: 272 seconds]
<Tartarus> board/broadcom/bcm11130_nand/MAINTAINERS
<sjg1> 3. Maybe...it uses boards.cfg as its cache
<sjg1> 1. There is no configs/bcm11130_nand_defconfig
<Tartarus> Ah
<Tartarus> Confusing wording, "orphaned defconfig listed at line X in FILE" ?
<Tartarus> And for the last request, it doesn't seem like the kernel has a tool today
mmu_man has quit [Ping timeout: 245 seconds]
sng has quit [Remote host closed the connection]
<Tartarus> sjg1: So once you have "N:" handling working, I guess I'll do a pre-req series that cleans up what you can report now re defconfigs
Adrian___ has quit [Ping timeout: 252 seconds]
mmu_man has joined #u-boot
monstr has quit [Remote host closed the connection]
sng has joined #u-boot
sng has quit [Remote host closed the connection]
sng has joined #u-boot
<Tartarus> And I think part of our problem long term is that some tool will need to be made that assembles a db and accesses it, rather than making it up for each file
<Tartarus> ie this works, but I think will be too slow for CI even: for FILE in configs/*defconfig;do [ `./scripts/get_maintainer.pl --find-maintainer-files --maintainer-path=. --git-chief-penguins --no-git-fallback --no-l -f ${FILE} | wc -l` -eq 0 ] && echo $FILE;done
<Tartarus> Actually it doesn't work quite right because it's quirky around my email address, as the chief penguin
<Tartarus> (checkpatch.pl bug I think)
<Tartarus> ((Or, feature, Linus is only specifically under "THE REST", but I am listed for a handful of boards/platforms as well as THE REST))
goliath has quit [Quit: SIGSEGV]
sng has quit [Read error: Connection reset by peer]
stefanro has quit [Quit: Leaving.]
<Tartarus> Kludged around the email thing, 4min test, not the worst, but not great
<Tartarus> sjg1: Maybe we just drop the MAINTAINERS logic from buildman?
FergusL has joined #u-boot
FergusL has joined #u-boot
FergusL has quit [Changing host]
goliath has joined #u-boot
vagrantc has joined #u-boot
rainbyte has quit [Remote host closed the connection]
<Tartarus> sjg1: I think that might be the right path moving forward really
frieder has quit [Remote host closed the connection]
___nick___ has joined #u-boot
sakman has quit [Read error: Connection reset by peer]
sakman has joined #u-boot
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
ldevulder has quit [Quit: Leaving]
___nick___ has joined #u-boot
___nick___ has quit [Client Quit]
___nick___ has joined #u-boot
sng has joined #u-boot
sng has quit [Remote host closed the connection]
sng has joined #u-boot
<sjg1> Tartarus: OK, where should it go?
<sjg1> Tartarus: Yes I can update the wording...are you planning to review some of the patches, or should I send a v4 first?
<Tartarus> sjg1: We can just use get_maintainers.pl instead, going forward
<Tartarus> Until someone wants to make a better tool, to cover the whole tree
<Tartarus> And should be in some form the kernel folks will take
<Tartarus> sjg1: And yes, a v5 where we just drop the MAINTAINERS logic, it's not working
<Tartarus> I was fine with v3 until it broke my scripts, so I probably don't have other feedback :)
sszy has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
Wouter0100670440 has quit [Quit: The Lounge - https://thelounge.chat]
Wouter0100670440 has joined #u-boot
mmu_man has quit [Ping timeout: 272 seconds]
<sjg1> Tartarus: er, so you mean, remove that stuff from the boards.cfg file since we don't need to create it?
<sjg1> s/create/add/
<Tartarus> sjg1: boards.cfg is just for buildman to consume
<sjg1> Tartarus: yes that's right
<Tartarus> So I'm saying drop everything about checking for unmaintained defconfig files
<Tartarus> And I guess that really means all of the MAINTAINERS parsing
mmu_man has joined #u-boot
<sjg1> OK, so what will the CI check use?
<Tartarus> get_maintainer.pl, later
<Tartarus> It's quick enough, for CI
jaganteki has quit [Ping timeout: 246 seconds]
FergusL has quit [Quit: FergusL]
FergusL has joined #u-boot
sng_ has joined #u-boot
sng has quit [Read error: Connection reset by peer]
sng_ has quit [Remote host closed the connection]
<Tartarus> And, OK, I've reached out about all of the orphans, and fixed (I think) everything under configs/ otherwise, and taken a first pass at some of the "fun" under boards/
<Tartarus> Some dead code to remove, really do need a tool to make a db of sorts to query every file vs, but also should time my try everything on the kernel and it's single MAINTAINERS vs our setup
goliath has quit [Quit: SIGSEGV]
___nick___ has quit [Ping timeout: 258 seconds]
akaWolf has quit [Ping timeout: 250 seconds]
FergusL has quit [Quit: FergusL]
FergusL has joined #u-boot
akaWolf has joined #u-boot
<sjg1> Tartarus: OK, I have a pretty low opinion of get_maintainer.pl and I'
<sjg1> Tartarus: I'm not sure how it can do these checks? What option are you using?
<Tartarus> Is roughly what the gitlab CI job will become
<Tartarus> And I've contacted people about the orphans
naoki has joined #u-boot
slobodan has quit [Ping timeout: 245 seconds]
<lvrp16> sjg1: I'm trying to understand the logic in bootmeth_common_read_file, i'm getting enospc because size > *sizep. however we pass an uninitalized sizep to the function distro_efi_read_bootflow_file.
<lvrp16> is the logic incorrect or am I missing something?
<lvrp16> or is there missing logic that should pass the fdt max space to distro_efi_read_bootflow_file?
<lvrp16> sorry bootmeth_common_read_file, not distro_efi_read_bootflow_file