<sjg1>
apalos: OK yes I misunderstood your point, but it is related
<sjg1>
apalos: The only callers to tpm_sendrecv_command() are in lib/ and that function is defined in lib/tpm_utils.h which we cannot / should not include in a drivers/tpm file
torez has joined #u-boot
<sjg1>
apalos: At present the TPM drivers implement the uclass interface by calling the tpm API (or TPM v1/2)
<sjg1>
apalos: So what do you think?
<apalos>
sjg1: lemme go check, i need to re-read that thing
<apalos>
ok what about adding some input parameters on those
<apalos>
looking at them ahain they seem quite generic
<apalos>
iow, make TPM2_CR50_VENDOR_COMMAND, TPM2_CR50_SUB_CMD_NVMEM_ENABLE_COMMITS etc input parameters
<apalos>
and rename those functions to tpm2_cr50_report_state -> tpm2_report_state
hanetzer has joined #u-boot
<apalos>
I think that should be good enough and we can include it in the generic api
<apalos>
same for TPM2_CR50_SUB_CMD_NVMEM_ENABLE_COMMITS and tpm2_cr50_enable_nvcommits -> tpm2_enable_nvcommits
<apalos>
that way you can call them from the driver with the commands you want,
<apalos>
but they are still generic enough
<apalos>
because iirc those are concepts that apply on all tpm devices
indy_ has quit [Ping timeout: 248 seconds]
<apalos>
but those functions are platform dependent, so that would make a lot of sense
<sjg1>
apalos: OK let me look
rvalue has quit [Remote host closed the connection]
rvalue has joined #u-boot
indy has joined #u-boot
<apalos>
and all those TPM2_CR50_VENDOR_COMMANDTPM2_CR50_VENDOR etc will move to the internals of cr50
<monstr>
Tartarus: Hi Tom, I see that Kconfig layout has changed. Can you please resync defconfigs?
mmu_man has quit [Ping timeout: 268 seconds]
mmu_man has joined #u-boot
LeSpocky has quit [Remote host closed the connection]
pbergin has quit [Quit: Leaving]
prabhakarlad has joined #u-boot
persmule has quit [Remote host closed the connection]
persmule has joined #u-boot
wmills has joined #u-boot
matthias_bgg has quit [Quit: Leaving]
mmu_man has quit [Ping timeout: 248 seconds]
mmu_man has joined #u-boot
vagrantc has joined #u-boot
indy has quit [Ping timeout: 256 seconds]
indy has joined #u-boot
ldevulder_ has joined #u-boot
ldevulder has quit [Ping timeout: 248 seconds]
<sjg1>
apalos: OK I sent v4, hope that works!
monstr has quit [Remote host closed the connection]