frieder has quit [Remote host closed the connection]
matthias_bgg has quit [Quit: Leaving]
<sjg1>
This is used with an Infineon thing which is standard, so it should be fine. I tested this on some hardware which is how I found the bug. I could be wrong, of course
<apalos>
sjg1: ok
<apalos>
sjg1: I still dont get the comment on the cr50 functiuon
<apalos>
this has no place in the api
<apalos>
the function on the driver model *is* calling a function from the cr50 driver
<apalos>
so i can't really understand what you are trying to say here
<apalos>
my point is pretty simplle. A hardware specific function should not polute lib/tpm-v2.c
<apalos>
the dm code call cr50_i2c_report_state() which is defined in the driver
<apalos>
and then that function calls tpm2_cr50_report_state()
<apalos>
the latter surely has no place in the generic API
persmule has quit [Remote host closed the connection]
GNUtoo has quit [Remote host closed the connection]
GNUtoo has joined #u-boot
<apalos>
and cr50_i2c_report_state)_ seems to be the only caller, unless I am nis-greping something here
persmule has joined #u-boot
<sjg1>
apalos: Do you understand the point that code cannot call directly into a driver without going through a uclass method?
prabhakarlad has quit [Quit: Client closed]
prabhakarlad has joined #u-boot
mmu_man has quit [Ping timeout: 248 seconds]
apritzel has quit [Ping timeout: 248 seconds]
<hanetzer>
aight, got my picoblade plug kit, time to rebuild the uart for the device :)
GNUtoo has quit [Remote host closed the connection]
prabhakarlad has quit [Quit: Client closed]
prabhakarlad has joined #u-boot
GNUtoo has joined #u-boot
mmu_man has joined #u-boot
ldevulder_ has joined #u-boot
ldevulder has quit [Ping timeout: 256 seconds]
<apalos>
sjg1: but it *is* going throuhg the uclass
<apalos>
uclass calls cr50_i2c_report_state()
<apalos>
which calls the function later
<apalos>
that*
GNUtoo has quit [Remote host closed the connection]
GNUtoo has joined #u-boot
<sjg1>
apalos: Yes it with with my series, and we should not undo that. You can see that I have added a new uclass method
akaWolf has quit [Ping timeout: 252 seconds]
akaWolf has joined #u-boot
<apalos>
sjg1: any chance you've misread the email ?
<apalos>
What i said is "dont put hardware specific functions in the API"
<apalos>
I never said anything about this is done in the DM,
<apalos>
I even said the DM patches look correct
<apalos>
all i asked is move the internal tpm2_cr50_report_state in the driver
<apalos>
which isn't even the fucntion the DM calls
persmule has quit [Remote host closed the connection]
persmule has joined #u-boot
<hramrach>
sjg1: what does tpm2_cr50_report_state do that cr50_i2c_report_state does not?
<hramrach>
there may be a reson ot have it but it's not used anywhere so it's not clear what the reason would be
<hramrach>
I guess the problem is it adds backwards call from the driver to tpm2 lib which was not needed before so it looks like layering is backwards in the patch
persmule has quit [Remote host closed the connection]
persmule has joined #u-boot
persmule has quit [Remote host closed the connection]
persmule has joined #u-boot
karthanistyr has joined #u-boot
<hanetzer>
yeah. I think some functionality was ruined on the device due to that power surge... uart input is not working.
vagrantc has quit [Quit: leaving]
karthanistyr has quit [Killed (tantalum.libera.chat (Nickname regained by services))]
Guest2398 has joined #u-boot
karthanistyr has joined #u-boot
karthanistyr has quit [Quit: leaving]
<apalos>
hramrach: exactly, this looks like a layering violation for no apparent reason
akaWolf has quit [Ping timeout: 256 seconds]
akaWolf has joined #u-boot
tlwoerner has quit [Read error: Connection reset by peer]