<crb>
I'm trying to clean up a patch with checkpatch.pl and wondering a bit about the use. Do I check into my local branch and then create a patch and then run that through checkpatch.pl? I'd rather clean my files up before I commit
jclsn0 has joined #u-boot
<rfs613>
crb: you can run it against a file using -f option. Or if you've got things committed, the -g flag lets you scan a single commit, or a range of commits.
<rfs613>
other options which I find handy are --terse (one-line output suitable for vim quickfix) and --showfile (to see original filename rather than position within a patch file)
<crb>
rfs613, so will it be productive to run it against a "git diff" so that I can see what needs be fixed before I commit locally ?
<crb>
rfs613: forgive me I'm new to git and submitting patches and u-boot
<rfs613>
crb: you can, but despite the "patch" in the name, it works fine against whole files. Or against commits using -g.
<crb>
rfs613, excellent, thanks!
<rfs613>
The main reason for working off patches is to avoid noise about the parts of the file which you are not touching.
<rfs613>
... or perhaps because patches are what you would send to mailing list.
<crb>
rfs613: one more question if I could: I'm working on a patch to add support for a board. this results in 2 new files and 2 very small patches to existing files. Do I send a patch for each file individually or for all 4 files togther as the implement a single change, to my mind
<crb>
rfs613: I'll run it on the patch when I generate it but I'd like to that to be mostly clean by construction rather than have a commit and then a cleanup commit
<rfs613>
crb: so if it is a new (or mostly new) file, just use -f option to scan it whenever you like.
<rfs613>
as for how to organize it for adding a new board.. best advice is to look at some other recently added boards. There are usually quite a few things you need to add (defconfig, include/config/newboard.h, devicetree, etc)
behanw has quit [Quit: Connection closed for inactivity]
<crb>
rfs613: yes I modify the existing defconfig add a new device tree and modified the make file added a file in board, it all seems to work correctly but I don't know if I submit those changes together as a single patch or a patch for each file?
<rfs613>
crb: would this happen to be the Arty-Z7 board?
<crb>
rfs613, yes
<crb>
am I that obvious?
<crb>
were you the one that responded to my email?
<rfs613>
nope,
<rfs613>
I just went looking for a recent example, that was the first one I found
<crb>
ah, ok chuckle, well I'm trying to be conformant. What was SoB that he refers to in the email
<rfs613>
SoB= Signed-off-By
<crb>
ah, bingo, thanks that one escaped me
<rfs613>
what you sent was a mail wiht SoB in the message, and a patch file as an attachment.
<rfs613>
although that might seem perfectly reasonable in any normal business, the uboot/linux world doesn't want it that way
<rfs613>
instead it should all be in the mail (not attached), with multiple mails in case of multiple patches.
<rfs613>
there is tooling (git format-mail, git send-email) to help with generating these.
<crb>
rfs613, unfortunately my unix systems can't send email
<crb>
so I couldn't send it using those tools
<rfs613>
yeah, getting corporate email servers to co-opeate can also be a challenge (as in, prevent them from doing various munging of the message)
<crb>
rfs613, in this case it's not corporate, it's just me but I haven't (until now) really had a reason to send mail from my unix boxes and haven't properly set that up, it's probably a bit more configuration than I really want to spend time on
<rfs613>
you just need a SMTP server, doesn't have to be on the same machine. You can in fact use gmail servers for example (if you have a gmail account)
<crb>
rfs613: ok I suppose I'll have to look into that, thank you
<rfs613>
crb: your ISP probably also has SMTP server (whcih you likely used to send your mail)
mmu_man has quit [Ping timeout: 276 seconds]
<crb>
rfs613, I suppose but I want nothing to do with them other than deliver my packets
<crb>
rfs613: I guess I'll figure it out after I make my match clean
<crb>
err patch
<rfs613>
crb: i notice you are modifying xilinx_zynq_virt_defconfig, changing the default device tree and adding some options.
<crb>
yes I probably should look at that more closely, I probably shouldn't modify the default but just add my dts
<crb>
I probably should also check if the config changes are really needed
<rfs613>
likely yes. Also there are a bunch of other existing zynq boards, maybe take a look at how they handled their p7_init code
<crb>
it's a bit difficult as I'm booting freebsd not linux
<crb>
I did take a look, it seems like a bunch of them include p7_init code and as I understand that it's board specific
jclsn0 has quit [Ping timeout: 246 seconds]
<rfs613>
did they reformat it to use tab for indentation?
<crb>
that I hadn't looked at....yet
jclsn0 has joined #u-boot
<rfs613>
the 2-char indent in ps7_init() is likely why the other email reply mentioned checkpatch
<rfs613>
(it also checks for Signed-off-by on patches, etc)
<crb>
yep I'm sitting down to look at those issues now, I have, now, run check patch.pl on the patch I submitted and I see all the errors so I'm looking to fix those
<crb>
also I need to add first line license identifiers
<crb>
but it was nice that someone responded, it gave me hope that it might actually get accepted
<crb>
as do your comment here, thank you
<rfs613>
the responder is in fact the maintainer for the Zynq stuff ;-)
<crb>
rfs613: well then I managed to look like an ass in front of the right person....cool ;-)
<rfs613>
that one has been through a number of revisions, whcih is fairly typical
jclsn0 has quit [Ping timeout: 272 seconds]
<rfs613>
and for a much more complicated one, see the MediaTek MT7621 SoC, which has 25 patches (eg. 25 emails each with their own subject, description, S-o-b:, and patch)
<rfs613>
yours looks fairly simple by comparison ;-)
<crb>
rfs613: yes I hope so
jclsn0 has joined #u-boot
<rfs613>
crb: it looks to me like some of the ps7_init_gpl.c files added without any changes (eg. "wrong" indentation according to u-boot style rules),
jclsn0 has quit [Ping timeout: 246 seconds]
<rfs613>
crb: while other ones have been cleaned up (eg. board/xilinx/zynq/zynq-zturn-v5/ps7_init_gpl.c)
<crb>
rfs613: I'm fine with cleaning them up, I tend not to try to changes formatting of files I don't change. I'll need to look back to see where I got that from
jclsn0 has joined #u-boot
<rfs613>
crb: indentation aside, they also removed a lot of noise, old compatible code for ancient silicon versions, etc.
<rfs613>
crb: but yeah, there is a case to me made not to fiddle with automatically generated code
<crb>
rfs613, ok I never looked at that, I guess I'll have to take a look at that too. I really should start making a list I suppose
<rfs613>
crb: on the subject of sending emails, note that it is possible to configure git-send-email to use gmail. This is explained near the bottom of https://git-scm.com/docs/git-send-email
<crb>
rfs613: oh that's super cool and useful, thanks!
jclsn0 has quit [Ping timeout: 246 seconds]
<crb>
should I be using the new SPDX style license identifier or the deprecated style that seems to be common all over the tree
jclsn0 has joined #u-boot
thopiekar has quit [Ping timeout: 240 seconds]
thopiekar has joined #u-boot
<rfs613>
crb: use SPDX, they have been slowly converting to that everywhere
<rfs613>
note, the format varies ever-so-slightly for .c and .h files
NonaSuomy has joined #u-boot
<crb>
rfs613: I didn't understand that it seems I can chose GPL-2.0-or-later or GPL-2.0+ for instance
<rfs613>
there's a document about it, let me go find it..
<rfs613>
although they probably copied that from the kernel documentation ;-)
* rfs613
calls it a night..
jclsn0 has quit [Ping timeout: 276 seconds]
jclsn0 has joined #u-boot
jclsn0 has quit [Ping timeout: 272 seconds]
jclsn0 has joined #u-boot
jclsn0 has quit [Ping timeout: 240 seconds]
jclsn0 has joined #u-boot
vagrantc has joined #u-boot
apritzel has joined #u-boot
dormito has quit [Ping timeout: 240 seconds]
dormito has joined #u-boot
guillaume_g has joined #u-boot
apritzel has quit [Ping timeout: 246 seconds]
mckoan|away is now known as mckoan
monstr has joined #u-boot
LAZIBI has joined #u-boot
vagrantc has quit [Quit: leaving]
sszy has joined #u-boot
___nick___ has joined #u-boot
matthias_bgg has joined #u-boot
apritzel has joined #u-boot
ldevulder has joined #u-boot
ldevulder has quit [Remote host closed the connection]
ldevulder has joined #u-boot
tre has joined #u-boot
ldevulder has quit [Quit: Leaving]
NonaSuomy has quit [Ping timeout: 240 seconds]
ldevulder has joined #u-boot
bigendian has quit [Quit: ZNC 1.7.2+deb3~bpo9+1 - https://znc.in]
ad__ has joined #u-boot
mmu_man has joined #u-boot
ad__ has quit [Quit: ZNC 1.7.2+deb3~bpo9+1 - https://znc.in]
ad__ has joined #u-boot
ad__ has quit [Quit: ZNC 1.7.2+deb3~bpo9+1 - https://znc.in]
ad__ has joined #u-boot
michalkotyla has quit [Quit: michalkotyla]
LAZIBI has quit [Ping timeout: 252 seconds]
behanw has joined #u-boot
pbergin has joined #u-boot
michalkotyla has joined #u-boot
michalkotyla has quit [Client Quit]
redbrain has quit [Read error: Connection reset by peer]
redbrain has joined #u-boot
Ntemis has joined #u-boot
tafama is now known as tafa
elafon has joined #u-boot
elafon has quit [Remote host closed the connection]
elafon has joined #u-boot
Zapy has quit [Ping timeout: 252 seconds]
Ntemis has quit [Read error: Connection reset by peer]
ldevulder has quit [Quit: Leaving]
ldevulder has joined #u-boot
sszy has quit [Ping timeout: 244 seconds]
darkapex_ has joined #u-boot
darkapex has quit [Ping timeout: 248 seconds]
monstr has quit [Remote host closed the connection]
camus has quit [Ping timeout: 252 seconds]
mmu_man has quit [Ping timeout: 272 seconds]
tre has quit [Remote host closed the connection]
guillaume_g has quit [Quit: Konversation terminated!]
mmu_man has joined #u-boot
mmu_man has quit [Ping timeout: 240 seconds]
mmu_man has joined #u-boot
mckoan is now known as mckoan|away
ldevulder has quit [Remote host closed the connection]
apritzel has quit [Ping timeout: 272 seconds]
sobkas has joined #u-boot
apritzel has joined #u-boot
thopiekar has quit [Quit: Likely restarting quassel...]
thopiekar has joined #u-boot
camus has joined #u-boot
vagrantc has joined #u-boot
camus has quit [Ping timeout: 246 seconds]
___nick___ has quit [Ping timeout: 276 seconds]
vagrantc has quit [Quit: leaving]
sobkas has quit [Ping timeout: 244 seconds]
pbergin has quit [Quit: Leaving]
matthias_bgg has quit [Ping timeout: 256 seconds]
sbach has quit [Read error: Connection reset by peer]
sbach has joined #u-boot
vagrantc has joined #u-boot
<dormito>
anyone know anything about the 'SPARC885' u-boot source? I suspect they were never merged upstream (especially since I haven't found any indication of it).