azonenberg changed the topic of #scopehal to: libscopehal, libscopeprotocols, and glscopeclient development and testing | https://github.com/glscopeclient/scopehal-apps | Logs: https://libera.irclog.whitequark.org/scopehal
Degi has quit [Ping timeout: 250 seconds]
Degi has joined #scopehal
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+5/-0/±8] https://github.com/glscopeclient/scopehal-apps/compare/042f6e2fe9b6...3316c8daed02
<_whitenotifier-7> [scopehal-apps] azonenberg 3316c8d - Added LogViewerDialog
<d1b2> <azonenberg> Added a logfile viewer
<d1b2> <azonenberg> this is a logtools LogSink that shows a live feed of the logs within the app, handy if you launched it not attached to a console
<d1b2> <azonenberg> right now it uses the default log level but i'm thinking of changing it so that the in-app log sink is always debug level
<azonenberg> (default meaning set by command line args)
<azonenberg> the other debug feature i have pending - likely not tonight as i'm getting tired - is a scpi console
<azonenberg> with async request handlign so it won't lag, and correctly times out if you send a command that it doesn't reply to
<d1b2> <DanielG> something that's a little unclear from the Windows build instructions: do glslang/Vulkan need to be compiled/installed at the default path location, or at C:? Those aren't guaranteed to be the same.
<d1b2> <DanielG> If it must be the default path, using ~/<path> is fine. But for me, my default path isn't C:, so I substituted ~/ with /c/ in mingw.
<_whitenotifier-7> [scopehal] dan-gies commented on issue #688: "Unrecognized dataset type" when importing Tek .WFM file - https://github.com/glscopeclient/scopehal/issues/688#issuecomment-1247580783
bvernoux has joined #scopehal
massi has joined #scopehal
<azonenberg> DanielG: re your import issue, very interesting
<azonenberg> There's zero curve objects
<azonenberg> so we are probably reading more headers than we should?
<azonenberg> i might be assuming an optional field is present
<azonenberg> hmmm, maybe not
<azonenberg> that's for FastFrame datasets
<azonenberg> also interesting is that the header size is reported as 2
<azonenberg> which is nonsensical, it should be much larger
<azonenberg> so maybe the offset is wronng...
<azonenberg> i note your file is a version #3 and i wrote my code off the version 1 spec
<azonenberg> so possible some fields are different size or something in version 3
<azonenberg> or wait, no
<azonenberg> we are using version 3
<azonenberg> danielg: DERP
<azonenberg> ok i think i see the problem
<azonenberg> in WFMImportFilter.cpp:73 we open the .wfm file as text not binary
<azonenberg> you probably have an 0x0d or 0x0a somewhere in your file
<d1b2> <david.rysk> 😂
<azonenberg> aaanad yep there is an 0x0a at byte offset 11
<azonenberg> fix incoming
* azonenberg checks other importers to see if any have the same mistake
<azonenberg> this was probably copy pasted code
<_whitenotifier-7> [scopehal] azonenberg pushed 2 commits to master [+0/-0/±2] https://github.com/glscopeclient/scopehal/compare/84f3214ae0df...e56a37387507
<_whitenotifier-7> [scopehal] azonenberg b1c9b63 - WFMImportFilter: fixed bug where file is opened in text mode instead of binary, causing import failures on Windows
<_whitenotifier-7> [scopehal] azonenberg e56a373 - TRCImportFilter: fixed opening files in text mode instead of binary
<azonenberg> yep the lecroy importer did it too
<azonenberg> but interestingly none of the others
<azonenberg> Also, I heard back from jason at siglent. The SSG5000X-V does *not* currently allow you to query the live updating sweep values
<azonenberg> he sent me a set of commands that will be added to a future firmware
<azonenberg> but i can't use them until it's released
<_whitenotifier-7> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/glscopeclient/scopehal/compare/e56a37387507...63a33e44e3f8
<_whitenotifier-7> [scopehal] azonenberg 63a33e4 - Siglent SSG: added comments to note about upcoming features (not in current firmware)
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 3 commits to master [+2/-0/±7] https://github.com/glscopeclient/scopehal-apps/compare/3316c8daed02...c480b187bce0
<_whitenotifier-7> [scopehal-apps] azonenberg ace594f - Updated to latest scopehal
<_whitenotifier-7> [scopehal-apps] azonenberg 2168536 - Added SCPI console dialog. No deferred processing yet.
<_whitenotifier-7> [scopehal-apps] azonenberg c480b18 - SCPI console dialog now does deferred processing of read commands
<azonenberg> Debug console for driver debug etc. Integrated into the mutexing and such for transports, so your commands don't get mixed up with stuff the driver is doing
<azonenberg> Replies are handled in a nonblocking manner, doesn't hang the UI while waiting for the instrument
<azonenberg> including timeouts if no reply comes
<_whitenotifier-7> [scopehal-apps] azonenberg commented on issue #413: Add UI for configuring RF signal generators - https://github.com/glscopeclient/scopehal-apps/issues/413#issuecomment-1248063253
<_whitenotifier-7> [scopehal-apps] azonenberg closed issue #413: Add UI for configuring RF signal generators - https://github.com/glscopeclient/scopehal-apps/issues/413
<azonenberg> I feel like I'm starting to run out of things to do that don't involve scopes
<azonenberg> or scope waveforms
<azonenberg> Did some profiling and even connected to like six instruments CPU usage was negligible
<azonenberg> (not actually pulling waveform data though)
<_whitenotifier-7> [scopehal] azonenberg commented on issue #688: "Unrecognized dataset type" when importing Tek .WFM file - https://github.com/glscopeclient/scopehal/issues/688#issuecomment-1248185439
bvernoux has quit [Read error: Connection reset by peer]
bvernoux has joined #scopehal
bvernoux has quit [Read error: Connection reset by peer]
bvernoux has joined #scopehal
bvernoux has quit [Read error: Connection reset by peer]
bvernoux has joined #scopehal
bvernoux has quit [Read error: Connection reset by peer]
bvernoux has joined #scopehal
bvernoux has quit [Read error: Connection reset by peer]
bvernoux has joined #scopehal
bvernoux has quit [Ping timeout: 264 seconds]
bvernoux has joined #scopehal
bvernoux has quit [Read error: Connection reset by peer]
bvernoux has joined #scopehal
massi has quit [Remote host closed the connection]
bvernoux has quit [Quit: Leaving]
<d1b2> <Mughees> I am trying to generate waveforms. Lets say I generate 2 step functions and then try to subtract them. I get segmentation fault. I am almost always able to crash it while playing out with waveforms. Am I missing something?
<d1b2> <Mughees> multiply sine wave with a step also crashes....
<azonenberg> Multiplying sine by step does crash, I can reproduce it. Give me 2 mins...
<azonenberg> We did a bunch of refactoring to the waveform data model recently
<azonenberg> these are likely regressions introduced there
<d1b2> <Mughees> great thanks...
<d1b2> <Mughees> and subtract too crashes
<azonenberg> yeah i'm looking at that next
<azonenberg> i just found and fixed the multiply bug. one character typo, indeed from the refactoring
<azonenberg> (This is why I want to get more unit test coverage. we're far from 100%)
<azonenberg> Subtracting steps I cannot reproduce. what is the configuration of each step?
<d1b2> <Mughees> generate two steps
<d1b2> <Mughees> with differnet starting points
<d1b2> <Mughees> then subtract
<azonenberg> Can you screenshot your filter graph or something so i can see the exact configuration?
<d1b2> <Mughees> ok
<d1b2> <Mughees> just a sec
<azonenberg> and is this with GPU filters enabled or disabled?
<_whitenotifier-7> [scopehal] azonenberg pushed 2 commits to master [+0/-0/±2] https://github.com/glscopeclient/scopehal/compare/63a33e44e3f8...bb8aabaf61fa
<_whitenotifier-7> [scopehal] azonenberg 772e31c - PicoOscilloscope: default state on connecting is all channels enabled for now
<_whitenotifier-7> [scopehal] azonenberg bb8aaba - MultiplyFilterO fixed regression introduced by data model refactor
<azonenberg> anyway, i just pushed a fix for the multiply crash
<d1b2> <Mughees> /home/mughees/scopehal-apps/lib/scopeprotocols
<d1b2> <Mughees> oh oop
<d1b2> <Mughees> make above waveform...then make another one with step position lets say at 3ks
<d1b2> <Mughees> then subarct
<d1b2> <Mughees> Oh.....hmmm...now subtract is not crashing
<azonenberg> yeah i cannot reproduce the crash
<d1b2> <Mughees> i think i did a pull
<d1b2> <Mughees> that fixed it
<azonenberg> let me know if it happens for you again
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/glscopeclient/scopehal-apps/compare/c480b187bce0...a08b543810b4
<_whitenotifier-7> [scopehal-apps] azonenberg a08b543 - Updated to latest scopehal
<d1b2> <Mughees> awesome thanks
<azonenberg> and yeah in general the pace of development is pretty rapid so you should always pull latest before reporting a bug
<azonenberg> because odds are someone may have fixed it in the past few hours :)
<d1b2> <Mughees> Acknowledged 🙂