ifreund changed the topic of #river to: river - a dynamic tiling wayland compositor || https://github.com/riverwm/river || channel logs: https://libera.irclog.whitequark.org/river/
waleee has quit [Ping timeout: 256 seconds]
omni_ is now known as omni
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 240 seconds]
mon_aaraj has joined #river
snakedye has quit [Ping timeout: 250 seconds]
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
Evo2 has joined #river
mon_aaraj has quit [Ping timeout: 240 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 240 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
<novakane> ifreund: looks like all builds have worked with the commit from master
<novakane> all my last PRs being closed instead of merged, github is really dumb sometime ^^
Guest75 has joined #river
Guest75 has left #river [#river]
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
<ifreund> novakane: partially my fault not github's for rebasing them over to master locally instead of using the web UI
<ifreund> if I don't rebase your branch onto master and force push it first github is too dumb to realize that the commits are the same
<ifreund> anyhow, looks like all the builds have passed now which is sweet, github was just having a hard time last night I guess
<ifreund> It probably doesn't hurt to leave the github actions CI we already had around for now, I'll just chuck it next time it breaks
<novakane> ah yeah ok, well kinda annoying to force to use the web ui, but I guess that the github way lol
<novakane> yeah and to see if this works great with new PR
<novakane> was it easy to setup dispatch.st.ht?
<ifreund> Yeah, all I had to do was press like 3 buttons
<novakane> nice, hope this is gonna works great
<novakane> wasn't easy to find deps for freebsd, they need a nice site to search pkg :P
snakedye has joined #river
<ifreund> freebsd CI will be super nice to have, it's the mostly likely thing for me to manage to break the build for
<novakane> yeah that's great to have easily with sourcehut, their CI is really cool
pkap has joined #river
<pkap> I wanted to update the branch for my pull request and I updated the branch to master.
<pkap> But now the PR includes all commits. https://github.com/riverwm/river/pull/475
<pkap> Can I revert this somehow or do I need to make a new PR?
<pkap> I know I did something wrong..
<novakane> huh, what did you do?
<pkap> I merged master into my branch.
<ifreund> pkap: hrm, I'd recommend creating a new branch of of the current master locally
<ifreund> then cherry pick the commits from your PR over and resolve conflicts
<ifreund> once you get the history looking like you want, you can then git reset --hard your PR branch to the new fixed branch
<novakane> you should use rebase when you do this
<ifreund> for small patches like this yeah, definitely prefer rebase over merge
fitrh has joined #river
<pkap> Ok will do, thanks for the help!
fitrh13 has joined #river
fitrh13 has quit [Client Quit]
fitrh has quit [Quit: Client closed]
<novakane> oh, new Wayland compositor in zig https://github.com/dreinharth/byway
<novakane> damn everything in one file, not easy to read
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
<pkap> I'm trying to fix my mess with ifreunds instructions. After `git reset --hard <fixed_branch>`, locally everything is fixed. But how do I get it to the github branch? Git hints that I need to pull first, but then I recreate the mess =L
<tiosgz`> push --force-with-lease?
<pkap> Yeah it worked! Thanks tiosgz`!
<novakane> looks like the ci works great for PR too, cool
snakedye has quit [Ping timeout: 256 seconds]
snakedye has joined #river
voroskoi has joined #river
elshize has quit [Ping timeout: 250 seconds]
elshize has joined #river
voroskoi[m] has left #river [#river]
<pkap> How much CI time is available for river on Sourcehut? I feel a bit bad for causing so many builds with my PR...
<leon-p> pkap: I would not worry about that. The amount of PRs per month is so low that it's pretty unlikely that one will have a noticeable impact on the resources allocated for river or that river is having a noticeable impact on sourcehut.
<pkap> Nice. So Sourcehut does not limit to a certain amount of minutes like gitlab/github does?
<leon-p> pkap: I don't think they do, at least I can not find anything in the docs. However builds require a paid account.
elshize has quit [Ping timeout: 260 seconds]
elshize has joined #river
mon_aaraj has quit [Ping timeout: 240 seconds]
mon_aaraj has joined #river
norkki has quit [Ping timeout: 256 seconds]
pkap has quit [Quit: Client closed]
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
<novakane> ifreund: I was looking at using a ArrayListUnmanaged for Mode.[pointer_]mappings, would it makes sense to use one for this too? https://github.com/riverwm/river/blob/master/river/Config.zig#L91
<novakane> like with initCapacity(util.gpa, 2) instead of ensureTotalCapacity(2)
waleee has joined #river
mon_aaraj has quit [Ping timeout: 240 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 245 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Remote host closed the connection]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
pkap has joined #river
<leon-p> I am kinda starting to miss the "auto-back-and-forth" feature from Sway; Not sure if that can be implemented as a separate client though...
<novakane> what's that?
<leon-p> novakane: If you focus a tag, and then try to focus the tag again while you are still on it, it automagically sends you back to your previous tag. Super handy because it means you don't have to remember where you came from.
mon_aaraj has quit [Ping timeout: 260 seconds]
<leon-p> although I think it can probably be done client-side, maybe if I have some time later
<novakane> ah yeah, that's nice, would be cool
mon_aaraj has joined #river
* tiosgz` wonders why one would need to remember where they came from if they know where they want to go :P
<novakane> yeah maybe with river-status protocol like getting the previous tags and then comparing with the new one
<leon-p> :P
<leon-p> when I do a lab report, I have to cross-check at least four or five different documents, and it's always nicer if I can bounce back to my text editor without having to remember where I parked it.
elshize has quit [Ping timeout: 256 seconds]
elshize has joined #river
mon_aaraj has quit [Ping timeout: 250 seconds]
mon_aaraj has joined #river
<waleee> isn't it more tag-like (well, default in dwm) to have it on mod+tab ?
<leon-p> it certainly possible, but it requires to think about one additional keybind, so it has a higher cognitive load.
<waleee> some combination of ___+tab is usual for similar behaviour in some common apps (mainly browsers)
<waleee> it's more uncommon with the sway behaviour afaik
<leon-p> how common something is is not a good indicator of its quality, I find
<waleee> sure
<waleee> but it was mostly a counterpoint to "additional keybind, so it has a higher cognitive load"
<waleee> since you would be aware of a similar keybinding in other contexts
<leon-p> In fact I already have Super+Tab bound to rivers back-and-forth feature, but I still think it would be nicer to just re-use the tag keybind
<waleee> it shouldn't be too hard to add the sway-way I guess? I'd imagine an if or additional switch-case
<waleee> or is it specified in a protocol?
<leon-p> it'd be a rather trivial patch, but I am also not a huge fan of stacking too many features onto river, so I think I'll just write a helper client until the layout generators turn into proper window managers
mon_aaraj has quit [Ping timeout: 250 seconds]
mon_aaraj has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]
mon_aaraj has joined #river
pkap has quit [Ping timeout: 256 seconds]
monaaraj has joined #river
mon_aaraj has quit [Ping timeout: 256 seconds]