<bfiedler>
while looking at the bug isaac found in my PR I noticed another interesting behaviour
<bfiedler>
when borders are nonzero, repeated application of set-position 0 0 causes the window to shrink by border_size each time
<bfiedler>
I think it makes sense for set-geometry to set the size of the window's view, ignoring the border size. I'm not so sure about set-position, because intuitively I would expect set-position to be idempotent, which it is not
<bfiedler>
(it will never be idempotent when moving beyond an output, but IMO it should definitely be idempotent for 0 0)
<ifreund>
why won't moving beyond an output be idempotent? The first application should result in the view being send to the edge of the ouput and reduced in size, futher applications should change nothing right?
<ifreund>
anyhow, I agree that moving to 0, 0 should certainly be idempotent. Probably just missing a + border_width on some check
<bfiedler>
if I do set-position -10 -10 it will always crop the window
<bfiedler>
(until at some point the minimum size is reached)
<ifreund>
hmm, ok I see why that's the case but it seems less than ideal
<bfiedler>
Aside from the fact that one shouldn't be doing that I think it's ok
<bfiedler>
we are moving the top-left corner, so if you repeatedly put that somewhere where it will be cropped it's on yourself
<ifreund>
perhaps we just shouldn't accept negative coordinates?
<bfiedler>
That would also be fine with me
<ifreund>
I don't really see a reason to do so, and I think idempotency isn't an issue on the bottom/right edges as after the first operation subsequent operations will do nothing
<ifreund>
so if we fix the border_width issue and forbid negative coordinates set-position should be idempotent I believe
<bfiedler>
agreed. I'll add some input validation to the command then
<ifreund>
cool
snakedye has quit [Ping timeout: 264 seconds]
snakedye has joined #river
leon-p has joined #river
snakedye has quit [Ping timeout: 258 seconds]
snakedye has joined #river
snakedye has quit [Ping timeout: 252 seconds]
snakedye has joined #river
waleee has joined #river
notzmv has quit [Ping timeout: 245 seconds]
waleee has quit [Ping timeout: 252 seconds]
waleee has joined #river
waleee has quit [Ping timeout: 258 seconds]
notzmv has joined #river
waleee has joined #river
waleee has quit [Ping timeout: 258 seconds]
waleee has joined #river
novakane has quit [Quit: WeeChat 3.3]
snakedye has quit [Read error: Connection reset by peer]
snakedye has joined #river
wrl has quit [*.net *.split]
anb1 has quit [*.net *.split]
wrl has joined #river
anb1 has joined #river
notzmv has quit [Remote host closed the connection]
notzmv has joined #river
kennylevinsen has quit [Remote host closed the connection]
kennylevinsen has joined #river
kennylevinsen has quit [Remote host closed the connection]