ali12341 has quit [Remote host closed the connection]
ali12341 has joined #openscad
LordOfBikes has quit [Ping timeout: 246 seconds]
LordOfBikes has joined #openscad
mmu_man has quit [Ping timeout: 272 seconds]
qeed has quit [Ping timeout: 246 seconds]
J23k39 has joined #openscad
J23k47 has quit [Ping timeout: 246 seconds]
qeed has joined #openscad
little_blossom has joined #openscad
fling has quit [Remote host closed the connection]
fling has joined #openscad
guso78_ has joined #openscad
qeed_ has joined #openscad
qeed has quit [Ping timeout: 264 seconds]
guso78_ has quit [Ping timeout: 246 seconds]
guso78_ has joined #openscad
misterfish has joined #openscad
teepee_ has joined #openscad
teepee has quit [Ping timeout: 240 seconds]
teepee_ is now known as teepee
Virindi has quit [Quit: ZNC 1.8.2+deb2+b1 - https://znc.in]
misterfish has quit [Ping timeout: 272 seconds]
Virindi has joined #openscad
Virindi has quit [Quit: ZNC 1.8.2+deb2+b1 - https://znc.in]
Virindi has joined #openscad
misterfish has joined #openscad
Virindi has quit [Quit: ZNC 1.8.2+deb2+b1 - https://znc.in]
Virindi has joined #openscad
mmu_man has joined #openscad
Virindi has quit [Quit: ZNC 1.8.2+deb3.1 - https://znc.in]
misterfish has quit [Ping timeout: 250 seconds]
misterfish has joined #openscad
misterfish has quit [Ping timeout: 258 seconds]
misterfish has joined #openscad
snaked has quit [Quit: Leaving]
J23k39 has quit [Quit: Client closed]
J23k39 has joined #openscad
guso78_ has quit [Quit: Client closed]
guso78_ has joined #openscad
mmu_man has quit [Ping timeout: 245 seconds]
mmu_man has joined #openscad
rawgreaze has quit [Read error: Connection reset by peer]
rawgreaze has joined #openscad
guso78_ has quit [Ping timeout: 246 seconds]
L29Ah has left #openscad [#openscad]
misterfish has quit [Ping timeout: 264 seconds]
L29Ah has joined #openscad
misterfish has joined #openscad
mmu_man has quit [Ping timeout: 245 seconds]
mmu_man has joined #openscad
castaway has quit [Ping timeout: 246 seconds]
GNUmoon2 has quit [Remote host closed the connection]
GNUmoon2 has joined #openscad
linext has quit [Read error: Connection reset by peer]
guso79 has joined #openscad
castaway has joined #openscad
<joseph_>
General GitHub question: In other repos, I've seen a button that allows requesting a review from a specific user. But not for OpenSCAD. Is that a permission that got specifically disabled?
<teepee>
joseph_: I'm not aware there is extra permissions and I think guso78 used it not long ago, let me check
<teepee>
I can see the section even with an unrelated user
<teepee>
aha: "Note: Pull request authors can't request reviews unless they are either a repository owner or collaborator with write access to the repository."
<guso79>
this button was working to me in all times. its on the top right side.
<guso79>
you get some pre-selection but after some clicking you can choose to have anybody who is member for a review.
misterfish has quit [Ping timeout: 264 seconds]
<guso79>
but yes: the finding of teepee makes sense.
<teepee>
that's quoting the official documentation, so I assume it's just that behavior, no configuration - at least it does not say there's something to configure
<guso79>
i think my ability to request reviews started with the openscad/python-prepare branch.
<teepee>
yep, combined with the invitation to the repo
L29Ah has quit [Ping timeout: 245 seconds]
guso79 has quit [Ping timeout: 246 seconds]
L29Ah has joined #openscad
RichardPotthoff has joined #openscad
mmu_man has quit [Ping timeout: 245 seconds]
<Scopeuk>
so the short version of that is people who are part of the project (who could presumably push trunk) can request a review before they do so. for external pull requests the author couldn't push trunk so it's not really needed and from role it is defined that it needs to go trhogu ha contributer
mmu_man has joined #openscad
othx has quit [Read error: Connection reset by peer]
othx has joined #openscad
misterfish has joined #openscad
pah_ is now known as pa
pa has quit [Changing host]
pa has joined #openscad
fling has quit [Remote host closed the connection]