09:39 <karlp> 0b prefixed should never have been marged though, I'm surprised we're only running into someone hitting that now.

09:40 <karlp> but yes, just prefixing with 0x to get 0x0b11 is 1000% wrong.

11:27 <Haohmaru> i can't get microsh*t pickit3 to work under linux with their dumb java tools >:(

11:29 <Haohmaru> 600MB of crap, and then it tells me it can't read the .hex files

12:14 <sevan> karlp: ack

12:15 <sevan> This is what it took to get v0.12.0 to compile with ancient GCC https://paste.debian.net/1305594/

12:16 <sevan> I have added it as a comment on the review but haven't commited it in case this was even more wrong. Tested with GCC 4.0 & 5.5

12:42 <karlp> as far as I can tell, gcc added support for 0b literalls in 4.3.

12:42 <karlp> they've been non-portable ~forever though really.

12:44 <karlp> I guess the armv8 code all came in well after binary literals were commonly available,

12:45 <sevan> this cuts down a day+ to compile a new compiler when you have 4.0 out of the box :)

12:45 <karlp> same with xcf, that only landed in 2016, so no-one notice.d

12:45 <karlp> yeah, I'm all for replacing the binary with hex literals, no objections,

12:46 <sevan> thanks

13:18 <sevan> karlp: the patch I posted up partially converts target/armv8_opcodes.h to hex, for the sake of completeness everything should be replaced in that file?

13:30 <karlp> I'm not pushing this in any direction, nor can I merge it :) but a repo wide replacement of binary literals to hex would be a sane "portability fix" for me and I'llgive it a +1 :)

13:40 <Haohmaru> what's wrong with 0bXXXX ?

13:49 <karlp> it's a gcc extension until C23, so not all compilers support it.

13:49 <karlp> though, in recent years, more of them ahve than haven't, unless you're retroputing...

13:53 <Haohmaru> museumputing

13:54 <Haohmaru> well, gcc ftw anyway

13:57 <sevan> Haohmaru: not GCC 4.0 though :)

13:59 <Haohmaru> gcc 4 was still nicer than $whatever the others had

15:46 <sevan> pushed the current patch to review. Will look to finish off converting src/target/armv8_opcodes.h if there are no issues.