<marex>
indy: AFAIR they are all resolved/fixed by the subsequent changes
van has quit [Ping timeout: 240 seconds]
van has joined #openocd
<indy>
PaulFertser, borneoa__, ^^ resolving comment must be performed by 'commentator' or by submitter?
<indy>
in webui?
NishanthMenon has quit [Server closed connection]
NishanthMenon has joined #openocd
<PaulFertser>
indy: the idea is that when you reply to a comment you just press "resolved" tickbox.
<PaulFertser>
indy: so usually the submitter when replying to a comment checks it if appropriate to mark resolved.
<indy>
marex, ^^ :)
<PaulFertser>
But that's not an issue. The real issue is that the change is indeed way too long there, it's rather unfortunate no maintainer picked it up.
<PaulFertser>
Not sure if unreloved comments affected that or not.
<marex>
considering how I was actually talking to Vanek over a beer to help get aborneo as a maintainer in openocd, yeah ...
<marex>
it's unfortunate
<PaulFertser>
I certainly do not understand that. Hope borneoa__ will clarify.
<borneoa__>
Hello. I think 6055 just get lost from my radar. I will look at it. Also I don't remember any ping on it.
<borneoa__>
The unresolved comment is not blocking for me. I either clean them during review or before merge. But sometimes I have merged without cleaning them, which is not nice
BuldiBaerBeer has joined #openocd
BuldiBaerBeer has quit [Quit: Leaving]
Haohmaru has quit [Ping timeout: 255 seconds]
PsySc0rpi0n has quit [Ping timeout: 248 seconds]
PsySc0rpi0n has joined #openocd
peeps[work] has joined #openocd
PsySc0rpi0n has quit [Ping timeout: 268 seconds]
nerozero has quit [Ping timeout: 240 seconds]
zjason` has joined #openocd
zjason has quit [Ping timeout: 248 seconds]
nathanhi has quit [Quit: bye]
nathanhi- has joined #openocd
wingsorc has joined #openocd
<borneoa__>
marex: regarding 6055, I'm not really familiar with aarch64. You will find that some of my comments are more questions to better understand the implications. Nevertheless, I need to invest in aarch64, so eager to get your reply.
<marex>
borneoa__: I am not even sure how to react to this. You added yourself as a reviewer two years ago, then you asked for changes which I implemented, then you ignored the MR ... now I learn that you ignored the MR because you are not qualified to review the code, and now you add open points to the MR because the code has decayed over time while the MR was ignored, so, now there is a reason why the MR cannot
<marex>
be merged anymore again, there are open issues.
<marex>
borneoa__: I was also eager to get a reply over the last two years ...
<marex>
borneoa__: your comments are actually really unhelpful, they only expect me to do more work, spend more time investigating the openocd code base, without any easy hint how to do the changes you requested, and with zero guarantee that I wouldn't have to wait another year or two for the changes to be reviewed ... that is utterly crushing my motivation