verne.freenode.net changed the topic of #mlpack to: http://www.mlpack.org/ -- We don't respond instantly... but we will respond. Give it a few minutes. Or hours. -- Channel logs: http://www.mlpack.org/irc/
trungda has joined #mlpack
< trungda>
Hi, I am using macos yosemite and its default g++ compiler to compile mlpack, when `make`, I faced the following error: mlpack/core/tree/binary_space_tree/binary_space_tree_impl.hpp:231:28: error: declaration of 'BoundType' shadows template parameter template<typename BoundType, typename MatType> class SplitType>. Does anyone know how to work around this ? Thank you in advance.
< naywhayare>
trungda: what version of gcc are you using?
< naywhayare>
I think I know what the problem is, which is that 'BoundType' is declared twice
< trungda>
I think it is 4.2.1
< trungda>
the result of my gcc --version is: Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/usr/include/c++/4.2.1 Apple LLVM version 6.0 (clang-600.0.56) (based on LLVM 3.5svn) Target: x86_64-apple-darwin14.0.0 Thread model: posix
< naywhayare>
I suspect that the right way to resolve it will be to change "template<typename BoundType, typename MatType> class SplitType" to "template<typename TBoundType, typename TMatType> class SplitType"
< naywhayare>
ah, okay, that's clang
< naywhayare>
I can try and reproduce that, but I'm about to leave for a little while, so it may be a bit until I get back to you
< trungda>
yes, I am also suspecting that clang is not suitable to compile, right ?
< trungda>
thanks so much :)
< naywhayare>
unfortunately that solution (changing the name of the template parameters) will have to be applied all over binary_space_tree.hpp and binary_space_tree_impl.hpp
< naywhayare>
when I'm at a computer again, I'll let you know my results
< naywhayare>
and if I can reproduce and fix the problem I'll commit the fix to master
< trungda>
yes, there are just so many positions in binary_space_tree.cpp that need to be fixed :D
< trungda>
ok, thats great ! thanks
trungda has quit [Ping timeout: 246 seconds]
trungda has joined #mlpack
trungda has quit [Quit: Page closed]
trungda has joined #mlpack
trungda has quit [Quit: Page closed]
trungda has joined #mlpack
travis-ci has joined #mlpack
< travis-ci>
mlpack/mlpack#176 (master - d968f73 : Marcus Edel): The build passed.
< trungda>
@naywhaare: I am able to build after modifying all duplicate template declaration (as you suggested)
< trungda>
there are several files having this
< naywhayare>
trungda: ah, good to hear that
< naywhayare>
would you like to submit your work as a pull request on github? otherwise I'll make the same changes and commit
< naywhayare>
gcc does not have a problem with the duplicates but I should have tested with clang too :)
< trungda>
yes I would like to do it, It is just a minor modification in many files so I think I should be able to do it, you should work on bigger problems.
< trungda>
yes, I think so too.
< trungda>
I dont really remember whether Yosemite has clang as the default c compiler or I have changed the default compiler previously
< naywhayare>
I think that clang is the default, yeah
< naywhayare>
anyway when you submit a PR I'll go ahead and merge it
< trungda>
I am new with mlpack, so should I open a new issue before PR ?
< naywhayare>
nah, PR is just fine
< naywhayare>
if you want to open an issue too, feel free, but just a PR is fine :)
< trungda>
ok :) I am going to make a PR now. thanks for your prompt response.
< naywhayare>
wonderful, thanks so much
govg has joined #mlpack
govg has quit [Client Quit]
govg has joined #mlpack
govg is now known as Guest51161
Guest51161 has quit [Client Quit]
govg_ has joined #mlpack
< trungda>
@naywhayare: sorry for my late, could you please check: https://github.com/mlpack/mlpack/pull/446 and let me know if I need to fix anything (I am new but very excited about mlpack).
< trungda>
I used to work with Spark but I love c++ much more than java/scala.
trungda has quit [Quit: Page closed]
govg_ has quit [Ping timeout: 260 seconds]
govg has joined #mlpack
< zoq>
maybe SplitBoundType and SplitMatType is a better name for the refactoring
travis-ci has joined #mlpack
< travis-ci>
mlpack/mlpack#178 (master - 9f25296 : Ryan Curtin): The build passed.