05:40 <Daanct12> Kwiboo: sorry for not testing the patch earlier, i was busy yesterday and there was a utility pole fire

05:40 <Daanct12> today i did, your patch seems to workaround the setparent issue

08:34 <Kwiboo> Daanct12: thanks for confirming, looking closer it look like the change in clk_set_parent was very recent, so I will shortly send a regression fix patch

08:34 <Daanct12> please cc my email so i can test

08:35 <Kwiboo> sure will do, https://github.com/u-boot/u-boot/commit/ac30d90f33674e49b4428b66f7dd9949f054b6c4 <<-- was the offending commit that changed how clk_set_parent works

08:36 <Daanct12> 

09:08 <Kwiboo> Daanct12: patch sent, see your mail or https://lore.kernel.org/r/20250419090718.2469756-1-jonas@kwiboo.se/

09:11 <Daanct12> it's the exact same patch that i tested

09:46 <Kwiboo> hehe, yes it is the same, originally I was afraid it could affect something more like clk_set_default_parents() or similar, but seeing how the clk_enable() was just introduced a week or two ago skipping the clk_enable() call should be safe

09:46 <Kwiboo> it only restore old behaviour for rockchip clk drivers

09:56 <Daanct12> i'll also remove my clk_enable from the vop2 driver

09:56 <Daanct12> seeing that the trusted firmware enables it

15:27 <Danct12> done :] i'll push v4 after some more reviews

15:29 <Danct12> i also made sure that vop2 is only removed when it's built with CONFIG_VIDEO_REMOVE

15:30 <Danct12> otherwise it'll stay on and the next OS (simplefb) can use it whenever it likes

17:24 <minute> Danct12: there's vop2 support for uboot? :0 with hdmi?

18:40 <Danct12> minute: and dsi support!

18:40 <Danct12> sadly only works on rk356x for now because i can't figure out how cluster works

18:41 <Danct12> perhaps that's something to do later

18:41 <Danct12> then rk3588 can be supported

19:22 <minute> Danct12: ohhh i see