<vagrantc>
you might be able shine a bright flashlight on parts of the display if it's really just the backlight
<macc24>
sphalerite: try setting display init to none in coreboot config
<macc24>
i see that something is probably enabled
<sphalerite>
macc24: hm, which options exactly? "Graphics initialization" is set to the only available option, "Use native graphics init", as is Framebuffer mode (Linear "high-resolution" framebuffer), and "Show graphical bootsplash" is disabled
<sphalerite>
the u-boot.rom is 4MB, but the flash is 8MB, so flashrom doesn't like it
<sphalerite>
should I zero-pad it, or will it just not work?
<macc24>
yea zero pad it
<sphalerite>
hm, the SPL fails to load u-boot proper.
<macc24>
hmm
<macc24>
maybe try building image yourself
stikonas has quit [Remote host closed the connection]
stikonas has joined #linux-rockchip
<sphalerite>
nope, my own build doesn't work either. SPI probe failed.
<macc24>
mmind00: when i send patches to enable px30 dmc frequency scaling, should i rename the driver to something like rockchip_dmc and add px30 support, leave it as is(it will stay rk3399_dmc.c) and add px30 support onto that or copy rk3399_dmc.c into px30_dmc.c and modify px30_dmc.c?
<macc24>
and what about dfi?
<mmind00>
macc24: if the driver _can_ support both with small changes, we want 1 driver for both
<mmind00>
macc24: i.e. the kernel always wants minimal code duplication
<macc24>
mmind00: do i leave the name as "rk3399_dmc.c" + "RK3399 DMC" in kconfig or change it to "rockchip_dmc.c" with "Rockchip DMC" in kconfig?
<mmind00>
macc24: I guess we would want rockchip*
<macc24>
ok
<mmind00>
macc24: for the topic itself (dmc, dfi), I really haven't spent much time on memory frequency scaling at all
<macc24>
yea i got it working on px30/rk3326
<macc24>
also why block of code between lines 117 and 155 isn't a dev_pm_opp_put(opp);? when i replced it with the dev_pm_opp_put function it worked for me
<robmur01>
macc24: beware that changing the module name is technically a user-visible ABI break
<robmur01>
but it's the maintainer's call in the end :)
<macc24>
robmur01: ack
<robmur01>
(FWIW I also lean towards sensible naming being more useful than any theoretical userspace script breakage)
<robmur01>
also a lot of existing RK3399 boards may not be using it anyway, since I'm not sure if upstream TF-A actually has all the necessary machinery (I haven't looked in ages)
<macc24>
it depends if dram timings are set/chagned or whatever
<macc24>
afaik rk3399_dmc.c works without timings set in dts
<sigmaris>
there are no dfi/dmc nodes in mainline rk3399 dts so nothing to load the driver
<macc24>
mmind00: ^ did something not get through? i remember seeing rk3399_dmc dts bindings in mailing list
<mmind00>
macc24: citing Nangi from the Zootopia movie "I don't remember this beaver" ;-) ... meaning I think that dmc stuff came with the gru chromeos upstreaming, but I really don't know where it stopped and what might be missing, as that was essentially 2016-2017 ;-)
<macc24>
mmind00: why do you know random quotes from zootopia
<LinuxHackerman>
robmur01: can't the module naming breakage be handled by an alias?
<macc24>
anyway i have dmc and dfi working in cadmium on rk3399 machines
<mmind00>
macc24: I somehow have movie quotes for a lot of life situations ;-) ... and that elephant is just so me
<sigmaris>
upstream TF-A appears to have support for DDR freq. scaling but when I tried it on a rockpro64 it just hangs part-way through boot, I guess when dmc driver is loaded
<macc24>
sigmaris: can you try again with newest atf? it works perfectly for me on px30
<sigmaris>
i suspect like a lot of DDR-related things in TF-A it was only really tested with DDR3 since that's what chromebooks used
<sigmaris>
macc24: this is with TV-A v2.5 - have there been changes since then?
<macc24>
sigmaris: i meant git master branch
<sigmaris>
*TF-A
<sigmaris>
what's the point in using master branch? Nothing has changed in plat/rockchip since v2.5
<macc24>
just in case
<robmur01>
LinuxHackerman: possibly for tools like modprobe, but technically some folks may only care about the name of the .ko file itself (imagine a custom initramfs-building script)
vagrantc has quit [*.net *.split]
crabbedhaloablut has quit [*.net *.split]
rektide_ has quit [*.net *.split]
stikonas has quit [*.net *.split]
hipboi has quit [*.net *.split]
diederik has quit [*.net *.split]
hramrach has quit [*.net *.split]
maz has quit [*.net *.split]
mmind00 has quit [*.net *.split]
macc24 has quit [*.net *.split]
MatrixTravelerbo has quit [*.net *.split]
sphalerite has quit [*.net *.split]
unkraut has quit [*.net *.split]
robmur01 has quit [*.net *.split]
kilobyte_ch has quit [*.net *.split]
mriesch has quit [*.net *.split]
Esmil has quit [*.net *.split]
eballetbo has quit [*.net *.split]
lopsided98 has quit [*.net *.split]
manawyrm has quit [*.net *.split]
clarity has quit [*.net *.split]
tomeu has quit [*.net *.split]
LinuxHackerman has quit [*.net *.split]
ServerStatsDisco has quit [*.net *.split]
psydroid has quit [*.net *.split]
akanouras has quit [*.net *.split]
shailangsa has quit [*.net *.split]
cp- has quit [*.net *.split]
tlwoerner has quit [*.net *.split]
hl has quit [*.net *.split]
samueldr has quit [*.net *.split]
hanetzer has quit [*.net *.split]
repk has quit [*.net *.split]
Werner has quit [*.net *.split]
tucanae47 has quit [*.net *.split]
leming has quit [*.net *.split]
punit has quit [*.net *.split]
Net147 has quit [*.net *.split]
jelly has quit [*.net *.split]
rtp has quit [*.net *.split]
mps has quit [*.net *.split]
wens_ has quit [*.net *.split]
sigmaris has quit [*.net *.split]
tchebb has quit [*.net *.split]
arnd has quit [*.net *.split]
dianders has quit [*.net *.split]
mx08 has quit [*.net *.split]
eballetbo has joined #linux-rockchip
crabbedhaloablut has joined #linux-rockchip
Esmil has joined #linux-rockchip
diederik has joined #linux-rockchip
rektide_ has joined #linux-rockchip
mmind00 has joined #linux-rockchip
hipboi has joined #linux-rockchip
hramrach has joined #linux-rockchip
maz has joined #linux-rockchip
jelly has joined #linux-rockchip
rtp has joined #linux-rockchip
Net147 has joined #linux-rockchip
tomeu has joined #linux-rockchip
clarity has joined #linux-rockchip
lopsided98 has joined #linux-rockchip
manawyrm has joined #linux-rockchip
dianders has joined #linux-rockchip
arnd has joined #linux-rockchip
tchebb has joined #linux-rockchip
sigmaris has joined #linux-rockchip
mps has joined #linux-rockchip
mx08 has joined #linux-rockchip
wens_ has joined #linux-rockchip
shailangsa has joined #linux-rockchip
cp- has joined #linux-rockchip
hl has joined #linux-rockchip
tlwoerner has joined #linux-rockchip
unkraut has joined #linux-rockchip
MatrixTravelerbo has joined #linux-rockchip
macc24 has joined #linux-rockchip
sphalerite has joined #linux-rockchip
mriesch has joined #linux-rockchip
kilobyte_ch has joined #linux-rockchip
robmur01 has joined #linux-rockchip
LinuxHackerman has joined #linux-rockchip
akanouras has joined #linux-rockchip
akanouras has quit [Ping timeout: 272 seconds]
punit has joined #linux-rockchip
leming has joined #linux-rockchip
hanetzer has joined #linux-rockchip
repk has joined #linux-rockchip
samueldr has joined #linux-rockchip
tucanae47 has joined #linux-rockchip
Werner has joined #linux-rockchip
shailangsa has quit [Max SendQ exceeded]
MatrixTravelerbo has quit [Max SendQ exceeded]
stikonas has joined #linux-rockchip
vagrantc has joined #linux-rockchip
samueldr has quit [Ping timeout: 272 seconds]
LinuxHackerman has quit [Ping timeout: 272 seconds]