dnkl changed the topic of #foot to: Foot - fast, lightweight and minimalistic Wayland terminal emulator || 1.7.2 || https://codeberg.org/dnkl/foot || channel logs: https://libera.irclog.whitequark.org/foot
amk has quit [Ping timeout: 252 seconds]
amk has joined #foot
novakane has joined #foot
yyp has joined #foot
yyp has quit [Remote host closed the connection]
yyp has joined #foot
yyp has quit [Remote host closed the connection]
yyp has joined #foot
novakane has quit [Quit: WeeChat 3.1]
novakane has joined #foot
novakane has quit [Quit: WeeChat 3.1]
novakane has joined #foot
novakane has quit [Quit: WeeChat 3.1]
amk has quit [Remote host closed the connection]
amk has joined #foot
novakane has joined #foot
cbb has joined #foot
novakane has quit [Quit: WeeChat 3.1]
novakane has joined #foot
novakane has quit [Quit: WeeChat 3.1]
novakane has joined #foot
<cbb> dnkl: I just noticed a sequence that behaves differently in foot vs xterm
<cbb> printf "\033+0\033Omm\n"
<cbb> i.e. designate the line drawing character set as G3, then SS3, print 2x 'm' followed by a newline
<cbb> the SS3 invokes G3 for the next character in xterm
<cbb> whereas foot prints "mm"
<dnkl> cbb: I'm getting "mm" in both foot and XTerm
<dnkl> Are you sure you haven't changed the G3 charset in your XTerm instance?
<dnkl> No, sorry. Mistyped the printf...
<cbb> dnkl: my xterm config is pretty minimal
<cbb> Or Xresources rather
<dnkl> cbb: yeah, seeing what you're seeing now
<cbb> I only change the colors, font, etc.
<dnkl> I would suspect we're failing to switch the ASCII printer from the "fast" version to the "generic" one
<cbb> dnkl: I suspected that too
<cbb> but I checked out the commit before that was changed, and the behaviour seems the same
<cbb> dnkl: oh, scratch that, I didn't go back far enough
<cbb> I'll try again
<dnkl> cbb: we're not switching printer (just tested)
<cbb> dnkl: ah nice, hopefully an easy fix then
<dnkl> cbb: yeah. We're getting the wrong charset index when handling the first escape
<dnkl> cbb: the charset selector is completely broken 😅
<dnkl> cbb: vt.c, line 453
<dnkl> Rookie mistake...
<dnkl> And the same thing a couple of lines below
<cbb> dnkl: hmm, I was just about to send a PR for that exact line
<cbb> but I didn't notice the original was broken
<cbb> I was just going to simplify the index to: priv - '('
<dnkl> cbb: just push :). I won't be able to push a fix for several hours
<dnkl> cbb: sounds good
<dnkl> Those two places are the only ones I'm seeing
<cbb> dnkl: yeah I already searched for others
<cbb> I'm pretty sure they are
<cbb> I'll push a fix
<dnkl> cbb: awesome, thanks!
<cbb> dnkl: no worries
<dnkl> cbb: next bug: foot doesn't switch back
<cbb> dnkl: lol yeah I was just about to say that
<cbb> it seems the single shift sequence do the same thing as the locking shifts
<cbb> dnkl: I guess it needs a flag to tell the printer to switch back
<cbb> after the next char
<dnkl> cbb: if I'm reading things correctly, G2 and G3 are always single shift?
<dnkl> G0 and G1 are the locked charsets?
<cbb> G2 and G3 are charset designations
<cbb> the shifts are e.g. SS3 and LS3
<dnkl> cbb: ah, I believe we're missing LS3
<cbb> in the case of single shifts: "this affects next character only"
<dnkl> That's why I couldn't find any other G2/G3 usages in foot
<cbb> dnkl: yeah LS3 does seem to be missing
<dnkl> Yeah, that's it.
<dnkl> So yeah, a flag for single shift, and add them locked versions
<dnkl> The*
<cbb> I was eventually also going to ask you about the other charsets
<cbb> i.e. the "national replacement charsets"
<dnkl> I've never seen them used. As far as I know at least. But if they are used, we should implement them
<cbb> dnkl: yeah I don't think any modern stuff uses them
<cbb> so it seems a reasonable option to just not support them
<cbb> with the single exception perhaps being the UK one
<cbb> since that's one of the 3 that were supported by the VT100
<dnkl> Any particular reason? :)
<dnkl> Ah
<cbb> and the sequences themselves were also first supported by the VT100
<dnkl> Still, if it's not being used, I think we can skip that one too
<cbb> dnkl: yeah, I guess so
<cbb> the swapped characters are actually pretty minimal
<cbb> (the ones highlighted in red on the right side)
<cbb> so it doesn't require large tables
<cbb> but yeah, it's probably fine to just ignore them
<cbb> dnkl: I'll take a look at fixing the other issues first anyway
<dnkl> cbb: I opened up two issues for SS2/SS3 and LS2/LS3
cbb has quit [Ping timeout: 264 seconds]
cbb has joined #foot
Jano[m] has quit [Remote host closed the connection]
mvdan has quit [Read error: Connection reset by peer]
mvdan has joined #foot
Jano[m] has joined #foot
amk has quit [Remote host closed the connection]
amk has joined #foot
<kmarius> debug output can only be disabled with the command line flag and not with a config option/env variable, right?
dutchie has quit [*.net *.split]
Eragonfr has quit [*.net *.split]
Eragonfr has joined #foot
Eragonfr has quit [Signing in (Eragonfr)]
Eragonfr has joined #foot
dutchie has joined #foot
Eragonfr is now known as Guest9453
<cbb> kmarius: yes, the log level can only be set with --log-level= at the moment
<kmarius> cbb: that's what I figured. I'd rather do either of the two but a wrapper will do fine
<cbb> kmarius: I was thinking about sending a PR to add "log-level" config option....but then I decided I don't really need one
<cbb> I just start a server as: foot --server --log-level=warning
<cbb> but I'm sure dnkl would consider it if someone asked
novakane has quit [Quit: WeeChat 3.1]
novakane has joined #foot
tdeo has joined #foot
Guest9453 has quit [Quit: WeeChat 3.1]
eragon has joined #foot
yyp has quit [Remote host closed the connection]
avane has quit [Ping timeout: 244 seconds]
hspak045033 is now known as hspak
mcol has quit [Quit: leaving]
avane has joined #foot
novakane has quit [Quit: WeeChat 3.1]
cbb has quit [Quit: WeeChat 3.1]