michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 7.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
kepstin has quit [Remote host closed the connection]
kepstin has joined #ffmpeg-devel
thilo_ has quit [Ping timeout: 264 seconds]
thilo_ has joined #ffmpeg-devel
feiw1 has quit [Ping timeout: 264 seconds]
feiw1 has joined #ffmpeg-devel
haihao has quit [Ping timeout: 276 seconds]
haihao_ has joined #ffmpeg-devel
vipyne has joined #ffmpeg-devel
wyatt8750 has quit [Ping timeout: 265 seconds]
haihao_ has quit [Ping timeout: 276 seconds]
haihao has joined #ffmpeg-devel
haihao has quit [Ping timeout: 252 seconds]
haihao_ has joined #ffmpeg-devel
wyatt8740 has joined #ffmpeg-devel
vipyne has quit [Quit: Leaving.]
vipyne has joined #ffmpeg-devel
vipyne has quit [Client Quit]
arch1t3cht0 has joined #ffmpeg-devel
arch1t3cht has quit [Ping timeout: 246 seconds]
arch1t3cht0 is now known as arch1t3cht
haihao_ has quit [Ping timeout: 252 seconds]
haihao has joined #ffmpeg-devel
osvein has quit [Quit: Ping timeout (120 seconds)]
Marth64 has quit [Remote host closed the connection]
osvein has joined #ffmpeg-devel
georgereynolds8 has quit [Quit: Ping timeout (120 seconds)]
georgereynolds8 has joined #ffmpeg-devel
psykose has quit [Read error: Connection reset by peer]
psykose has joined #ffmpeg-devel
wyatt8740 has quit [Quit: ZNC got killed or something else has gone wrong, probably.]
rvalue has quit [Remote host closed the connection]
wyatt8740 has joined #ffmpeg-devel
rvalue has joined #ffmpeg-devel
pross has quit [Ping timeout: 252 seconds]
feiw1 has quit [Ping timeout: 276 seconds]
feiw1 has joined #ffmpeg-devel
pross has joined #ffmpeg-devel
Marth64 has joined #ffmpeg-devel
haihao has quit [Ping timeout: 252 seconds]
Martchus has joined #ffmpeg-devel
haihao_ has joined #ffmpeg-devel
Martchus_ has quit [Ping timeout: 260 seconds]
jamrial has quit []
compn has joined #ffmpeg-devel
compnnn has quit [Read error: Connection reset by peer]
HarshK23 has joined #ffmpeg-devel
haihao_ has quit [Ping timeout: 265 seconds]
haihao has joined #ffmpeg-devel
haihao has quit [Ping timeout: 252 seconds]
haihao has joined #ffmpeg-devel
Traneptora has quit [Ping timeout: 252 seconds]
haihao has quit [Ping timeout: 252 seconds]
haihao has joined #ffmpeg-devel
haihao has quit [Ping timeout: 264 seconds]
haihao has joined #ffmpeg-devel
haihao has quit [Ping timeout: 276 seconds]
haihao has joined #ffmpeg-devel
<Marth64>
fate is failing for anyone else on TEST acodec-pcm-s16le ?
<elenril>
no
<Marth64>
hm
<Marth64>
wrong sample dir .. oops
ngaullier has joined #ffmpeg-devel
Krowl has joined #ffmpeg-devel
Traneptora has joined #ffmpeg-devel
<jdarnley>
Marth64: last night I found that the dvd demuxer only showed 4 out of 5 chapters for a title as reported by lsdvd. I'll see if I can make a better bug report later.
Krowl has quit [Read error: Connection reset by peer]
Krowl has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
cone-345 has joined #ffmpeg-devel
<cone-345>
ffmpeg Martin Storsjö release/7.1:0b5559378b1e: libavcodec: x86: Remove an explicit include of config.asm
osvein has quit [Ping timeout: 272 seconds]
osvein has joined #ffmpeg-devel
microchip__ has joined #ffmpeg-devel
elChippo has joined #ffmpeg-devel
microchip__ has quit [Client Quit]
microchip_ has quit [Ping timeout: 265 seconds]
<bcheng>
Lynne: by my reading it's only required if you create an image view with aspectMask = COLOR and usage contains SAMPLED
<Lynne>
bcheng: if you get rid of it, the validation layer will yell at you
<Lynne>
I brought this up before the decoding spec was finialized, but there was no time to change anything, and it was part of the cursed ycbcr images spec anyway
<Lynne>
what we do isn't even fully correct, the sampler has to be known and given at image creation time IIRC, but what we do is enough to shut the layer up
<bcheng>
hm I'll have a try at removing it
jamrial has joined #ffmpeg-devel
elChippo is now known as microchip_
Krowl has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
<Marth64>
jdarnley: thanks. did it get all the content but miss the marker?
Krowl has joined #ffmpeg-devel
<Marth64>
also try with -preindex 1 if you can
<bcheng>
Lynne: I don't get any new validation errors by removing that flag. but let me check with radv
vipyne has joined #ffmpeg-devel
<jdarnley>
Marth64: yes I think so. Is that an option for skipping (or not skipping) 0-length chapters? I think they were all at least 1 second, or 1 minute. I'll try it later anyway.
<Marth64>
jdarnley: skipping 0-length chapters is built in automatically. the -preindex option is to yield accurate chapter markers, since dvdnav does not return pts exact markers (it may seem like it when seeking in vlc or mpv but that is a side effect of the seeking and not the actual times reported)
<jdarnley>
I see. So it isn't reading them from whatever source lsdvd is?
<Marth64>
when using -preindex 1 it will walk the whole disc and get exact pts from the nav packets. when off (default), it will lean on dvdnav's chapter functions of which lsdvd does a very similar lookup
<Marth64>
i have also fixed some issues in the v3 patch set on the ML if you have time to try some time. thank you again
cone-345 has quit [Quit: transmission timeout]
<Marth64>
if it was a 1 second chapter, likely it was a padding cell (which also gets removed because these can mess with the video params and put bogus info). but one can disable the skipping with -trim 0
<Marth64>
a very popular dvd demuxer does the same thing, only the preindexing is faster because they jump directly to nav packets rather than reading the whole disc. i am working on a patch for libdvdnav to allow this speed gain
<Marth64>
i have studied all of them and each has a major fault. the most popular one is good but it strips closed captions
<Marth64>
i'm aiming to have the best demuxer for the long term
vipyne has quit [Quit: Leaving.]
feiw1 has quit [Ping timeout: 260 seconds]
feiw1 has joined #ffmpeg-devel
<elenril>
one dvd handler to rule them all
<Marth64>
yess
Krowl has quit [Read error: Connection reset by peer]
<Marth64>
and a bdmv one on the way
<bcheng>
Lynne: sent a patch. You only need to provide the ycbcr conversion sampler if you make the image with SAMPLED, and the image view with aspectMask = COLOR (in which case you are indeed converting to RGB)
<bcheng>
For (dedicated) DPB images you aren't ever sampling the images, so there's no need for it
ccawley2011 has joined #ffmpeg-devel
microlappy has joined #ffmpeg-devel
microlappy has quit [Client Quit]
Krowl has joined #ffmpeg-devel
aljazmc has joined #ffmpeg-devel
ngaullier has quit [Ping timeout: 252 seconds]
iive has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
aljazmc has quit [Quit: Leaving]
cone-455 has joined #ffmpeg-devel
<cone-455>
ffmpeg James Almer master:3290692d185e: avcodec/hevc/ps: return a proper error code when we don't support parsing an sps
<cone-455>
ffmpeg James Almer master:bd6283342c85: avcodec/hevc/ps: add a range check for sps_max_sub_layers
rajivharlalka has quit [Remote host closed the connection]
rajivharlalka has joined #ffmpeg-devel
b50d has joined #ffmpeg-devel
b50d has quit [Ping timeout: 265 seconds]
darkdrgn2k has quit [Ping timeout: 245 seconds]
<Marth64>
bdmv demuxer is feature complete. I will work on docs and some code cleanup and send to ML. marking AVFMT_EXPERIMENTAL for now
<Marth64>
will circle back on providing user listing of titles as DVD will need same problem solved
<Marth64>
have not tested with uhd unfortunately but it should be fine
<Lynne>
why experimental?
<Marth64>
i just was thinking to give it some time to mature and see how it handles different samples. even with DVD it took me a long time to realize subtle fixes needed and weird encoders being out there.
<Lynne>
bcheng: could you remove the remnants of yuv_sampler too?
<Lynne>
the same code is ran for encoding too, so you can rip it out of there too
tufei_ has joined #ffmpeg-devel
tufei__ has quit [Remote host closed the connection]
vipyne has joined #ffmpeg-devel
<bcheng>
Lynne: I didn't look into it too much but I saw the bwdif thing (which I assume operates on decode output) uses combined image sampler, which actually does require yuv conversion
<bcheng>
does bwdif actually need yuv conversion? if not I think you can avoid yuv_sampler all together. you can create image views for each plane separately
<cone-455>
ffmpeg Lynne master:c982376076b6: vulkan: extend ff_vk_shader_rep_fmt to be useful for bitexactness
<cone-455>
ffmpeg Lynne master:1addd0fdca14: vulkan: use correct signed image type for storage images
<cone-455>
ffmpeg Lynne master:d55a3517419b: hwcontext_vulkan: add support for AV_PIX_FMT_RGBAF32
<cone-455>
ffmpeg Lynne master:168e8ae9bf02: hwcontext_vulkan: add support for AV_PIX_FMT_RGBF32
<cone-455>
ffmpeg Lynne master:8c47cf9eeaca: hwcontext_vulkan: enable shaderBufferInt64Atomics if supported
<Lynne>
bcheng: no, we never use yuv samplers (we cannot, as we don't know what kind of sampler will be used during image creation)
<Lynne>
(also because I have a distrust of drivers to get basic stuff like mark formats as supported for encode/decode, let alone get colorspace conversions right)
<Lynne>
combined image samplers don't require yuv conversions if you always use single-plane representation of images
<Lynne>
VK_IMAGE_ASPECT_PLANE_0/1/2_BIT, etc.
vipyne has quit [Ping timeout: 252 seconds]
tufei_ has quit [Remote host closed the connection]