ChanServ changed the topic of #crystal-lang to: The Crystal programming language | https://crystal-lang.org | Fund Crystal's development: https://crystal-lang.org/sponsors | GH: https://github.com/crystal-lang/crystal | Docs: https://crystal-lang.org/docs | Gitter: https://gitter.im/crystal-lang/crystal
Guest32 has joined #crystal-lang
Guest32 has quit [Client Quit]
notzmv has joined #crystal-lang
_ht has joined #crystal-lang
ur5us has joined #crystal-lang
ur5us has quit [Quit: Leaving]
ur5us has joined #crystal-lang
Sankalp has quit [Ping timeout: 268 seconds]
Sankalp has joined #crystal-lang
jhass[m] has quit [Read error: Connection reset by peer]
jhass[m] has joined #crystal-lang
Sankalp has quit [Ping timeout: 268 seconds]
Sankalp has joined #crystal-lang
jmdaemon has quit [Ping timeout: 252 seconds]
ur5us has quit [Ping timeout: 264 seconds]
onyx has joined #crystal-lang
Guest35 has joined #crystal-lang
Guest35 has quit [Client Quit]
<repo> Blacksmoke16: https://p.jokke.space/m-9PYZs/
<repo> was easier than i expected
<repo> i also managed to make the field resolving concurrent in the graphql shard. It seems a bit like a hack though... I have to build individual json fragments for the fields and then add them to the current builder using JSON::Builder#raw...
<repo> i'll try another approach where i build a nested hash and then have the json serialization as a separate step
<repo> would seem cleaner to me
<FromGitter> <Blacksmoke16> would it makes sense for the data loader to like include `Iterator`
<FromGitter> <Blacksmoke16> or at least `Enumerable`
jmdaemon has joined #crystal-lang
onyx has quit [Read error: Connection reset by peer]
yxhuvud has quit [Read error: Connection reset by peer]
yxhuvud has joined #crystal-lang
_ht has quit [Remote host closed the connection]
_ht has joined #crystal-lang
_ht has quit [Remote host closed the connection]
<repo> Blacksmoke16: how come?
<repo> i managed to resolve to hash and to_json in a separate step! \o/ much cleaner imo: https://github.com/graphql-crystal/graphql/pull/36
<FromGitter> <Blacksmoke16> so you could pass it to things that are typed like that. but after looking at the code again prob wouldnt make too much sense
<FromGitter> <Blacksmoke16> nice one!
<repo> yeah the dataloaders would be pretty short lived objects and live in a request context
<repo> the cache would otherwise make no sense
<repo> it should reduce database calls made during a single request
<repo> (which in a graphql request can be veeeery many)
<FromGitter> <Blacksmoke16> 👍 makes sense yea