tardyp changed the topic of #buildbot to: A Software Freedom Conservancy Project | Buildbot-3.2.0 | docs: http://docs.buildbot.net/current/ | tutorial: http://docs.buildbot.net/current/tutorial | irclogs: https://libera.irclog.whitequark.org/buildbot
aakashjain has joined #buildbot
aakashjain has quit [Ping timeout: 240 seconds]
aakashjain has joined #buildbot
aakashjain has quit [Ping timeout: 240 seconds]
bdbaddog has quit [Quit: Leaving.]
aakashjain has joined #buildbot
aakashjain has quit [Ping timeout: 240 seconds]
aakashjain has joined #buildbot
aakashjain has quit [Ping timeout: 240 seconds]
aakashjain has joined #buildbot
aakashjain has quit [Ping timeout: 240 seconds]
aakashjain has joined #buildbot
aakashjain has quit [Ping timeout: 240 seconds]
bdbaddog has joined #buildbot
aakashjain has joined #buildbot
glogan has joined #buildbot
<glogan> I'm trying to write a new BuildStep to create a GitHub release, and I'm seeing this once the step finishes: https://pastebin.com/Csh3TcVU
<glogan> I'm not entirely sure what I'm doing wrong. I've overridden getCurrentSummary, getResultsSummary, run is hardcoded to yield a results.SUCCESS
aakashjain has quit [Ping timeout: 240 seconds]
<dol-sen> glogan, looks like you are assigning the yield instead of just yielding it
cognifloyd has joined #buildbot
<dol-sen> but my python is rusty atm
<dol-sen> glogan, I'm wrong. your paste shows only buildbot code, not any of your step code
<dol-sen> so no way of knowing what you did wrong
<glogan> I'm wondering if I've done something wrong in the overrides
<dol-sen> paste or point to your code
<dol-sen> yield results.SUCCESS
<dol-sen> where did you get results from?
<dol-sen> you have: release =
<glogan> from buildbot.process import results
<dol-sen> should that be release.SUCCESS
<glogan> release is a GitHub object, not a buildbot thing
<glogan> Removing all of the github bits yields the same behaviour :)
<dol-sen> your import of results is before your code runs then
<dol-sen> so it has nothing, causing your traceback
<dol-sen> WAFFLES!!!! bbl
<glogan> yep, full file is https://pastebin.com/ECGvri01
<Zorry> from buildbot.process.results import SUCCESS
<Zorry> return SUCCESS
<Zorry> you may need a yield on the release = opencast.....
<glogan> Zorry: return from that method spits out `builtins.TypeError: inlineCallbacks requires <function GenerateGithubRelease.run at 0x7f730c5a4400> to produce a generator; instead got 0`
<glogan> yielding SUCCESS rather than results.SUCCESS has the same behaviour as I originally saw
bdbaddog has quit [Quit: Leaving.]
<Zorry> if you don't yield the success?
<glogan> yield SUCCESS -> https://pastebin.com/Csh3TcVU
<glogan> I guess i haven't tried yielding other things, but I somehow doubt that would change anything
<Zorry> if you just do return SUCCESS
<Zorry> no yield on that line
<glogan> Zorry: return SUCCESS -> builtins.TypeError: inlineCallbacks requires <function GenerateGithubRelease.run at 0x7f730c5a4400> to produce a generator; instead got 0
<glogan> I guess I could remove the defer on the run method, but I'm expecting that's not the right idea either
<Zorry> if you don't have any yield it shound be removed
<glogan> hey, there we go, thanks Zorry
<glogan> remove the defer, used return, and things work as expected
<glogan> I thought i needed to defer the run method. Guess not.
<dol-sen> yeah, defer is for future results
<dol-sen> but your code runs directly
aakashjain has joined #buildbot
aakashjain has quit [Ping timeout: 240 seconds]