10:58 <d1b2> <fredzo_72653> @azonenberg I get a compilation error with this latest commit : "/ngscopeclient/scopehal-apps/src/ngscopeclient/NFDFileBrowser.cpp:38:10: fatal error: nfd_glfw3.h: No such file or directory" Did I miss something ?

11:35 <d1b2> <fredzo_72653> Never mind, it was me not me not updating the submodule... 🤦‍♂️

12:30 <d1b2> <fredzo_72653> @azonenberg your latest commit breaks compilation on WIN32: .../NFDFileBrowser.cpp: In member function 'std::optional<std::__cxx11::basic_string<char> > NFDFileBrowser::ThreadProc()': .../NFDFileBrowser.cpp:136:35: error: cannot convert 'nfdfilteritem_t' {aka 'nfdu8filteritem_t'} to 'const nfdnfilteritem_t' in assignment 136 | args.filterList = &filterItem; | ^~~~~~~~~~~ |

12:30 <d1b2> | | nfdfilteritem_t {aka nfdu8filteritem_t} .../NFDFileBrowser.cpp:141:47: error: cannot convert 'nfdchar_t' {aka 'char'} to 'nfdnchar_t' {aka 'wchar_t'} 141 | result = NFD_SaveDialogN_With(&outPath, &args); | ^~~~~~~~ | | |

12:30 <d1b2> nfdchar_t {aka char} In file included from .../NFDFileBrowser.h:39, from .../NFDFileBrowser.cpp:36: ngscopeclient/scopehal-apps/src/nativefiledialog-extended/src/include/nfd.h:335:58: note: initializing argument 1 of 'nfdresult_t NFD_SaveDialogN_With(nfdnchar_t**, const nfdsavedialognargs_t)' 335 | NFD_INLINE nfdresult_t NFD_SaveDialogN_With(nfdnchar_t** outPath, |

12:30 <d1b2> ~~~~~~~~~~~^~~ .../NFDFileBrowser.cpp:147:35: error: cannot convert 'nfdfilteritem_t' {aka 'nfdu8filteritem_t'} to 'const nfdnfilteritem_t*' in assignment 147 | args.filterList = &filterItem; | ^~~~~~~~~ | | | nfdfilteritem_t* {aka nfdu8filteritem_t*}

12:30 <d1b2> <fredzo_72653> AFAIU the cross-platform compatible way to do this is to use the U8 alternative of NFDe. See (https://github.com/btzy/nativefiledialog-extended): "The U8/u8 in NFDe refer to the API for UTF-8 characters (char), which most consumers probably want. An N/n version is also available, which uses the native character type (wchar_t on Windows and char on other platforms)."

12:31 <d1b2> <fredzo_72653> I fixed it that way : optional<string> NFDFileBrowser::ThreadProc() { if(NFD_Init() != NFD_OKAY) { LogError("NFD_Init() failed\n"); return {}; } nfdchar_t* outPath; nfdu8filteritem_t filterItem = { m_filterName.c_str(), m_filterMask.c_str() }; nfdresult_t result; if(m_saveDialog) { //Fill out arguments nfdsavedialogu8args_t args; args.filterList = &filterItem;

12:31 <d1b2> args.filterCount = 1; args.defaultPath = nullptr; NFD_GetNativeWindowFromGLFWWindow(m_parent->GetWindow(), &args.parentWindow); result = NFD_SaveDialogU8_With(&outPath, &args); } else { //Fill out arguments nfdopendialogu8args_t args; args.filterList = &filterItem; args.filterCount = 1; args.defaultPath = nullptr;

12:31 <d1b2> NFD_GetNativeWindowFromGLFWWindow(m_parent->GetWindow(), &args.parentWindow); //And run the dialog result = NFD_OpenDialogU8_With(&outPath, &args); } if(result == NFD_OKAY) { string ret = outPath; NFD_FreePath(outPath); NFD_Quit(); return ret; } else { NFD_Quit(); return {}; } }

14:04 <d1b2> <azonenberg> Interesting, oops. Please send a PR to fix?

14:04 <d1b2> <azonenberg> we should be using UTF-8 for paths

14:05 <d1b2> <azonenberg> i guess i misunderstood the changes in the new NFD version

14:10 <d1b2> <azonenberg> I actually thought the opposite was the caase

14:10 <d1b2> <azonenberg> i read u8 as "unsigned 8" and thought it was for platforms using unsigned chars by default lol

14:29 <_whitenotifier-1> [scopehal-apps] fredzo opened pull request #750: Fixed WIN32 compilation. - https://github.com/ngscopeclient/scopehal-apps/pull/750