azonenberg changed the topic of #scopehal to: ngscopeclient, libscopehal, and libscopeprotocols development and testing | https://github.com/ngscopeclient/scopehal-apps | Logs: https://libera.irclog.whitequark.org/scopehal
Degi has quit [Ping timeout: 255 seconds]
Degi has joined #scopehal
bvernoux has joined #scopehal
bvernoux has quit [Quit: Leaving]
Degi has quit [Ping timeout: 240 seconds]
Degi has joined #scopehal
<mxshift> Current main fails to build on Fedora 40 due to something in SiglentSCPI driver.
<_whitenotifier-9> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/ngscopeclient/scopehal/compare/64bd8eea2a15...62a5d662132c
<_whitenotifier-9> [scopehal] azonenberg 62a5d66 - Changed m_maxLogicDepth to size_t to fix some casting issues on clang
<_whitenotifier-9> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/ngscopeclient/scopehal-apps/compare/f69cb4cdf668...7a415841f0ee
<_whitenotifier-9> [scopehal-apps] azonenberg 7a41584 - Updated submodules
<azonenberg> mxshift: can you be more specific than "something"?
<azonenberg> (also just pushed a fix for a build issue on clang)
<azonenberg> balrog: ^
<mxshift> SiglentSCPIOscilloscope.cpp:1973 is triggering an offset out of bounds error but I don't know why yet
<azonenberg> mxshift: yeah i've seen that error but i dont know whats causing it
<azonenberg> we resize waveforms to m_analogChannelCount on 1947
<azonenberg> and the loop bounds are 0 to m_analogChannelCount-1
<azonenberg> But it looks like the bounds error it's giving is actually in the operator=() call
<azonenberg> not the indexing
<azonenberg> and i don't know why that would be happening
<azonenberg> I think i poked someone a while back and was unable to solve it
<azonenberg> waveforms is a vector<vector<WaveFormBase*>>
<azonenberg> so each element is a vector<WaveformBase*>
<azonenberg> Which is exactly what ret is