azonenberg changed the topic of #scopehal to: ngscopeclient, libscopehal, and libscopeprotocols development and testing | https://github.com/ngscopeclient/scopehal-apps | Logs: https://libera.irclog.whitequark.org/scopehal
joshua_ has joined #scopehal
joshua_ has quit [Ping timeout: 256 seconds]
joshua_ has joined #scopehal
Degi_ has joined #scopehal
Degi has quit [Ping timeout: 240 seconds]
Degi_ is now known as Degi
joshua_ has quit [Ping timeout: 268 seconds]
joshua_ has joined #scopehal
joshua_ has quit [Ping timeout: 240 seconds]
joshua_ has joined #scopehal
joshua_ has quit [Ping timeout: 268 seconds]
joshua_ has joined #scopehal
<d1b2> <miek__> Is anyone else using ngscopeclient with a tiling window manager? I'm using it on i3 and having trouble with tooltips and menus trying to render as full-screen windows. I wonder if there's a way in imgui to hint that they should be floating?
<d1b2> <246tnt> @miek__ I am.
<d1b2> <246tnt> I didn't find anything that worked in imgui so I disabled viewports so that it all stay inside the main window.
<d1b2> <246tnt> works fine for me as I use it full screen anyway ...
<d1b2> <246tnt> diff diff --git a/src/ngscopeclient/VulkanWindow.cpp b/src/ngscopeclient/VulkanWindow.cpp index c35276c6..c07f2f26 100644 --- a/src/ngscopeclient/VulkanWindow.cpp +++ b/src/ngscopeclient/VulkanWindow.cpp @@ -80,7 +80,7 @@ VulkanWindow::VulkanWindow(const string& title, shared_ptr<QueueHandle> queue) ImGuiIO& io = ImGui::GetIO(); io.ConfigFlags |= ImGuiConfigFlags_NavEnableKeyboard; io.ConfigFlags |=
<d1b2> ImGuiConfigFlags_DockingEnable; - io.ConfigFlags |= ImGuiConfigFlags_ViewportsEnable; +// io.ConfigFlags |= ImGuiConfigFlags_ViewportsEnable; //Don't serialize UI config for now //TODO: serialize to scopesession or something? https://github.com/ocornut/imgui/issues/4294 @@ -184,6 +184,7 @@ VulkanWindow::VulkanWindow(const string& title, shared_ptr<QueueHandle> queue) ImGui::GetStyle().ScaleAllSizes(scale);
<d1b2> //Hook a couple of backend functions with mutexing +#if 0 ImGuiPlatformIO& platform_io = ImGui::GetPlatformIO(); ImGui_ImplVulkan_CreateWindow = platform_io.Renderer_CreateWindow; ImGui_ImplVulkan_DestroyWindow = platform_io.Renderer_DestroyWindow; @@ -191,6 +192,7 @@ VulkanWindow::VulkanWindow(const string& title, shared_ptr<QueueHandle> queue) platform_io.Renderer_CreateWindow = Mutexed_ImGui_ImplVulkan_CreateWindow;
<d1b2> platform_io.Renderer_DestroyWindow = Mutexed_ImGui_ImplVulkan_DestroyWindow; platform_io.Renderer_SetWindowSize = Mutexed_ImGui_ImplVulkan_SetWindowSize; +#endif m_plotContext = ImPlot::CreateContext();
<d1b2> <azonenberg> @246tnt want to file a ticket (and/or PR) to make this a preference setting?
<d1b2> <246tnt> Sure.
<azonenberg> Also, is there any kind of API on Linux to determine if you are using a tiling window manager?
<azonenberg> (so we can set a reasonable default on first start)
<_whitenotifier-6> [scopehal-apps] smunaut opened issue #708: Allow disabling of imgui "viewports" - https://github.com/ngscopeclient/scopehal-apps/issues/708
<d1b2> <miek__> thanks! that's working well for me too
<d1b2> <246tnt> @azonenberg I think the best you could do is detect the final window size for that new window isn't what you requested ... but that's all handled inside imgui, no idea how you'd get access to that. There is a 'wmname' where you can query the wmname but you'd need to keep a list of wm names. (and then I override mine to LG3D anyway to make java apps work 😅 )
<_whitenotifier-6> [scopehal] miek opened pull request #868: AgilentOscilloscope: add missing timestamp for digital waveforms - https://github.com/ngscopeclient/scopehal/pull/868
<azonenberg> i mean it'd still be end user configurable
<azonenberg> but if we can identify tiling WMs and default to tiling-friendly behavior that'd be nice
<azonenberg> miek: re your PR, please specify the full resolution timestamp using both seconds and fs
<azonenberg> (actually it looks like a lot of drivers do this badly, i will need to do some refactoring)
<azonenberg> the correct, cross platform way to do this is call GetTime() and set startTimestamp to floor(t) and startFemtoseconds to (t-floor(t)) * FS_PER_SECOND
<azonenberg> (a lot of drivers call time(NULL) for each channel to get the integer part of the seconds which may give inaccurate if the waveform is acquired a few microseconds before a second boundary)
joshua_ has quit [Ping timeout: 246 seconds]
joshua_ has joined #scopehal
<_whitenotifier-5> [scopehal] azonenberg pushed 2 commits to master [+0/-0/±3] https://github.com/ngscopeclient/scopehal/compare/7634dce6ff47...631c5ecedbba
<_whitenotifier-6> [scopehal] azonenberg 263a697 - Added skeleton method to pull 64/66b trigger (doesnt actually do anything yet but shuts up warning message that hides important debug output)
<_whitenotifier-5> [scopehal] azonenberg 631c5ec - EthernetProtocolDecoder: LogTrace on checksum failure
<_whitenotifier-6> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±5] https://github.com/ngscopeclient/scopehal-apps/compare/33c7cddc344f...deebf309ce78
<_whitenotifier-5> [scopehal-apps] azonenberg deebf30 - Added preference setting to disable ImGuiConfigFlags_ViewportsEnable. See #708
<_whitenotifier-6> [scopehal-apps] azonenberg commented on issue #708: Allow disabling of imgui "viewports" - https://github.com/ngscopeclient/scopehal-apps/issues/708#issuecomment-2053724310
<_whitenotifier-6> [scopehal-apps] azonenberg edited issue #708: Better handling of tooltips etc on tiling window managers - https://github.com/ngscopeclient/scopehal-apps/issues/708
<_whitenotifier-5> [scopehal] miek synchronize pull request #868: AgilentOscilloscope: add missing timestamp for digital waveforms - https://github.com/ngscopeclient/scopehal/pull/868
<_whitenotifier-6> [scopehal] azonenberg closed pull request #868: AgilentOscilloscope: add missing timestamp for digital waveforms - https://github.com/ngscopeclient/scopehal/pull/868
<_whitenotifier-5> [scopehal] azonenberg 48d2f41 - Merge pull request #868 from miek/agilent-digital-timestamp AgilentOscilloscope: add missing timestamp for digital waveforms
<_whitenotifier-6> [scopehal] azonenberg pushed 2 commits to master [+0/-0/±2] https://github.com/ngscopeclient/scopehal/compare/631c5ecedbba...48d2f41913f9
<_whitenotifier-6> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/ngscopeclient/scopehal-apps/compare/deebf309ce78...9f5914043625
<_whitenotifier-5> [scopehal-apps] azonenberg 9f59140 - Updated submodules
joshua_ has quit [Ping timeout: 268 seconds]
joshua_ has joined #scopehal
<_whitenotifier-6> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/ngscopeclient/scopehal/compare/48d2f41913f9...b1270ecbef03
<_whitenotifier-5> [scopehal] azonenberg b1270ec - Fixed digital channel bounds check to handle scopes without MSO channels
joshua_ has quit [Ping timeout: 268 seconds]
<_whitenotifier-6> [scopehal] sslupsky commented on issue #222: Streaming devices support/integration - https://github.com/ngscopeclient/scopehal/issues/222#issuecomment-2053744153
joshua_ has joined #scopehal
Stephie- has quit [Quit: Fuck this shit, I'm out!]
Stephie has joined #scopehal