ChanServ changed the topic of #sandstorm to: Welcome to #sandstorm: home of all things Sandstorm and Cap'n Proto. Say hi! | Have a question but no one is here? Try asking in the discussion group: https://groups.google.com/group/sandstorm-dev | Channel logs available at https://libera.irclog.whitequark.org/sandstorm
xet7 has joined #sandstorm
cwebber has quit [Read error: Connection reset by peer]
TMM_ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
TMM_ has joined #sandstorm
<isd> It seems like the "right" solution to the typescript errors would be to fix the mongo type declaration files.
<isd> Doesn't look like the errors are in our code.
<isd> I think pinning to 4.7 might be the best short term solution
<isd> Apparently newer versions of the mongodb package provide their own type declarations. so this is unliikely to get fixed without moving to a new version of the driver...
<ocdtrekkie> Of course
<isd> Why does typescript not follow semver.
<ocdtrekkie> Microsoft.
<isd> But yes, require('node:child_process') works on my system's node, but not the one shipped with sandstorm (but the require('child_process') does).
<ocdtrekkie> So like... do we need to pin multiple more things back to avoid breakage while we're retaining the old Mongo? I swear we must've hit some "ah, it's old enough now, breaking changes galore" with all these.
<isd> doing grep -r node:child_process I find a number of spots where there seem to be version constraints asking for node >= 16
<isd> whereas we still seem to be on 14
<isd> one of those is babel
<isd> so that's probably injecting the bogus imports
<ocdtrekkie> That'd be a screw up on their end, then, right? Because they're making incompatible changes with Node 14 on a version they're claiming works with Node 14?
<isd> Who is they?
<ocdtrekkie> babel?
<ocdtrekkie> I'm just seeing the "npm still scares me" comment on your recent doc and going "like this stuff".
<isd> hah
<isd> But I think babel is actually saying it needs node >=16. hard to tell; it's deep in some dependency of meteor.
<isd> bundle/programs/server/npm/node_modules/meteor/babel-compiler/node_modules/is-core-module/core.json
<isd> Some dependency of babel, really
<isd> That's not just a regular package.json though. Blurgh.
<ocdtrekkie> is-core-module appears to have a bunch of logic around whether modules should have node: or not based on the node version, I think? One of the top packages that depends on it... is "resolve" again.
<ocdtrekkie> "It’s true. Each installation of Babel includes a picture of Guy Fieri, and there is nothing you can do about it" comes to mind (satire), a la https://medium.com/s/silicon-satire/i-peeked-into-my-node-modules-directory-and-you-wont-believe-what-happened-next-b89f63d21558
<isd> isn't that the package that kenton keeps having to pin back again after updating for some reason?
<ocdtrekkie> yes
<isd> did he do that this time?
<ocdtrekkie> yes
<isd> ...maybe we can get away with pinning is-core-module to whatever it was using before.
<ocdtrekkie> It's also possible we could hack around the resolve issue so it can update, I'm not sure if it'll fix the child_process problem though.
<isd> I doubt it
<isd> (that it would fix the issue that is)
<ocdtrekkie> Ah. The resolve issue is apparently caused by an intentionally broken file in tests.
<ocdtrekkie> And one can delete that during the build process with no real impact.
<isd> So maybe we should just add deleting that to the build logic.
<ocdtrekkie> That would let Kenton not have to revert resolve, but you're right in that I don't know if it'd fix much else. Looks like is-core-module saw one version update in August? And then one back in April.
<isd> So it's unlikely that's the problem
<ocdtrekkie> The reference to node:child_process in is-core-module was added 13 months ago.
<isd> Hm, probably that's a red herring
<ocdtrekkie> I suspect it is.
<isd> I bet that's just the threshold above which it's supposed to use the node: prefix
<ocdtrekkie> https://github.com/inspect-js/is-core-module/commit/6d943abe81382b9bbe344384d80fbfebe1cc0526 <- only reference to node:child_process is specifically related to which Node versions it should return true for.
<isd> We're on 14.17.5
<isd> It seems like we ought to be able to update to 14.18 without any trouble, if we can work it into the build
<isd> We'd have to get it somewhere other than the meteor bundle though
cwebber has joined #sandstorm
<TimMc> That node_modules piece is amazing.
<ocdtrekkie> It's a true classic
SteveLeach has joined #sandstorm
SteveLeach has quit [Client Quit]
TMM_ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
TMM_ has joined #sandstorm
cwebber has quit [Ping timeout: 248 seconds]
<ocdtrekkie> https://frankenphp.dev o.o
xet7 has quit [Remote host closed the connection]
kentonv has quit [Ping timeout: 260 seconds]
kentonv has joined #sandstorm