12:47 <re_irc> <@gauteh:matrix.org> if i want to set serveral bits in a register, should i modify them all within the write(|w| ..) closure? Or will only the last one take effect then?

12:54 <re_irc> <@gauteh:matrix.org> w.smod1type().i2c_master();

12:54 <re_irc> <@gauteh:matrix.org> });

12:54 <re_irc> <@gauteh:matrix.org> e.g.: ``` iom.submodctrl.write(|w| {

12:54 <re_irc> <@gauteh:matrix.org> w.smod1en().set_bit()

12:58 <re_irc> <@9names:matrix.org> you usually want the .modify() function though

12:58 <re_irc> <@9names:matrix.org> inside the closure, all will take effect.

12:58 <re_irc> <@gauteh:matrix.org> Rooms

12:58 <re_irc> <@gauteh:matrix.org> yeled

12:58 <re_irc> <@gauteh:matrix.org> 

12:58 <re_irc> <@gauteh:matrix.org> People

12:58 <re_irc> ... long message truncated: https://psion.agg.io/_matrix/media/r0/download/psion.agg.io/e1b4e55cecf0f2f2845a20fc54e43c8bc5bd2dd2d6107a5abbd36d7123f9567a (191 lines)

12:59 <re_irc> <@9names:matrix.org> write will mean w starts with the reset value for the register.

12:59 <re_irc> <@9names:matrix.org> modify means it starts with the current value of the register

13:01 <re_irc> <@9names:matrix.org> the embedded book has more info on this, if you haven't seen it.

13:01 <re_irc> <@9names:matrix.org> https://docs.rust-embedded.org/book/start/registers.html#writing

13:01 <re_irc> <@gauteh:matrix.org> ok

13:02 <re_irc> <@gauteh:matrix.org> within modify or write, will setting the fields be atmoic.. i.e. the same as setting the entire register to the computed value

13:03 <re_irc> <@9names:matrix.org> the value isn't written to the register until the end of the closure

13:03 <re_irc> <@gauteh:matrix.org> Ok. Great, thanks

19:16 <re_irc> <@newam:matrix.org> adamgreig: I am not sure if notifications get sent for draft PRs. I opened an RFC here for cortex-m on-target testing: https://github.com/rust-embedded/cortex-m/pull/355

19:20 <re_irc> <@adamgreig:matrix.org> I'm afk this weekend but will have a look tomorrow evening, thanks!