<gsekulski>
Hey, I couldn’t find information about a specific style guide enforced in PyPy, so I assume the accepted conventions are those described in PEP.
<gsekulski>
Browsing PyPy there seems to be some inconsistencies in comment formatting across the codebase, such as:
<gsekulski>
Would there be interest in standardizing this? I’d be happy to propose a pull request. Since I haven't contributed to PyPy before, I wanted to check in first, following the contributor guidelines.
<gsekulski>
Actually three, not two.
<nimaje>
regarding 2. python doesn't have any multiline comments and regarding 1. it seems to me like you mistake docstrings for comments there
<gsekulski>
Multiline docstrings, sorry. In 641 it's indeed a comment, docstrings are in 676 and 706
<nimaje>
and both examples for 2. are incorrect according to pep257, as they don't contain a summary line, but what problem do you see there?
<nimaje>
ah, "Unless the entire docstring fits on a line, place the closing quotes on a line by themselves."
<gsekulski>
When browsing the source code, I found it odd that several similar functions are described in different ways. It's not that I have a problem with it, though I think it would be better if they all (correctly) follow PEP
<cfbolz>
gsekulski: fixing style for style sake is very unlikely to be accepted. we have too many active branches for this to lead to anything but confusion and merge conflicts
<cfbolz>
it's better to improve code that you are touching for functionality/bug reasons