07:45 <graingert> I'm not sure where to put tests for https://github.com/pypy/pypy/pull/5087/files I can't find tests that test the opcodes or frame directly

13:38 <cfbolz> graingert: there are no unit tests that check the frame object directly, no. I think the main test that would be good is to add one to extra_tests/test_gc.py (or a new file) that checks that things get collected correctly now that didn't before

13:41 <graingert> Ah ok

13:42 <graingert> Do you want tests for the things that did get collected correctly, eg the slow path?

13:43 <graingert> And is https://docs.python.org/3/library/test.html#test.support.gc_collect available?

13:44 <cfbolz> no, it's not. calling gc.collect in a loop is fine, however. maybe with a maximum number of calls, so that a failing test doesn't just hang