<borneoa___>
gamiee: what is printed out by echo $result ? I use the catch command when I know the command will return error, like on this case, but I often ignore the result
<borneoa___>
gamiee: the TCL command to write in memory should not output errors using LOG_ERROR(); it should return the error through the normal TCL output so catch can take it and either analyze or drop it
<borneoa___>
gamiee: but unfortunately LOG_xxx() is widely abused in current code!
renrelkha has quit [Quit: bye]
renrelkha has joined #openocd
d_olex has quit [Ping timeout: 245 seconds]
Deneb has joined #openocd
<gamiee>
borneoa___ : the $result is empty, that's the empty line between "Error" and "Info" messages.
<gamiee>
I tried to make it as best as I could, so it would be suitable for upstream, and I wouldn't like to see it rot on fork :( I plan to maintain it in future (it's definitely not "upstream & abandon"), I already working on BL602 support for it :)
<gamiee>
s/rot on/rot in/
PlasmaHH has joined #openocd
<borneoa___>
gamiee: I have added a minor comment to your patch
<borneoa___>
gamiee: for the flash driver, I only do some minor check, as I'm not familiar enough with the flash subsystem to run a full review
joconor has quit [Ping timeout: 244 seconds]
joconor has joined #openocd
joconor has quit [Ping timeout: 248 seconds]
joconor has joined #openocd
nerozero has quit [Ping timeout: 252 seconds]
Deneb has quit [Quit: Leaving]
<gamiee>
borneoa___ I sent fixed patch, sorry, I probably introduced the space when commenting the code and forgot to remove space.
<gamiee>
About the flash driver, thx for minor check. I will try to take look who does upstreaming of those and contact them about request for review.
joconor has quit [Ping timeout: 248 seconds]
joconor has joined #openocd
slobodan has quit [Read error: Connection reset by peer]