08:34 < jenkins-mlpack2> Project docker mlpack nightly build build #187: STILL UNSTABLE in 3 hr 20 min: http://ci.mlpack.org/job/docker%20mlpack%20nightly%20build/187/

13:42 < Mukesh> JOIN

15:13 < niteya> hello , I am trying to debug my PR , Travis CI is reporting an error that home/jenkins/workspace/pull-requests mlpack memory/src/mlpack/methods/range_search/rs_model_impl.hpp:66:31: error: ‘approx_equal’ is not a member of ‘arma’ , even though it compiles on my computer and i am pretty sure that approx_equal is indeed a function of armadillo .

15:13 < niteya> where is the error coming from ?

15:13 < niteya> PR #1632

15:34 < zoq> niteya: ‘approx_equal’ was introduced in armadillo 6.700, but we support/build against armadillo 6.500 (6.500 as a minimum). See https://github.com/mlpack/mlpack/pull/1369#discussion_r183142822 for a possible solution.

16:00 < Xuwei> Hello, I just want to check that is anyone working on the choco inistaller for windows issue#1589?

16:20 < rcurtin> Xuwei: sure, nobody is working on that, you should feel free

16:25 < Xuwei> Great, Do you know what's the minimum supported cmake version for mlpack? I can't find it.

16:30 < rcurtin> Xuwei: isn't it at the top of the main CMakeLists.txt?

16:32 < Xuwei> Oh I see, sorry somehow missed that

16:33 < rcurtin> :)

16:34 < niteya> zoq: Thanks a lot for the help

16:36 < Xuwei> I know it's open source, but I just want to make sure do I have the legal right to distribute package like boost, cmake, armadillo, mlpack?

16:37 < rcurtin> so long as you follow the license guidelines of those packages, yeah, shouldn't be a problem. but I think that 'following the license guidelines' means just distributing the licenses of those packages

16:37 < rcurtin> and not claiming that you wrote them ;)

16:37 < Xuwei> Ok cool, thanks for the help

16:38 < rcurtin> or at least boost/cmake/armadillo. for mlpack you can claim that since you are contributing :)

17:24 < manish7294> rcurtin:zoq: Everytime I am trying to cmake mlpack, it is throwing missing ensmallen error and is downloading it ensmallen again & again. I suppose this shouldn't be happening right? Here's the log of two consecutive cmake calls https://pastebin.com/JCr7L11v

17:43 < rcurtin> ooh, that is a bug. there's a call 'find_package(Ensmallen 1.10.0)' but that doesn't find it if we already downloaded it

17:43 < rcurtin> what happens if you configure with ENSMALLEN_INCLUDE_DIR=deps/ensmallen-1.12.2/include/?

17:44 < rcurtin> i.e. cmake -DENSMALLEN_INCLUDE_DIR="$PWD/deps/ensmallen-1.12.2/include/" ../ in an already-configured build directory?

17:47 < manish7294_> rcurtin: that works without re-download

17:48 < rcurtin> hm, ok, so we can make a patch then, that sets ENSMALLEN_INCLUDE_DIR (if it isn't already set) before the find_package() call

17:48 < manish7294_> this time we have : Found ensmallen: /home/manish/mlpack/build/deps/ensmallen-1.12.2/include (found version "0.0.0")

17:48 < rcurtin> perfect, though the version seems off

17:48 < manish7294_> hmm

17:48 < rcurtin> want me to open an issue for this?

17:48 < rcurtin> or if you want you can try and patch it, it shouldn't be too hard I think

17:48 < manish7294_> sure, let me see

17:50 < rcurtin> I guess we just have to see if there is a deps/ensmallen-x.y.z/ directory and use that as ENSMALLEN_INCLUDE_DIR if ENSMALLEN_INCLUDE_DIR isn't specified

20:26 < rcurtin> I'm trying to do my best to go through old issues that have fallen off my radar and help describe them well enough that others can handle the task

20:26 < rcurtin> hopefully it is helpful, especially for all the incoming prospective GSoC students

20:58 < travis-ci> manish7294/mlpack#95 (cmakeEnsmallen - f3c506e : Manish): The build has errored.

20:58 < travis-ci> Change view : https://github.com/manish7294/mlpack/compare/3b95e90555f4^...f3c506e212f1

20:58 < travis-ci> Build details : https://travis-ci.com/manish7294/mlpack/builds/97291504

21:02 < travis-ci> manish7294/mlpack#30 (cmakeEnsmallen - f3c506e : Manish): The build has errored.

21:02 < travis-ci> Change view : https://github.com/manish7294/mlpack/compare/3b95e90555f4^...f3c506e212f1

21:02 < travis-ci> Build details : https://travis-ci.org/manish7294/mlpack/builds/479560246

22:08 < jenkins-mlpack2> Project mlpack - git commit test build #81: FAILURE in 1 min 35 sec: http://ci.mlpack.org/job/mlpack%20-%20git%20commit%20test/81/

22:08 < jenkins-mlpack2> noreply: Merge pull request #1659 from manish7294/cmakeEnsmallen

22:52 < jenkins-mlpack2> Yippee, build fixed!

22:52 < jenkins-mlpack2> Project mlpack - git commit test build #82: FIXED in 34 min: http://ci.mlpack.org/job/mlpack%20-%20git%20commit%20test/82/

22:52 < jenkins-mlpack2> Ryan Curtin: Fix typos in ensmallen configuration.