mmind00 changed the topic of #linux-rockchip to: Rockchip development discussion | public log at https://libera.irclog.whitequark.org/linux-rockchip
stikonas has quit [Ping timeout: 252 seconds]
<macromorgan> mmind00: Okay, I posted a reply to that commit, so hopefully we'll get somewhere. I cc'd you and the driver maintainer; I'm honestly not sure what's going on I just know that this is the commit that started it all... https://lore.kernel.org/all/655177f4.050a0220.d85c9.3ba0@mx.google.com/
naoki has joined #linux-rockchip
camus has quit [Ping timeout: 240 seconds]
Helenah has quit [Ping timeout: 248 seconds]
camus has joined #linux-rockchip
Helenah has joined #linux-rockchip
vagrantc has quit [Quit: leaving]
<dsimic> macromorgan: if I got it right from your mail, you get the error messages consistently?
arnd has quit [Server closed connection]
arnd has joined #linux-rockchip
crabbedhaloablut has joined #linux-rockchip
hanetzer has quit [Ping timeout: 240 seconds]
hanetzer has joined #linux-rockchip
kevery has quit [Remote host closed the connection]
kevery has joined #linux-rockchip
<dsimic> macromorgan: nice, there's already a reply on the LKML with a possible fix
warpme has joined #linux-rockchip
ldevulder has joined #linux-rockchip
Daanct12 has joined #linux-rockchip
Daanct12 has quit [Quit: WeeChat 4.1.1]
Daanct12 has joined #linux-rockchip
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
warpme has joined #linux-rockchip
kevery1 has joined #linux-rockchip
kevery has quit [Ping timeout: 255 seconds]
kevery1 is now known as kevery
muxelplexer has joined #linux-rockchip
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
warpme has joined #linux-rockchip
mripard has joined #linux-rockchip
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
muxelplexer has quit [Quit: Lost terminal]
warpme has joined #linux-rockchip
warpme has quit [Client Quit]
warpme has joined #linux-rockchip
muxelplexer has joined #linux-rockchip
camus has quit [Read error: Connection reset by peer]
camus1 has joined #linux-rockchip
camus1 is now known as camus
dsimic has quit [Ping timeout: 252 seconds]
dsimic has joined #linux-rockchip
muxelplexer has quit [Ping timeout: 260 seconds]
muxelplexer has joined #linux-rockchip
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
warpme has joined #linux-rockchip
psydroid2 has joined #linux-rockchip
naoki has quit [Quit: naoki]
Daanct12 has quit [Quit: WeeChat 4.1.1]
hanetzer has quit [Ping timeout: 252 seconds]
<macromorgan> yes, the errors are consistent, the freezing is inconsistent
hanetzer has joined #linux-rockchip
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
muxelplexer has quit [Changing host]
muxelplexer has joined #linux-rockchip
warpme has joined #linux-rockchip
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<macromorgan> okay, the proposed patch seems to fix stuff for me
a1batross has quit [Server closed connection]
tortoise has quit [Server closed connection]
tortoise has joined #linux-rockchip
muxelplexer has quit [Quit: Lost terminal]
vagrantc has joined #linux-rockchip
kevery has quit [Ping timeout: 240 seconds]
kevery has joined #linux-rockchip
<linkmauve> montjoie, I have finally setup my ODROID-M1, running mainline; is https://github.com/montjoie/linux/tree/crypto-rk3588-03-10-2023 still your latest branch for the crypto driver?
Helenah has quit [Ping timeout: 255 seconds]
<linkmauve> montjoie, I don’t get very different results when running cryptsetup benchmark with CONFIG_CRYPTO_DEV_ROCKCHIP2=y, and despite CONFIG_CRYPTO_DEV_ROCKCHIP2_DEBUG=y I don’t see anything special in dmesg.
<linkmauve> Ah, it doesn’t appear in /proc/crypto so it’s probably not loaded or something.
warpme has joined #linux-rockchip
<linkmauve> Ah, I’m stupid, I forgot to rebuild the dtbs…
<linkmauve> Hmm no it wasn’t that.
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<diederik> linkmauve: you have CRYPTO_SM3_GENERIC enabled?
<linkmauve> It’s =m
<diederik> that's what I have too
Helenah has joined #linux-rockchip
<linkmauve> diederik, I tested this series, but that didn’t fix it.
<linkmauve> I still have nothing in /proc/crypto, and cryptsetup is still as “slow” as before.
<linkmauve> 450~600 MiB/s for both encryption and decryption of AES.
warpme has joined #linux-rockchip
<diederik> This is what I have in `/proc/crypto` and `lsmod`: https://paste.debian.net/1298065/
<linkmauve> Ok, I have none of that rk2-* in /proc/crypto.
<linkmauve> I’ll try to rebuild it as a module again.
<diederik> Then I guess you're missing some kernel module which I/Debian does have?
<linkmauve> Oh, it seems I need CONFIG_CRYPTO_DEV_ROCKCHIP=y as well!
<linkmauve> With this one enabled it does build.
<diederik> ah, I have both '1' and '2' as modules
<diederik> I/Debian has 1 config for all arm64 devices, so they're both enabled
<linkmauve> Ah, Frank Wunderlich already found this issue in the review, I should have read the whole series before blindly applying it, sorry.
<diederik> but I'd expect you shouldn't need '1' on a rk356x device, so maybe it's missing some dependencies which get 'dragged' in?
<linkmauve> diederik, yeah, since my laptop isn’t the most powerful ever I only build the configs I actually need for my boards.
<diederik> So depending on CRYPTO_DEV_ROCKCHIP seems like a workaround to get the rockchip folder included.
<linkmauve> Yay, now I see them in /proc/crypto!
<linkmauve> And cryptsetup benchmark is much… slower. :(
<linkmauve> aes-cbc 128b 64.3 MiB/s 73.4 MiB/s
<linkmauve> aes-cbc 256b 47.1 MiB/s 75.9 MiB/s
<linkmauve> aes-xts 256b 288.8 MiB/s 301.3 MiB/s
<linkmauve> aes-xts 512b 285.5 MiB/s 290.8 MiB/s
<linkmauve> While before all of these values were in the 450~600 MiB/s range.
<diederik> Yeah, when I did some tests the results were rather mixed.
<linkmauve> Oh, I get a huge lot of [ 521.006624] rk2-crypto fe380000.crypto: Fallback for xts-aes-rk2 is xts-aes-ce
<diederik> With 16 bytes there was a significant slowdown, but with 16k bytes it was much faster
<montjoie> normal, slow size are always slow with DMA
<linkmauve> Yeah.
<diederik> which command do you use?
<linkmauve> `cryptsetup benchmark`
<montjoie> it is why having 4k sector is needed for good performance
<linkmauve> It doesn’t say which size it’s using though.
Sario has quit [Quit: WeeChat 3.0]
<linkmauve> 64 KiB it seems, according to strace.
Sario has joined #linux-rockchip
<diederik> ... my Q64-A is (currently) running off an SDcard ...
<linkmauve> My ODROID-M1 too, which is why I wanted to check whether it would make sense to encrypt the NVMe or not. :D
<linkmauve> How does one benchmark the RAM btw, to have an approximative upper speed for decryption/encryption?
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
warpme has joined #linux-rockchip
kevery1 has joined #linux-rockchip
kevery has quit [Ping timeout: 260 seconds]
kevery1 is now known as kevery
Sario has quit [Quit: WeeChat 3.0]
vagrantc has quit [Quit: leaving]
Sario has joined #linux-rockchip
warpme has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
crabbedhaloablut has quit []
stikonas has joined #linux-rockchip
stikonas has quit [Ping timeout: 268 seconds]
psydroid2 has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
kevery1 has joined #linux-rockchip
kevery has quit [Ping timeout: 240 seconds]
kevery1 is now known as kevery
stikonas has joined #linux-rockchip
stikonas has quit [Read error: Connection reset by peer]
kevery has quit [Ping timeout: 260 seconds]
kevery has joined #linux-rockchip
stikonas has joined #linux-rockchip
stikonas_ has joined #linux-rockchip
stikonas has quit [Ping timeout: 240 seconds]