00:54 <Kwiboo> naoki: correct, there may be some more hidden depends, the odroid-m1 and quartz64/soquartz series lists a few more, or https://github.com/Kwiboo/u-boot-rockchip/commits/rk3568-radxa-e25-v1 have all patches that has been sent

00:58 <naoki> Kwiboo: for AHCI, is this enough? https://github.com/Kwiboo/u-boot-rockchip/commit/f0b7fb9b16ef519fb5f571e747303ed12db576cb

00:59 <Kwiboo> btw, on E25 I had some issue with system freeze when running "pci enum", until I disabled pcie3x1 and forced vcc3v3_pi6c_05 to always-on

00:59 <naoki> + add something to dts

00:59 <naoki> hmm

00:59 <Kwiboo> yes, with that compile fix and config options + sata nodes enabled it should work

01:00 <naoki> thank you so much :)

01:01 <Kwiboo> also the scsi command should be used, trying to use cmd_sata will cause a crash, that confused me a little bit when I tried to get sata working on odroid-m1

01:03 <Kwiboo> for the e25 defconfig all kconfig options should be enabled, but no sata node in device tree, so my m.2 sata drive did not work

01:06 <Kwiboo> btw, see https://github.com/Kwiboo/u-boot-rockchip/commit/547f916a1eb50688f4b9981aab69fdcf8c241d52 for a dummy ethernet phy driver that should fix phy reset issue on rock-3a

01:07 <Kwiboo> will continue working on the full ethernet driver, still having issues with TX packets not reaching network, yet RX packes can be read from the network

05:13 <naoki> sre: I noticed rockchip_cpufreq_probe() is called (and failed) on non-rk3588 board (ROCK 3A)

19:26 <sre> HDMI signal.

19:26 <sre> naoki: adding &pcie30x1m1_pins pinctrl to &pcie2x1l0 is wrong for multiple reasons. First of all it muxes functionality to a different IP. The pins must be configured as GPIO, but it does not matter because the driver does not support wake and irqreq GPIOs. So only the reset gpio needs to be configured. Last but not least it also muxes an unrelated

19:28 <sre> naoki: regarding rockchip_cpufreq_probe() - I now added a check to avoid probing on RK3588. But as I said the whole solution is a WIP hack. It's not for production use / upstream submission.

23:20 <Kwiboo> naoki: with the E25 kernel patch I sent out today and https://github.com/Kwiboo/u-boot-rockchip/compare/rk3568-radxa-e25-v1..rk3568-radxa-e25-v2 both u-boot and linux can find my sata drive on my E25 :-)

23:21 <naoki> oh great! thanks for your nice work :)

23:26 <Kwiboo> thanks, will send out a v2 u-boot patch for E25 later