ChanServ changed the topic of #linux-rockchip to: Rockchip development discussion
stikonas has quit [Remote host closed the connection]
vagrantc has quit [Quit: leaving]
tucanae47_ has joined #linux-rockchip
arnd has joined #linux-rockchip
dsimic has quit [Quit: Client closed]
_whitelogger has joined #linux-rockchip
kevery has joined #linux-rockchip
kevery has quit [Quit: kevery]
archetyp has joined #linux-rockchip
warpme__ has joined #linux-rockchip
mps has quit [Ping timeout: 245 seconds]
archetyp has quit [Quit: Leaving]
warpme__ has quit [Quit: Connection closed for inactivity]
<CounterPumpkin>
mmind00: it has been done
warpme__ has joined #linux-rockchip
archetyp has joined #linux-rockchip
<CounterPumpkin>
sigmaris: in your patch, there's a VOP_REG_SET(vop, common, update_gamma_lut, 1); unshielded by a VOP_HAS_REG(vop, common, update_gamma_lut) if branch; what does VOP_REG_SET do in this case if there is no update_gamma_lut reg?
<sigmaris>
CounterPumpkin: if there's no reg->mask defined it's effectively a no-op in vop_reg_set
<CounterPumpkin>
Ah, good.
<CounterPumpkin>
vop_crtc_gamma_set seems like a good candidate for splitting into separate functions for rk3288 and rk3399, because they don't seem to share much code. Though, it's not like the function is unwieldy or anything, so just a nag at best.
mps has joined #linux-rockchip
wwilly has joined #linux-rockchip
warpme__ has quit [Quit: Connection closed for inactivity]
vagrantc has joined #linux-rockchip
lurchi_ has joined #linux-rockchip
crabbedhaloablut has quit [Remote host closed the connection]
crabbedhaloablut has joined #linux-rockchip
lurchi_ is now known as lurchi__
crabbedhaloablut has quit [Remote host closed the connection]