<headius>
enebo: small bug in ruby2_keywords prevents celluloid from loading... my proposed fix is small but we should chat about whether it's the right way
subbu has quit [Ping timeout: 272 seconds]
<kares[m]>
<enebo[m]> "kares: Commit of interest: https..." <- thanks - will look into that. that test specifically assumed what is fuzzy territory - relying on to_java to return the RubyThread internals (by default) ... I would not fear "breaking" that in 9.4 esp. since there's still a way to get the internals by being explicit ...
<enebo[m]>
I guess I do remember we realized they use markdown but I completed your name then highlighted the whole line and got a context menu which specified I could do 'code block'
<enebo[m]>
dfjklsklfjdlkdfjs
<enebo[m]>
ctrl-e is code block
<headius>
aha so it still does completion in that mode
<headius>
enebo:
<headius>
hmm might be something different on mac
<enebo[m]>
weirdly
<enebo[m]>
So C-e will make a gray box for me as 'code'
<enebo[m]>
how do you make the other color box
<enebo[m]>
dsfhjkdfjskdfhsjk
<enebo[m]>
dsfkljdskl
<enebo[m]>
> foo
<enebo[m]>
> hahaha wow
<enebo[m]>
> this is pretty odd
<enebo[m]>
> headius: does this work?
<enebo[m]>
lol
<headius>
not sure what mac shortcut is for that
<headius>
asdf
<headius>
supposed to be cmd+E but doesn't work
<enebo[m]>
for me dsklfjdfjkl
<enebo[m]>
ctrl-e will work if you highlight first
<headius>
asdf
<enebo[m]>
kdlfjdskl
<headius>
oh yeah
<headius>
so I can do [enebo](https://matrix.to/#/@enebo:matrix.org) and then ctrl+e
<headius>
there it is
<headius>
funny glitch
<enebo[m]>
ok so summary '> something' is just vertical bar. `something` is code. '<tab>something' is gray box
<enebo[m]>
My only remaining question is how to do a literal tab in this client
<enebo[m]>
the code is using `
<enebo[m]>
but on both sides of the text
<headius>
yeah tab just flashes the text field for me
<headius>
and then two tabs goes to the emoji button
<enebo[m]>
dfjklsklf
<enebo[m]>
I get the flash but it does not work
<enebo[m]>
> `headius: `
<enebo[m]>
I was hoping to get the trifecta
<headius>
ha
subbu has quit [Ping timeout: 252 seconds]
adam12 has quit [Quit: Ping timeout (120 seconds)]
adam12 has joined #jruby
<nilsding>
just wait until you figure out how to use colours :D
<enebo[m]>
Jyrki: I hope that did not take you 2 minutes to write 🎉
subbu has joined #jruby
<nilsding>
thankfully not
<enebo[m]>
haha
* nilsding
knows about element's /rainbow shortcut 😇
<enebo[m]>
the more you know 🎉
<headius>
wat
<enebo[m]>
HAHA those both are perfect
<enebo[m]>
@headius:matrix.org
<enebo[m]>
I wonder if that pinged you
<headius>
aww, none of the old mirc commands
<headius>
I was looking at it so i don't know if it pinged
* headius
slaps enebo around with a large trout
<enebo[m]>
`def foo
<enebo[m]>
"foo"
<enebo[m]>
end`
<enebo[m]>
ok code did not keep newlines
<enebo[m]>
or actually be code at all
<nilsding>
you can use the usual markdown code-fences here, even with syntax highlighting and all
<enebo[m]>
emote seems to be pervasive in all slash command systems...even server management
<nilsding>
def foo = "foo"
<enebo[m]>
def foo = "bar"
<enebo[m]>
yeah and the facebook shift-return
<enebo[m]>
which I suppose happened way before facebook
<headius>
def foo
<headius>
end
<headius>
a = 1
<headius>
ahh it recognizes ```ruby now
<enebo[m]>
I wonder how they highlight ruby since they got endless methods
<headius>
noice
<enebo[m]>
I am not surprised since they have existed for years
<enebo[m]>
but still wonder what is doing it
<headius>
it didn't work when I tried it last, probably a year ago
<nilsding>
i don't think a code highlighter needs to do anything special to support endless methods... at least the one from Kate didn't need any change for that
<nilsding>
it still wants to indent after one though, need to somehow teach it to not do this
<headius>
this pulls in some code from master for handling n == 0 (with n << m or n >> m) but we'll see if that affects tests
<headius>
more duplication than I'd like but it's fine
<enebo[m]>
ok
adam12 has joined #jruby
<headius>
enebo: I see no code in MRI to ignore invalid Etc.sysconf values and it does indeed raise when I give it a totally bogus request
<headius>
We are pretty much just propagating the sysconf errno here
<headius>
the CI failure seems like legit invalid sysconf values but I am confused why MRI running rubyspecs does not fail it
<enebo[m]>
headius: looks like errno == 0 on 9.3
<headius>
ok so that explains that one
<lavamind[m]>
I've seen Etc.sysconf return values differ whether the test is running in a chroot, container, VM, so its not only OS-specific but seems affected by the platform too
<enebo[m]>
which I guess you figured out from looking at code but I guess this confirms it
<headius>
yeah thanks
<enebo[m]>
why does intellij make it hard to select commit
<enebo[m]>
I fixed this in 10/31
<headius>
lavamind: yeah I dunno if that could also make some values invalid
<headius>
the errors on CI and apparently on those Debian builds seem like legit EINVAL
<enebo[m]>
357e078
<enebo[m]>
So this has two fixes in it
<headius>
yeah never applied to 9.3?
<headius>
I wonder if the posix.errno(0) is the missing bit for 9.3
<enebo[m]>
nope. It was just me seeing this error on 9.4 CI and not realizing we needed it on 9.3
<headius>
could it be picking up old errno
<enebo[m]>
probably since in last 2 months we have not did much on 9.3
<headius>
I will try a PR for 9.3 that does both
<headius>
I have it partially done already
<enebo[m]>
Just cp this commit
<headius>
I'll just cp your commit
<enebo[m]>
it has both things in it
<enebo[m]>
but is ret == -1 it is surprising to see sysconf not set errno
<enebo[m]>
but it required that set to make something work
<lavamind[m]>
9.3 also has a pending security fix I think
<lavamind[m]>
would be nice to be able to push that into Debian
<headius>
yeah 9.3.9.1 milestone is still open
<lavamind[m]>
I'm getting close to fixing CI for Debian, only armel and armhf still have errors
<headius>
enebo: 9.3.9.1 or 9.3.10 next week perhaps while I finish refinement fixes
<enebo[m]>
yeah 9.3.9.1 for sure
<enebo[m]>
9.4.1.0 I think we need to fix a few more reported issues
<headius>
enebo: the synchronized thing happens at lookup time... it adds in a later that wraps all methods with the wrapper
<headius>
ah same thing
<headius>
so maybe what we need to do is move this method up into DynamicMethod and some just won't do anything?
<headius>
the delegating wrappers will just delegate
<enebo[m]>
I think maybe it is ok to getRealMethod
<headius>
I'm ok with that too as long as there's no wrapper that should have this set directly
<headius>
I don't think there is
<enebo[m]>
I am trying to nail this down in seeing how MRI behaves but it woudl be weird if an alias could behave like ruby2_keywords but the original didn't
<enebo[m]>
It would be nice if both types did have it though
<enebo[m]>
This should just be encapsulated in the method type
<headius>
the wrappers could implement it but they'd need all contained methods to implement it
<enebo[m]>
At the time I remember thinking non-native methods would all implement this so I think what I missed was that we have alias (and I guess sync)
<enebo[m]>
but those are wrappers around the real thing
<headius>
yeah
<enebo[m]>
alias and sync can get the method they delegate through so I think they just delegate.setRuby2KJeywords
<enebo[m]>
The actual guard is in ruby2_keywords just against isNative
<enebo[m]>
public boolean isNative() {
<enebo[m]>
}
<enebo[m]>
return entry.method.isNative();
<enebo[m]>
So this is aliasmethod
<headius>
yeah
<headius>
I think it could move up
<enebo[m]>
I believe if we just roll with how this is written now synchronizedmethod needs isNative. We could push this down to NativeMethod as well I guess and perhaps raise or something
<enebo[m]>
I think either way setRuby2Keywords is impld on both alias and sync
<enebo[m]>
which just calls same method on its delegate
<enebo[m]>
but we could mark it as abstract on dynamicMethod and remove the case
<headius>
yeah it just can't appear there unless they implement IRMethodArgs which pulls in other stuff (that might also be valid)
<enebo[m]>
cast
<enebo[m]>
or making a raising impl but I would rather audit uses
<headius>
is this an IR thing or a general method thing
<enebo[m]>
general method feature
<headius>
then I think it should move up to DynamicMethod and be unimplemented where appropriate
<enebo[m]>
IR will implement the behavior on passing and not unmarking keywords status to args passed into a rest arg
<enebo[m]>
but the notion of this is ruby semantic and not really IR
<headius>
arguably all methods should implement args interface too but that's a larger discussion and we use that interface to switch logic sometimes
<enebo[m]>
you make a good point the cast makes it look like this is purely IR
<headius>
right
<enebo[m]>
yeah we have the issue that we migrate to newer things over time and this is a newer thing
<enebo[m]>
So I believe we have to make a concrete setRuby2Keywords now too
<enebo[m]>
and probably a no-op
<enebo[m]>
If anyone has made their own DynamicMethod anywhere it will stop working if abstract
<enebo[m]>
That is unlikely but not impossible
<headius>
ok, do you want to fix sequel or this 😀
<headius>
it won't be abstract, it just won't do anything in base impl
<enebo[m]>
I can fix this
<enebo[m]>
I have a pretty good idea on what is needed
<headius>
ok
<headius>
sequel is the only thing red on master
<enebo[m]>
sequel though I will help with when I finish if you get stuck
<headius>
those other ones are intermittent
<headius>
lavamind: that one seems to be intermittent, maybe you have seen that
<enebo[m]>
it appears to be connecting to what I am guessing is sqlite3 and getting lots o options
<headius>
yeah I have to relearn where things are in sequel every time this comes up
<enebo[m]>
which could also be something with sqlite3 gem on our side
<enebo[m]>
sequel is testing against activemodel 7.x
<enebo[m]>
and we are not 100% against it in unit tests
<headius>
ah true, is that a recent change?
<enebo[m]>
although this test may not be using activemodel
<enebo[m]>
I don't know. Until an hour ago I assumed this was a recent regression on 9.4