razetime has joined #jruby
genpaku has quit [Remote host closed the connection]
yosafbridge` has joined #jruby
genpaku has joined #jruby
yosafbridge has quit [*.net *.split]
<kares[m]> enebo: fyi: you also removed the jdbc gems e.g. jdbc-derby these could be used (and easily updated) outside AR-JDBC as well
<kares[m]> e.g. Sequel might have support for some of these - not sure how much the exotic ones such as Derby/Firebird are usable (probably not) but the driver loading conventions are supported.
<kares[m]> I am fine with having them removed, just smt you should be aware of ... if someone bumps around looking for these.
jimtng[m] has joined #jruby
razetime has quit [Remote host closed the connection]
<enebo[m]> jimtng: no. can you file an issue? This one is amazing there is no coverage for it.
<enebo[m]> kares: sorry I spaced out your message. I think that could happen but I also think it would be incredible if we could somehow reverse dependencies so all adapters to not rely on the basic gem. Then all of these could just be separate and not largely lock-stepped
<enebo[m]> kares: but I definitely agree if someone is using them (which I am doubting personally) we can either make it separate or add it back in)
<jimtng[m]> <enebo[m]> "jimtng: no. can you file an..." <- Thanks for the confirmation!
<enebo[m]> jimtng: thanks for finding it! :)
<jimtng[m]> I'm surprised nobody found it. It happens when I set rubocop to targetrubyversion 3.1 which rewrites my code to that syntax.
<enebo[m]> yeah I find it surprising neither MRI nor ruby/spec even tests that as a feature
<enebo[m]> Although looking at the report I think the feature is largely just failing after some non-forwarding syntax so it probably does have coverage but is missing these combos
<jimtng[m]> It only breaks with a splat. It is fine with kwargs or normal args
<enebo[m]> yeah
<enebo[m]> It will either be a parser mismatch where something is missing or our conditional which decides to throw the error is just doing something weird
<enebo[m]> I am trying to hit all incoming issues but we consider syntax errors extra bad so this is what I will look at in the morning
<jimtng[m]> Thanks!