michaelni changed the topic of #ffmpeg-devel to: Welcome to the FFmpeg development channel | Questions about using FFmpeg or developing with libav* libs should be asked in #ffmpeg | This channel is publicly logged | FFmpeg 7.1 has been released! | Please read ffmpeg.org/developer.html#Code-of-conduct
MetaNova has joined #ffmpeg-devel
cone-029 has quit [Quit: transmission timeout]
<Lynne>
jamrial: enabling frame threading causes the avcodeccontext to become pretty empty across all threads, not just across is_copy
<Lynne>
are non-master threads supposed to set their copy of the context somehow?
<jamrial>
Lynne: i was wrong, i was thinkgin about decoders when you asked the other day
<Lynne>
ah, I had to forward sw_pix_fmt via avcodeccopy
<Lynne>
that, plus if !is_copy return; makes init pass
<Lynne>
but the first thread gets an uninitialized context, is there a way to access the master context and copy everything I need?
Kei_N_ has joined #ffmpeg-devel
<Lynne>
the only way I see is to add a function to frame_thread_encoder to return the parent_avctx
Kei_N has quit [Ping timeout: 252 seconds]
<Lynne>
I don't get it, is_copy seems inverted, since only is_copy == 1 makes init pass?
<jamrial>
i think is_copy is decoding only
<Lynne>
yeah, I managed to make it work but init gets called for each thread
<Lynne>
is_copy is indeed decode-only
thilo has quit [Ping timeout: 265 seconds]
thilo has joined #ffmpeg-devel
iive has quit [Quit: They came for me...]
Lypheo has quit [Quit: Ping timeout (120 seconds)]
<JEEB>
BBB: they did good PR by getting the name and usage of x264's code (not sure how much they utilized in the end)
Krowl has joined #ffmpeg-devel
wyatt8740 has quit [Ping timeout: 252 seconds]
wyatt8740 has joined #ffmpeg-devel
ngaullier has joined #ffmpeg-devel
ngaullie has quit [Ping timeout: 264 seconds]
<BBB>
JEEB: yes, agreed. but I think that ignores the fact that they did write an actual encoder that does things like, y'know, encoding a video somewhat competently
<BBB>
there were various hevc encoders at that stage, kvazaar, 3 variants of x265 from what I recall, a few more
<BBB>
this is the only one that saw any serious use and they managed that part well
<JEEB>
sure
IndecisiveTurtle has quit [Remote host closed the connection]
IndecisiveTurtle has joined #ffmpeg-devel
IndecisiveTurtle has quit [Ping timeout: 265 seconds]
IndecisiveTurtle has joined #ffmpeg-devel
<BtbN>
Is it really globel state, or just static global data it initializes once?
Traneptora has joined #ffmpeg-devel
<galad>
from https://bitbucket.org/multicoreware/x265_git/src/master/doc/reST/api.rst : "There is one caveat to having multiple encoders within a single process. All of the encoders must use the same maximum CTU size because many global variables are configured based on this size. Encoder allocation will fail if a mis-matched CTU size is attempted. If no encoders are open, x265_cleanup() can be called to reset the configured CTU size so a new size can be used."
<BtbN>
That's horrible design
<galad>
yup, and it would take 15 minutes to fix it probably
<jamrial>
kasper93: will look, thanks
IndecisiveTurtle has quit [Ping timeout: 272 seconds]
IndecisiveTurtle has joined #ffmpeg-devel
ccawley2011_ has joined #ffmpeg-devel
ccawley2011__ has joined #ffmpeg-devel
ccawley2011__ has quit [Remote host closed the connection]
ccawley2011 has quit [Ping timeout: 260 seconds]
ccawley2011 has joined #ffmpeg-devel
ccawley2011_ has quit [Ping timeout: 255 seconds]
ccawley2011_ has joined #ffmpeg-devel
haihao has quit [Ping timeout: 265 seconds]
ccawley2011__ has joined #ffmpeg-devel
ccawley2011 has quit [Ping timeout: 255 seconds]
haihao has joined #ffmpeg-devel
ccawley2011 has joined #ffmpeg-devel
ccawley2011_ has quit [Ping timeout: 260 seconds]
ccawley2011_ has joined #ffmpeg-devel
ccawley2011__ has quit [Ping timeout: 255 seconds]
haihao has quit [Ping timeout: 260 seconds]
cone-616 has joined #ffmpeg-devel
<cone-616>
ffmpeg James Almer master:e7bdaadce6e6: avformat/mov: check that items are allocated before accessing them
<jamrial>
kasper93: should be fixed
odrling has quit [Remote host closed the connection]
odrling has joined #ffmpeg-devel
ccawley2011 has quit [Ping timeout: 245 seconds]
haihao_ has joined #ffmpeg-devel
Krowl has quit [Read error: Connection reset by peer]
rom1v has quit [Quit: ZNC 1.8.2+deb2+b1 - https://znc.in]
rom1v has joined #ffmpeg-devel
courmisch has quit [Ping timeout: 264 seconds]
jess has quit [Remote host closed the connection]
courmisch has joined #ffmpeg-devel
jess has joined #ffmpeg-devel
<elenril>
this just in: another| did not read dune
IndecisiveTurtle has quit [Ping timeout: 265 seconds]
<another|>
elenril: that is correct
Everything has joined #ffmpeg-devel
<elenril>
consider fixing that
<compn>
the spice must flow
<BBB>
spice is life
<BBB>
kyle's suggestion is a good one, by the way. I worry that we'll take the advise as political - if it's not what we wanted, we'll just disagree[tm]
<BBB>
as in, entering with an open mindset is critical if we want it to be helpful