dustymabe changed the topic of #fedora-coreos to: Fedora CoreOS :: Find out more at https://getfedora.org/coreos/ :: Logs at https://libera.irclog.whitequark.org/fedora-coreos
ravanelli has quit [Remote host closed the connection]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 255 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 276 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 246 seconds]
arnulfo_7 has joined #fedora-coreos
arnulfo_7 has joined #fedora-coreos
arnulfo_7 has quit [Changing host]
daMaestro has quit [Quit: Leaving]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 246 seconds]
cmagina has quit [Ping timeout: 240 seconds]
sgallagh has quit [Ping timeout: 240 seconds]
arnulfo_7 has quit [Ping timeout: 255 seconds]
cmagina has joined #fedora-coreos
sgallagh has joined #fedora-coreos
<bgilbert> Eighth_Doctor: oh nice!
<bgilbert> dustymabe: good catch on https://github.com/coreos/fedora-coreos-streams/issues/504#issuecomment-1134868250. we missed that when prepping for the nutanix format change
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 276 seconds]
arnulfo_7 has joined #fedora-coreos
paragan has joined #fedora-coreos
paragan has quit [Ping timeout: 255 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 256 seconds]
jpn has joined #fedora-coreos
llamma has quit [Ping timeout: 244 seconds]
jpn has quit [Ping timeout: 256 seconds]
arnulfo_7 has quit [Ping timeout: 276 seconds]
gursewak_ has joined #fedora-coreos
gursewak has quit [Ping timeout: 260 seconds]
bgilbert has quit [Ping timeout: 240 seconds]
Betal has quit [Quit: WeeChat 3.5]
jpn has joined #fedora-coreos
paragan has joined #fedora-coreos
jpn has quit [Ping timeout: 255 seconds]
gursewak_ has quit [Ping timeout: 240 seconds]
gursewak_ has joined #fedora-coreos
gursewak_ has quit [Ping timeout: 255 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 246 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 255 seconds]
jcajka has joined #fedora-coreos
<cverna> dustymabe: I cherry-picked the f36 commit but it looks like the kdump test is still failing on stable.
ksinny has joined #fedora-coreos
<travier[m]> cverna: that's unexpected indeed
<travier[m]> cverna: is it reproduce-able locally?
jpn has joined #fedora-coreos
<cverna> I did not try to reproduce is locally, will give it a try a in bit :)
guesswhat has joined #fedora-coreos
guesswhat has quit [Quit: Client closed]
guesswhat has joined #fedora-coreos
<cverna> Ok so I was able to reproduce the failure locally
<cverna> Although if I run the test on it own it works :S
<cverna> Local failure when running the whole kola test suite --> https://paste.centos.org/view/raw/8224af4e
<cverna> Just running ext.config.kdump.crash did not fail --> https://paste.centos.org/view/raw/8acc3c48
<travier[m]> :/
guesswhat has quit [Quit: Client closed]
guesswhat has joined #fedora-coreos
plarsen has joined #fedora-coreos
plarsen has quit [Client Quit]
plarsen has joined #fedora-coreos
plarsen has quit [Remote host closed the connection]
plarsen has joined #fedora-coreos
llamma has joined #fedora-coreos
arnulfo_7 has joined #fedora-coreos
arnulfo_7 has quit [Changing host]
arnulfo_7 has joined #fedora-coreos
nalind has joined #fedora-coreos
jlebon has joined #fedora-coreos
crobinso has joined #fedora-coreos
<dustymabe> cverna: hmm
<dustymabe> let me look at the logs.. we might be hitting https://github.com/coreos/fedora-coreos-tracker/issues/1195 (it's a race condition)
ravanelli has joined #fedora-coreos
ravanelli has quit [Remote host closed the connection]
ravanelli has joined #fedora-coreos
<dustymabe> cverna: for that `testing` run failure - you have to re-run it with Force checked
plarsen has quit [Quit: NullPointerException!]
paragan has quit [Ping timeout: 255 seconds]
mheon has joined #fedora-coreos
paragan has joined #fedora-coreos
plarsen has joined #fedora-coreos
saqali has joined #fedora-coreos
mnguyen_ has joined #fedora-coreos
mnguyen has quit [Ping timeout: 255 seconds]
guesswhat has quit [Quit: Client closed]
<cverna> 👍️
<cverna> dustymabe: for the stable issue (race condition) should we disable that test for now ? or something else ?
cyberpear has joined #fedora-coreos
<cverna> oh ignore my last question, just saw that you pushed a commit
mnguyen has joined #fedora-coreos
mnguyen_ has quit [Ping timeout: 260 seconds]
bgilbert has joined #fedora-coreos
gursewak_ has joined #fedora-coreos
jcajka has quit [Quit: Leaving]
josereyesjdi has joined #fedora-coreos
arnulfo_7 has quit [Ping timeout: 255 seconds]
josereyesjdi has quit [Ping timeout: 258 seconds]
josereyesjdi has joined #fedora-coreos
paragan has quit [Quit: Leaving]
cmagina has quit [Changing host]
cmagina has joined #fedora-coreos
josereyesjdi has quit [Remote host closed the connection]
josereyesjdi has joined #fedora-coreos
ravanelli has quit [Remote host closed the connection]
MHamzahKhan[m] has joined #fedora-coreos
bgilbert has quit [Read error: Connection reset by peer]
bgilbert has joined #fedora-coreos
jpn has quit [Ping timeout: 244 seconds]
mgrundmann has quit [Ping timeout: 244 seconds]
mgrundmann has joined #fedora-coreos
josereyesjdi has quit [Ping timeout: 258 seconds]
ksinny has quit [Remote host closed the connection]
<dustymabe> saqali: before you run the release jobs let me check something
nbsadminaccount- has joined #fedora-coreos
gursewak_ is now known as gursewak
<jlebon> dustymabe: yeah, one sec
<jlebon> the function name in that comment needs to be updated
<dustymabe> jlebon: so other classes don't really override `mutate_image()` as the comment for the function states.. rather they provide a mutate_callback function?
<jlebon> dustymabe: yeah, exactly
<jlebon> tbh, I think we should de-OOP this code and make it more functional instead
<jlebon> it's super hard to follow
<dustymabe> i was mostly confused because the comment was misleading
<jlebon> but unless it's done right, we'd end up with an even bigger mess of partially OOP and partially not code
<dustymabe> i'm trying to find an example where one of the mutate_callback functions uses the image.json data
<jlebon> yeah, it might just be ova
<dustymabe> i'm still kind of in the boat that we should just do https://github.com/coreos/coreos-assembler/pull/2839#discussion_r880776011
<dustymabe> jlebon: WDYT?
josereyesjdi has joined #fedora-coreos
<dustymabe> saqali: just use this COSA image when you run the stable release job: https://github.com/coreos/fedora-coreos-streams/issues/504#issuecomment-1134868250
<jlebon> since importing is heavy, i could imagine wanting code to be aware of this, but yeah it could make sense too
<jlebon> bbiab
<dustymabe> IIUC importing is only heavy once during a run.. later requests for import should be lightweight, no?
josereyesjdi has quit [Ping timeout: 258 seconds]
<jlebon> yup, that's correct.
<dustymabe> which means embedding it in extract_image_json should be OK
<bgilbert> dustymabe: don't we normally close tracker bugs that are only waiting on an FCOS release? https://github.com/coreos/fedora-coreos-tracker/issues/1159
<dustymabe> bgilbert: we don't have any set policy that I know of other than i certainly close it if it makes it if the fix makes it to `stable`.
<bgilbert> ok cool
<jlebon> dustymabe: i don't disagree, but that first operation will still be costly, and reading image.json on the surface isn't an operation that seems like it should be costly
<jlebon> in some cases also, you might want it to fail earlier if the ostree content is missing so you don't do unnecessary work
<dustymabe> jlebon: i'm not sure I understand your argument. It seems as if you think my suggestion will cause unnecessary `import_ostree_commit()` to happen? Do you think that is the case?
<dustymabe> oh, I see
<jlebon> dustymabe: i'm saying your suggestion should work, but isn't necessarily objectively better
<dustymabe> what I am trying to avoid is importing the ostree_commit just for the image.json if you don't need to
<dustymabe> right now anytime you `mutate_image()` it will get called - whereas it's only really needed for ova.py
<jlebon> right, i follow. i think you have a point.
<jlebon> i think in practice though it won't really matter for FCOS and RHCOS pipelines today since all these builds are done in the same job
<jlebon> but they may not be in the future
bagasse has quit [Ping timeout: 255 seconds]
<jlebon> (i.e. it'll be a no-op anyway since it's the same workdir where the ostree was composed)
<dustymabe> I think we are both using the same argument (the no-op) as being a good reason to leave it the way it is AND to change it to the other way
<dustymabe> in practice the `no-op`/lightweight nature of it makes it so it doesn't really matter when we `import_ostree_commit()`
<dustymabe> so for that reason i suggest to keep the code cleaner by just putting it alongside the function that needs it (the extract_image_json())
<dustymabe> either way works
<dustymabe> let's see what colin thinks
<jlebon> +1
<dustymabe> on another note.. i think we are getting closer to adding support for s390x (thanks to some work by lakshmi)
<jlebon> oh sweet!
ravanelli has joined #fedora-coreos
guesswhat has joined #fedora-coreos
<dustymabe> saqali: looks like all the release jobs finished
ravanelli has quit [Remote host closed the connection]
ravanelli has joined #fedora-coreos
nemric has joined #fedora-coreos
ravanelli has quit [Remote host closed the connection]
nalind has quit [Quit: bye]
josereyesjdi has joined #fedora-coreos
guesswhat has quit [Quit: Client closed]
mheon has quit [Ping timeout: 260 seconds]
jpn has joined #fedora-coreos
jpn has quit [Ping timeout: 244 seconds]
crobinso has quit [Remote host closed the connection]
josereyesjdi has quit [Ping timeout: 258 seconds]
heldwin has quit [Remote host closed the connection]
heldwin has joined #fedora-coreos