01:19 <FromGitter> <wwalker> Hey I had that written down to report!

21:55 <SamantazFox> Hi! I'm coming with yet another weird question: why does my subclass don't have the property defined in its parent? https://play.crystal-lang.org/#/r/ehpj

21:59 <SamantazFox> It looks like it's because of the `finalized` macro, but without it, my various initialize functions aren't recognized (I get: "there is no previous definition of 'initialize'") https://bpa.st/SFSFM

22:00 <FromGitter> <Blacksmoke16> if i had to guess you are correct

22:00 <FromGitter> <Blacksmoke16> property is never actually added

22:02 <FromGitter> <Blacksmoke16> what is your expectation here?

22:02 <FromGitter> <Blacksmoke16> imo feels like a major code smell to call `previous_def` in an initialize method

22:04 <SamantazFox> How can I write it in a way where all my variables are properly initialized, and I don't have to rewrite 20 times the same code?

22:05 <FromGitter> <Blacksmoke16> hmm

22:07 <SamantazFox> My other idea was to declare a function for each trait, and do a bunch of `if self.responds_to?` in the initialize method, but iirc I encountered some nasty problems, and imho that looks terrible :/

22:12 <FromGitter> <Blacksmoke16> hmm

22:17 <FromGitter> <Blacksmoke16> ```code paste, see link``` [https://gitter.im/crystal-lang/crystal?at=63d993660c94855213da4194]

22:17 <FromGitter> <Blacksmoke16> better visual on the hierarchy

22:18 <FromGitter> <Blacksmoke16> i feel like some sort of builder type would make the most sense here

22:20 <FromGitter> <Blacksmoke16> like that accepts the `format` JSON, consumes it all, storing all the data internally as if it was an instance of every module, then a final `#build` method that returns the proper instance, using its internal state as arguments to that type's constructor

22:23 <FromGitter> <Blacksmoke16> you have some example input for this thing?

22:24 <SamantazFox> What did you do to get that hierarchy? You used the crystal compiler tools?

22:25 <SamantazFox> (making a list of inputs, hold on)

22:25 <FromGitter> <Blacksmoke16> `crystal tool hierarchy test.cr`

22:25 <FromGitter> <Blacksmoke16> but replaced all the modules with a bool property named after the module just as added visual

22:28 <SamantazFox> ah hmmm, ok!

22:28 <SamantazFox> Here is the list: https://bpa.st/KG7PK

22:29 <SamantazFox> each JSON object starting with "itag" is one of the possible inputs of `parse_adaptative_formats`

22:31 <SamantazFox> (there are another handful of variants that I haven't included)

22:37 <FromGitter> <Blacksmoke16> okay, instead of the builder i think this is a case where id just accept some duplicate code and dont bother with the modules and stuff. doesnt seem to be a great solution

22:38 <FromGitter> <Blacksmoke16> other catch is there is no indirect initialization

22:39 <FromGitter> <Blacksmoke16> sec, let me get an example together

22:40 <SamantazFox> thing is I don't want to have like 7 or more times the same code with minor variations. This is going to be a nightmare to maintain...

22:50 <mps> Blacksmoke16: last night my son looked at athena (he works in this field) and he told me that it is really good framework, something about he thought to make

22:52 <FromGitter> <Blacksmoke16> @SamantazFox let me play with this more and ill ping you later

22:53 <SamantazFox> Ok, sure!

22:54 <SamantazFox> I might not respond, thoug, as it's already quite late in here, but I always have my client open

22:55 <FromGitter> <Blacksmoke16> @mps glad to hear! still plenty more that can be added/improved, but its getting there 💪

22:57 <mps> I skimmed over athena about two years ago (iirc) but as I don't work in this field I didn't understood much, but he explained to me how it is good for something he had in his had

22:58 <mps> but I remember your deep knowledge and understanding of things following this channel

23:04 <FromGitter> <Blacksmoke16> deff has evolved a lot in last 2 years

23:04 <FromGitter> <Blacksmoke16> some of the patterns and such aren't really common to Ruby world either, so it does require some understanding of the *why* it does things the way it does

23:08 <mps> I don't understand and it doesn't matter because I don't have plan to work with, just wanted to tell that my son appreciate your work

23:09 <FromGitter> <Blacksmoke16> thanks man, i appreciate it 😊

23:09 <mps> thank you for such good work

23:46 <FromGitter> <Blacksmoke16> @SamantazFox is that valid JSON?

23:47 <FromGitter> <Blacksmoke16> nvm

23:50 <FromGitter> <Blacksmoke16> @SamantazFox this is what i came up with: https://play.crystal-lang.org/#/r/ehqn ⏎ ⏎ Basically makes each module define a macro to parse the data, manually defines the constructors, and call the helper macro. overall a lot simpler and still keep your helper modules

23:50 <FromGitter> <Blacksmoke16> might have to play with the parsing macros to make it actually work but should be a good start