06:46 <mpbridge> <mojca> I'm struggling to figure out the proper syntax to upload files to a different location depending on the branch being built. Here's my naive attempt:

06:46 <mpbridge> <mojca> https://paste.macports.org/92eab2a4a925

06:47 <mpbridge> <mojca> That sadly says `builtins.NameError: name 'step' is not defined`

06:55 <cmouse> mpbridge: you need to import step

06:56 <cmouse> ohhh

06:56 <cmouse> you need to use @builbot.util.renderer on the function

07:01 <mojca> cmouse: sorry, it's mojca talking over a bridge (I have some struggles with IRC alone), rather than the bridge talking ;)

07:02 <mojca> I tried `@util.renderer`, but the error comes from where I call the function

07:03 <mojca> The error is thrown by `masterdest = os.path.join(config['downloadPath'], get_branch_name_on_server(step), fileDest)`

07:04 <mojca> Or does the whole factory need the renderer?

07:04 <cmouse> mhm.

07:08 <mojca> Was that a "yes"? If I add it on the whole factory creation function, I cannot get it to work either https://paste.macports.org/6f0bed4d6cc3

07:08 <cmouse> it was "i am not sure"

07:09 <cmouse> i think you need to create a custom step, which does that masterdest stuff

07:09 <cmouse> now the os.path.join is called too early.

07:09 <cmouse> or you can try masterdest = get_master_dest(step) and mark that renderer

07:09 <cmouse> then move the os.path.join there

07:10 <mojca> I'll try your suggestion now. I just wanted to say that the following works just fine, and I don't quite understand what the big difference is:

07:10 <mojca> https://paste.macports.org/4056b960a50c

07:20 <mojca> I tried the following, but no success: https://paste.macports.org/d476053952fc

07:25 <mojca> Just in case it's relevant, this is the full setup: https://github.com/TeXLive-M/texlive-buildbot/blob/master/master.cfg#L282-L289

10:08 <cmouse> maybe try step=>self

14:43 <skelly> or step => steps?

14:45 <skelly> mojca: oh I see, don't call get_texlive_masterdest, Buildbot will do that when renderering

14:46 <skelly> if you need to pass in an argument, you will have to use a nested function that returns the renderer

14:46 <skelly> even better, you can use withArgs

14:47 <skelly> mojca: see https://docs.buildbot.net/current/manual/configuration/properties.html#renderer and search for the withArgs example, that appears to match what you want to do