ChanServ changed the topic of #armlinux to: ARM kernel talk [Upstream kernel, find your vendor forums for questions about their kernels] | https://libera.irclog.whitequark.org/armlinux
apritzel has quit [Ping timeout: 240 seconds]
Tokamak has quit [Read error: Connection reset by peer]
Tokamak has joined #armlinux
Tokamak has quit [Ping timeout: 256 seconds]
Tokamak has joined #armlinux
Tokamak has quit [Ping timeout: 250 seconds]
<hanetzer>
huh. that's interesting. learned something I didn't know about the kbuild system today. for every CONFIG_$FOO enabled, there appears to be a file include/config/$FOO
<steev>
i would have figured it would have M/Y in there
<steev>
oh, is that all only Y?
alpernebbi has quit [Ping timeout: 258 seconds]
alpernebbi has joined #armlinux
NonaSuomy has quit [Ping timeout: 276 seconds]
NonaSuomy has joined #armlinux
snalty has quit [Ping timeout: 246 seconds]
cmarinas_ has joined #armlinux
snalty has joined #armlinux
shailangsa has quit [Ping timeout: 246 seconds]
Nact has joined #armlinux
rvalue- has joined #armlinux
cmarinas has quit [Ping timeout: 246 seconds]
rvalue has quit [Ping timeout: 246 seconds]
rvalue- is now known as rvalue
Nact has quit [Read error: Connection reset by peer]
cbeznea has joined #armlinux
shailangsa_ has joined #armlinux
apritzel has joined #armlinux
apritzel has quit [Ping timeout: 244 seconds]
iivanov has joined #armlinux
<hanetzer>
steev: unsure tbh.
<hanetzer>
I was just surprised to see them :P
<hanetzer>
hrm.... what does one need to do to a phy driver to make it accept @ notation?
<jn>
AFAICS, nothing, the subsystem should handle devicetree integration
monstr has joined #armlinux
<jn>
(looking at phy/smsc.c)
<hanetzer>
the drivers/phy/hisilicon/phy-hix5hd2-sata.c driver shares what *appear* to be more or less the same regs, however there's some reg definitions which are like y + 0x80 * i, and *that* implementation is hardcoded to a particular value of i
<jn>
where are these definitions?
<hanetzer>
jn: in the driver and the datasheets.
<hanetzer>
hol up, I'll eyeball yours too :P
jlinton has joined #armlinux
<jn>
ah, "0x010+nx0x80" in the DS
frieder has joined #armlinux
<hanetzer>
yeh
<hanetzer>
yours seem pretty close as well.
<jn>
since this phy is already declared with an address in the DT (phy@1900000), i see two ways forward:
<jn>
1. use two instances, one with reg = <0x1900000 0x80>, the other with reg = <0x1900080 0x80>
<jn>
2. make a new version of the DT binding that allows #phy-cells = <1>. then, a single PHY node will provide two PHYs. consumers in the devicetree will then specify phy = <&sata_phy 0> or phy = <&sata_phy 1>
<jn>
option 1 looks easier because you don't have to break devicetree compatibility
<jn>
Oh, and the @123 is more or less just for decoration. the information really comes from the reg attribute, AFAIUI
<hanetzer>
ah
<hanetzer>
well. the thing is following the 0xa0 (as mentioned in the driver itself, sata_phy0_ctll) is immediately followed by the same thing at 0xac :P
apritzel has joined #armlinux
<hanetzer>
0xa0-0xa8 is duplicated at 0xac-0xb4
<hanetzer>
so SATA_PHYn_{CTLL,CTLH,STS}, where n is 0 or 1
<hanetzer>
further, their definition of SATA_PORT_PHYCTL as 0x174 is in actuality 0x74 + n * 0x80, n being 2 here
sszy has joined #armlinux
<jn>
hmm
<jn>
anyway, what is the hard-related behavior that you want to achieve?
<jn>
currently, the driver seems to initialize the whole PHY block
cleger has joined #armlinux
<hanetzer>
ah. well. I'm *pretty sure* I've configured the sata clocks correctly, however, when the sata is plugged in dmesg is spammed with ata error messages every so often and the device node never pops up :)
<hanetzer>
and comparing the bsp driver against the mainline one shows different n-values being used.
<hanetzer>
(also compared against running in the qemu model I have setup)
<jn>
hm
<jn>
i'd try fixing it within the driver first, and caring about devicetree representation later
<hanetzer>
tbh its a pretty handy tool :)
<hanetzer>
so n-- in hax eh?
<hanetzer>
suppose that would be enough to confirm it working, if nothing else.
<jn>
the mainline driver doesn't even consider any n
<hanetzer>
yep.
<jn>
as to the devicetree binding: does the consumer (the AHCI driver) need to control different PHYs separately?
<jn>
otherwise, the binding can stay as it is
<jn>
(i retract my suggestion above of using multiple instances. it won't work with the register offsets used in the PHY driver)
<hanetzer>
yeh. if they were all offsets of 0x80 it could :)
jlinton has quit [Ping timeout: 252 seconds]
<hanetzer>
tbh not sure.
apritzel has quit [Ping timeout: 276 seconds]
<hanetzer>
hrm. y'kno, could stick an additional property in the dt-binding, something like implemented-ports or the like, and iterate over that
<hanetzer>
because yah, I can see, in the qemu trace log, it hits, one after the other, n=0,n=1 more or less immediately one after the other, going down a reg list
<hanetzer>
so it hits 0x0144, then 0x01c4
<hanetzer>
same values written.
<hanetzer>
funny thing. my ds says BIT(23) is reserved and RO, but the vendor driver tries to write 0 to it, and my own experimentation with devmem and u-boot's md shows that bit is writable lol
<hanetzer>
oh wait... 0x174 isn't 0x74 + 2*0x80; the port config regs start at 0x100 into the block
<jn>
as an alternative to the implemented-ports property (not sure which option is better), you could match a chip-specific compatible string and decide how many ports to initialize based on that
<hanetzer>
ahhh yeah, that works too.
luispm has joined #armlinux
djrscally has joined #armlinux
<hanetzer>
hrm. now to find an example of how do to that properly :)
bps has joined #armlinux
bps has quit [Changing host]
bps has joined #armlinux
headless has joined #armlinux
nsaenz has joined #armlinux
<hanetzer>
btw, this is the message spammed: ata1: SATA link down (SStatus 1 SControl 300)
<hanetzer>
and hardcoding a simple loop from 0-1 in doesn't fix it :/
apritzel has joined #armlinux
<hanetzer>
remind me again, but %X is capital hex yeh?
matthias_bgg has joined #armlinux
<jn>
yes
<jn>
(without 0x prefix)
<hanetzer>
aight then. I thought those were decimal numbers tbh. now I have know what its saying.
<hanetzer>
device is detected but coms not set up, hrm.
<hanetzer>
I swear this is gonna end up something stupid
prabhakarlad has quit [Quit: Client closed]
tre has joined #armlinux
matthias_bgg has quit [Ping timeout: 258 seconds]
matthias_bgg has joined #armlinux
headless has quit [Quit: Konversation terminated!]
sicelo has quit [Ping timeout: 256 seconds]
sicelo has joined #armlinux
sicelo has joined #armlinux
sicelo has quit [Changing host]
sicelo has quit [Read error: Connection reset by peer]
sicelo has joined #armlinux
sicelo has joined #armlinux
sicelo has quit [Changing host]
sicelo has quit [Quit: Bye!]
sicelo has joined #armlinux
sicelo has quit [Changing host]
sicelo has joined #armlinux
sicelo has quit [Client Quit]
sicelo has joined #armlinux
sicelo has quit [Changing host]
sicelo has joined #armlinux
<hanetzer>
drivers/phy/broadcom/phy-bcm63xx-usbh.c seems like this is a good enough example for how to set it up :)
sicelo has quit [Quit: Bye!]
sicelo has joined #armlinux
headless has joined #armlinux
apritzel_ has joined #armlinux
apritzel_ has quit [Ping timeout: 244 seconds]
mcoquelin has quit [Quit: Leaving]
mcoquelin has joined #armlinux
jlinton has joined #armlinux
Tokamak has joined #armlinux
Tokamak has quit [Ping timeout: 256 seconds]
Tokamak has joined #armlinux
tre has quit [Remote host closed the connection]
headless has quit [Quit: Konversation terminated!]
amitk_ has joined #armlinux
amitk has quit [Ping timeout: 246 seconds]
ywnkmn has quit [Read error: Connection reset by peer]
monstr has quit [Remote host closed the connection]
<ukleinek>
broonie: it's a pleasure to send patches for asoc or spi or regulator. I cannot remember when I had to ping my patches in that area. 👍 and thanks.
<broonie>
ukleinek: Tell that to the people who send complicated patches I have to think about and then get buried :/
* hanetzer
cries in bsp
<hanetzer>
gettin there tho :)
atorgue has joined #armlinux
NonaSuomy has quit [Ping timeout: 246 seconds]
Pali has joined #armlinux
cleger has quit [Remote host closed the connection]
luispm has quit [Quit: Leaving]
frieder has quit [Remote host closed the connection]
NonaSuomy has joined #armlinux
headless has joined #armlinux
balrog has quit [Quit: Bye]
bps has quit [Ping timeout: 244 seconds]
balrog has joined #armlinux
NonaSuomy has quit [Ping timeout: 260 seconds]
NonaSuomy has joined #armlinux
nsaenz has quit [Quit: Leaving]
bps has joined #armlinux
bps has quit [Changing host]
bps has joined #armlinux
marex has quit [Ping timeout: 255 seconds]
matthias_bgg has quit [Ping timeout: 272 seconds]
apritzel has quit [Ping timeout: 244 seconds]
Lucanis has quit [Read error: Connection reset by peer]
Lucanis has joined #armlinux
Amit_T has quit [Quit: Leaving]
atorgue has quit [Ping timeout: 252 seconds]
punit_ has joined #armlinux
ccaione_ has joined #armlinux
sjg1_ has joined #armlinux
ardb_ has joined #armlinux
maennich_ has joined #armlinux
georgem_ has joined #armlinux
roxell_ has joined #armlinux
jamestperk_ has joined #armlinux
bryanb_ has joined #armlinux
krzk_ has joined #armlinux
ukleinek_ has joined #armlinux
Stary_ has joined #armlinux
sjg1 has quit [Ping timeout: 248 seconds]
ardb has quit [Ping timeout: 248 seconds]
punit has quit [Ping timeout: 248 seconds]
maennich has quit [Ping timeout: 248 seconds]
ccaione has quit [Ping timeout: 248 seconds]
roxell has quit [Ping timeout: 248 seconds]
krzk has quit [Ping timeout: 248 seconds]
ukleinek has quit [Ping timeout: 248 seconds]
jbru has quit [Ping timeout: 248 seconds]
Stary has quit [Ping timeout: 248 seconds]
georgem has quit [Ping timeout: 248 seconds]
suzukikp has quit [Ping timeout: 248 seconds]
bryanb has quit [Ping timeout: 248 seconds]
jamestperk has quit [Ping timeout: 248 seconds]
maennich_ is now known as maennich
ccaione_ is now known as ccaione
bryanb_ is now known as bryanb
sjg1_ is now known as sjg1
ardb_ is now known as ardb
georgem_ is now known as georgem
jamestperk_ is now known as jamestperk
jbru has joined #armlinux
suzukikp has joined #armlinux
Stary_ is now known as Stary
sicelo has quit [Read error: Connection reset by peer]
sicelo has joined #armlinux
sicelo has joined #armlinux
sicelo has quit [Changing host]
apritzel_ has joined #armlinux
guillaume_g has quit [Ping timeout: 260 seconds]
marex has joined #armlinux
sicelo has quit [Read error: Connection reset by peer]
amitk_ has quit [Ping timeout: 240 seconds]
headless has quit [Quit: Konversation terminated!]
amitk has joined #armlinux
amitk has quit [Ping timeout: 258 seconds]
amitk has joined #armlinux
amitk has quit [Ping timeout: 258 seconds]
amitk has joined #armlinux
bps has quit [Ping timeout: 250 seconds]
sicelo has joined #armlinux
sicelo has joined #armlinux
sicelo has quit [Changing host]
sicelo has quit [Client Quit]
apritzel_ is now known as apritzel
sicelo has joined #armlinux
sicelo has joined #armlinux
sicelo has quit [Changing host]
sicelo has quit [Remote host closed the connection]
sicelo has joined #armlinux
sicelo has joined #armlinux
sicelo has quit [Changing host]
sicelo has quit [Remote host closed the connection]
ywnkmn has quit [Remote host closed the connection]
sicelo has joined #armlinux
sicelo has quit [Changing host]
sicelo has joined #armlinux
sicelo has quit [Read error: Connection reset by peer]