<zyp[m]>
<whitequark[cis]> "specifically https://github.com..." <- oh, yeah, sounds good, I figured we'd bikeshed where to put it at the meeting
<whitequark[cis]>
I've actually been avoiding nominating it since that's unresolved
<whitequark[cis]>
and it would need an update to say exactly which APIs get added a new type option
<zyp[m]>
fair enough
<zyp[m]>
I have a slight concern that add_clock_constraint currently takes an int or float frequency, and depending on whether the platform constraint format takes a frequency or a period might not need a round trip through the reciprocal period at all, so we'd potentially be introducing a rounding error where there's none today
<whitequark[cis]>
I don't think that matters
<whitequark[cis]>
a timing constraint is not an exact limit but it has PVT variation and some safety margin on top anyway
<whitequark[cis]>
all of those make rounding errors irrelevant
<zyp[m]>
all negligible, of course, so I won't lose any sleep over it, just remarking
<whitequark[cis]>
it would potentially matter for eg a PLL
<whitequark[cis]>
but I think those use periods usually
<zyp[m]>
the PLLs I've worked with just takes division factors and the rest is calculated from the input clock
<whitequark[cis]>
I think the complex ones usually have the toolchain calculate the factors
Wanda[cis] has joined #amaranth-lang
<Wanda[cis]>
PLLs often take the input frequency in addition to the factors
<Wanda[cis]>
to optimize some internal loop filter parameters or whatever
<Wanda[cis]>
(tbh I don't really know how any of this works, I just reverse engineer bitstreams)
<jfng[m]>
it seems awkward to me to talk about signature members in one case, and attributes in the other
<jfng[m]>
it is
<whitequark[cis]>
lib.crc is outdated, I only recently added Members
<whitequark[cis]>
you can submit a PR to switch Attributes to Members. previously Sphinx would break
<whitequark[cis]>
there's some stuff in conf.py to make it not break on this type of section
<jfng[m]>
ok
notgull has joined #amaranth-lang
notgull has quit [Ping timeout: 264 seconds]
<jfng[m]>
<whitequark[cis]> "you can submit a PR to switch..." <- actually, to do it properly, when would have to port `lib.crc` to components, and it is tempting to port the rest of stdlib too (except maybe `lib.coding` because it is going away)
<jfng[m]>
but then `lib.fifo` is a bit weird; the `FIFOInterface` mixin is public API and would have to go away
<whitequark[cis]>
that would require an RFC first
<jfng[m]>
s/when/one/
<jfng[m]>
yeah..
<whitequark[cis]>
and yes it should use Attributes until it's a component
<_whitenotifier-9>
[amaranth-lang/amaranth-lang.github.io] github-merge-queue[bot] facc373 - Deploying to main from @ amaranth-lang/amaranth@e2b47c1a9ea319f8165d00363768654f85d23eb1 🚀
<whitequark[cis]>
Wanda: hm, have we deprecated `Pin`?
<Wanda[cis]>
there's an outstanding pr
<whitequark[cis]>
ohhh, I see
<whitequark[cis]>
(I'm writing the documentation page at the moment)
<Wanda[cis]>
also you wanted to block that on docs?
<Wanda[cis]>
right
nyanotech has quit [Remote host closed the connection]