azonenberg changed the topic of #scopehal to: ngscopeclient, libscopehal, and libscopeprotocols development and testing | https://github.com/ngscopeclient/scopehal-apps | Logs: https://libera.irclog.whitequark.org/scopehal
<_whitenotifier-5> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±2] https://github.com/ngscopeclient/scopehal/compare/52e9d64c57bb...23f33df5dcdd
<_whitenotifier-7> [scopehal] azonenberg 23f33df - Fixed broken serialization for CAN waveforms when loading offline
<_whitenotifier-5> [scopehal] d235j commented on pull request #841: Refactor of Cmake scripts - https://github.com/ngscopeclient/scopehal/pull/841#issuecomment-1933147389
<_whitenotifier-7> [scopehal] d235j opened pull request #853: Win32 fixes - https://github.com/ngscopeclient/scopehal/pull/853
<_whitenotifier-7> [scopehal] d235j synchronize pull request #853: Win32 fixes - https://github.com/ngscopeclient/scopehal/pull/853
<_whitenotifier-5> [scopehal] d235j synchronize pull request #841: Refactor of Cmake scripts - https://github.com/ngscopeclient/scopehal/pull/841
<_whitenotifier-7> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<d1b2> <vipqualitypost> hey so taking a few notes from this dear imgui issue: https://github.com/ocornut/imgui/issues/5301 I was able to make hidpi work without any apparent issues with mouse position! it also fixed the scrollbar issue
<d1b2> <vipqualitypost> (and it turns out 13 is actually a very reasonable font size for default)
<d1b2> <david.rysk> Can you PR your workarounds?
<d1b2> <david.rysk> I don't like the hacky approach and would rather fix imgui upstream, but this is not straightforward so I talked to ocornut about it
<d1b2> <vipqualitypost> sure! I don't know if it will effect non-hidpi screens. Is there a define guard I can use? Like __APPLE or something?
<d1b2> <david.rysk> He says he'll look at it in a few weeks, but a temporary fix for now would be good
<d1b2> <david.rysk> Yes... APPLE
<d1b2> <david.rysk> er, __APPLE__
<d1b2> <vipqualitypost> It's not bad, this is my fix in VulkanWindow.cpp // Apply DPI scaling now that glfw initialized // CGFloat scale = NSScreen.mainScreen.backingScaleFactor; // ImFontConfig cfg; // cfg.SizePixels = 13.0f * scale; // io.Fonts->AddFontDefault(&cfg); // io.FontGlobalScale = 1.0f / scale; float scale = GetContentScale(); ImFontConfig cfg; cfg.SizePixels = 13.0f * scale; io.Fonts->AddFontDefault(&cfg);
<d1b2> io.FontGlobalScale = 1.0f / scale; LogTrace("Applying ImGui style scale factor: %.2f\n", scale);
<d1b2> <david.rysk> does that hardcode it to 13, or does that have to be pulled from settings?
<d1b2> <david.rysk> I just rebased all my CMake work, btw
<d1b2> <vipqualitypost> I don't believe it does but let me check.
<d1b2> <david.rysk> but I have to finish the docs
<azonenberg> We should pull from settings. On that note, I want to work on unifying preferences at some point. I think we may have erred on the side of "too many settings"
<azonenberg> to the point that e.g. enlarging fonts in the UI requires changing 30 different fonts
<azonenberg> So we should probably spend some time thinking about which settings make sense to be independent ]vs the same
<d1b2> <vipqualitypost> seems the 13.0f is supposed to just set scaling for hidpi with double resolution?
<d1b2> <vipqualitypost> I am able to change all font sizes via the preferences so at least it doesn't seem broken- I tweaked all the ones I could find
<_whitenotifier-5> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±2] https://github.com/ngscopeclient/scopehal-apps/compare/2d84b7b6f76e...a5f5e9b8b2cf
<_whitenotifier-7> [scopehal-apps] azonenberg a5f5e9b - Updated submodules
<d1b2> <vipqualitypost> yea, it really does seem like too many controls 🙂
<d1b2> <david.rysk> the other question I have is how will this handle dragging the ngscopeclient window to a second screen that isn't HiDPI
<d1b2> <azonenberg> Mixed DPI support is a much harder problem
<d1b2> <azonenberg> Let's start by solving the only-standard or only-high states
<d1b2> <david.rysk> yeah that's what he wants to get right
<d1b2> <azonenberg> once both work, we can figure out how to switch between them
<d1b2> <vipqualitypost> no this is just on my macbook air with no external display
<d1b2> <david.rysk> add the workaround, put a //WORKAROUND comment in front of it
<d1b2> <david.rysk> and PR it 🙂
<d1b2> <vipqualitypost> on your cmake branch? or on main?
<d1b2> <david.rysk> on main
<d1b2> <vipqualitypost> gotcha
<d1b2> <david.rysk> I'll test it here on my ci-work branch
<d1b2> <vipqualitypost> have to run for now but will open in a few hours or tomorrow morning
<d1b2> <vipqualitypost> or maybe i can fit it in now
<d1b2> <david.rysk> I may test it locally but I'd prefer you PR it 🙂
<_whitenotifier-5> [scopehal-docs] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/ngscopeclient/scopehal-docs/compare/8b5f3d8d7262...4ecb75522297
<_whitenotifier-7> [scopehal-docs] azonenberg 4ecb755 - Added example capture command to candump import filter
<_whitenotifier-7> [scopehal] azonenberg closed pull request #853: Win32 fixes - https://github.com/ngscopeclient/scopehal/pull/853
<_whitenotifier-5> [scopehal] azonenberg 3439121 - Merge pull request #853 from d235j/win32-fixes Win32 fixes
<_whitenotifier-7> [scopehal] azonenberg pushed 3 commits to master [+0/-0/±4] https://github.com/ngscopeclient/scopehal/compare/23f33df5dcdd...3439121b1846
<_whitenotifier-7> [scopehal-apps] VIPQualityPost forked the repository - https://github.com/VIPQualityPost
<_whitenotifier-7> [scopehal-apps] VIPQualityPost opened pull request #682: HiDPI support for Mac - https://github.com/ngscopeclient/scopehal-apps/pull/682
<d1b2> <vipqualitypost> ok, check it whenever you have time 🙂
<d1b2> <david.rysk> @vipqualitypost can you check out the scopehal-testdata repo, try to open the 1000base-X.scopesession, and see if the tabs work?
<d1b2> <david.rysk> or the groups rather
<d1b2> <david.rysk> or just make another group
<d1b2> <vipqualitypost> most of it seems to work fine but the decode text scaling is not fixed
<d1b2> <vipqualitypost> oh sorry did not check the one thing you wanted: groups
<d1b2> <vipqualitypost> I can swap groups and they both look good, but I can't scroll the eye diagram, but also my computer seems to struggle with this waveform... I am only on M1 air so not too much horsepower
<d1b2> <vipqualitypost> oh the eye diagram is all data overlayed, duh. So I guess it all works fine?
<d1b2> <david.rysk> @azonenberg what are you doing with font scale in m_fontmgr.UpdateFonts() ?
<d1b2> <david.rysk> seems if I mess with that, it screws up both imgui and drawn fonts
<d1b2> <david.rysk> wait nope, it only changes drawn fonts
<d1b2> <david.rysk> only changes imgui fonts*
<d1b2> <david.rysk> not drawn fonts
<d1b2> <azonenberg> yeah eyes are not supposed to scroll
<d1b2> <azonenberg> This is actually an older session file created with glscopeclient hence the weird tab layout. I'm going to be going through all of the test data, probably collecting new waveforms, etc over the next few months
<d1b2> <azonenberg> and making new demo/test projects that show off the current capabilities of the software better
<d1b2> <azonenberg> While keeping these old ones around in archives so we can verify that we still have compatibility with legacy files
<d1b2> <azonenberg> (in particular due to the compltely different ui toolkits, the relative positions and sizes of plots are lost loading a glscopeclient legacy session in ngscopeclient)
<d1b2> <vipqualitypost> is there anything else you would like me to check for this scaling issue for now?
<d1b2> <azonenberg> so we just make one tab for each as a default and expect that you'll rearrange as you need
<d1b2> <azonenberg> @david.rysk I'm on the way home from work now and will try to review and merge the other PRs when I get back
<d1b2> <david.rysk> alright cool
<d1b2> <david.rysk> I'll keep poking at this...
<d1b2> <vipqualitypost> is there a trackpad gesture to scrub through a waveform? scrolling while in waveform just does x-axis scaling which is what I would expect when scrolling while hovering over axis (like with y-axis)
<d1b2> <david.rysk> at the moment it only does scaling
<d1b2> <azonenberg> Shift scroll should move in the x axis
<d1b2> <azonenberg> at least it did in glscopeclient, i cant remember if we implemented that in ngscopeclient or not
<d1b2> <azonenberg> if not, it'll be easy to do
<d1b2> <azonenberg> but typically the way you navigate with the mouse/touchpad is to zoom out, find the region of interest, then zoom back in
Degi_ has joined #scopehal
Degi has quit [Ping timeout: 256 seconds]
Degi_ is now known as Degi
<d1b2> <vipqualitypost> I use many apps like that (kicad, freecad) but it did not feel quite right... let me try again
<d1b2> <vipqualitypost> oh, it does work, I think I was just looking at too much periodic data to make sense of it 😛
<d1b2> <vipqualitypost> Shift scroll does not work but that would be very nice to have as zoom out/in mentally makes more sense for 2D/3D planes than for a 2D time-domain plot to me
<d1b2> <david.rysk> @vipqualitypost I think I have a solution to the scaling problem, it's not the prettiest
<d1b2> <david.rysk> @vipqualitypost can you try this branch https://github.com/d235j/scopehal-apps/tree/macos-scaling-fix
<d1b2> <david.rysk> that integrates your workaround
<d1b2> <david.rysk> but handles it a little differently since ngscopeclient loads all the fonts in a different place
<d1b2> <vipqualitypost> could you open a pr into ngscopeclient repo so I don't have to totally rebuild from scratch? if not no worries
<d1b2> <david.rysk> I can or you can fetch it
<d1b2> <vipqualitypost> oh really?
<d1b2> <vipqualitypost> same as before to just add a remote?
<d1b2> <david.rysk> git remote add d235j https://github.com/d235j/scopehal-apps.git git fetch d235j git checkout blah
<d1b2> <david.rysk> you might already have the remote
<d1b2> <david.rysk> Should I PR it or do you want to test it first?
<d1b2> <vipqualitypost> i'm building now
<d1b2> <vipqualitypost> had to do from scratch so might be a few minutes
<d1b2> <david.rysk> alright
<d1b2> <david.rysk> what hardware do you have?
<d1b2> <vipqualitypost> m1 mba
<d1b2> <david.rysk> I'm running on an M2 MacBook Air with 24GB of RAM
<d1b2> <vipqualitypost> thinking about getting something new though (8gb :P)
<d1b2> <david.rysk> yeah this stuff is somewhat RAM hungry
<d1b2> <david.rysk> I specced mine up...
<_whitenotifier-5> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±2] https://github.com/ngscopeclient/scopehal-apps/compare/a5f5e9b8b2cf...ef0aebf43c95
<_whitenotifier-7> [scopehal-apps] azonenberg ef0aebf - Updated submodules
<_whitenotifier-7> [scopehal-apps] d235j opened pull request #683: Fix scaling on macOS - https://github.com/ngscopeclient/scopehal-apps/pull/683
<d1b2> <azonenberg> @david.rysk ngscopeclient ram usage on apple silicon will be cut roughly in half (waveform usage will halve, but general app usage wont change) once we improve unified memory handling
<d1b2> <azonenberg> Just a matter of someone having time to implement and test
<_whitenotifier-5> [scopehal-apps] d235j commented on pull request #683: Fix scaling on macOS - https://github.com/ngscopeclient/scopehal-apps/pull/683#issuecomment-1933329359
<d1b2> <vipqualitypost> yep this looks great!
<d1b2> <david.rysk> can you comment on my PR? (and maybe close yours, sorry!)
<d1b2> <azonenberg> @david.rysk for #850 can you add a check for CAIRO_MAJOR_VERSION (assuming that exists) too?
<d1b2> <azonenberg> otherwise this wouldn't trigger for say 2.0
<d1b2> <azonenberg> not that i expect we'll still be using cairo that far in the future :p
<d1b2> <azonenberg> But good practice
<d1b2> <david.rysk> sure hold on
<d1b2> <azonenberg> looks good to merge otherwise
<d1b2> <azonenberg> Also @vipqualitypost can you close your PR if we're gonna use the version from @david.rysk ?
<d1b2> <azonenberg> And @david.rysk where are we with the cmake PRs? i think they're still drafts
<d1b2> <azonenberg> do you consider them merge ready?
<d1b2> <david.rysk> I can undraft them, I didn't finish the docs rework
<d1b2> <david.rysk> yeah I'd say they're a significant improvement
<d1b2> <azonenberg> ok in that case let's merge the scaling PR then i'll start reviewing those
<d1b2> <azonenberg> I dont want your branch to diverge too much from upstream without a good reason
<d1b2> <david.rysk> yeah
<d1b2> <azonenberg> At this stage in development it's better if everyone is running close to bleeding edge so we can find and fix issues quickly
<_whitenotifier-5> [scopehal] d235j edited pull request #841: Refactor of Cmake scripts - https://github.com/ngscopeclient/scopehal/pull/841
<_whitenotifier-7> [scopehal] d235j edited pull request #841: Refactor of Cmake scripts - https://github.com/ngscopeclient/scopehal/pull/841
<_whitenotifier-7> [scopehal-apps] d235j edited pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-7> [scopehal-apps] d235j edited pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-7> [scopehal] d235j synchronize pull request #850: Support sigcxx 2 and 3 API, and cairomm 1 and 1.16 API - https://github.com/ngscopeclient/scopehal/pull/850
<d1b2> <david.rysk> @azonenberg that PR is updated
<_whitenotifier-7> [scopehal] d235j synchronize pull request #850: Support sigcxx 2 and 3 API, and cairomm 1 and 1.16 API - https://github.com/ngscopeclient/scopehal/pull/850
<_whitenotifier-7> [scopehal] azonenberg closed pull request #850: Support sigcxx 2 and 3 API, and cairomm 1 and 1.16 API - https://github.com/ngscopeclient/scopehal/pull/850
<_whitenotifier-5> [scopehal] azonenberg pushed 2 commits to master [+0/-0/±36] https://github.com/ngscopeclient/scopehal/compare/3439121b1846...5af1f199a2e4
<_whitenotifier-7> [scopehal] azonenberg 5af1f19 - Merge pull request #850 from d235j/sigcxx-and-cairomm-new-api Support sigcxx 2 and 3 API, and cairomm 1 and 1.16 API
<d1b2> <azonenberg> ok so thats merged, i think next in line is the scaling one
<d1b2> <david.rysk> yeah
<_whitenotifier-5> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-5> [scopehal-apps] d235j synchronize pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
<_whitenotifier-7> [scopehal] d235j synchronize pull request #841: Refactor of Cmake scripts - https://github.com/ngscopeclient/scopehal/pull/841
<_whitenotifier-5> [scopehal-apps] d235j opened pull request #684: Ci improvements - https://github.com/ngscopeclient/scopehal-apps/pull/684
<_whitenotifier-7> [scopehal-apps] d235j edited pull request #684: CI improvements - https://github.com/ngscopeclient/scopehal-apps/pull/684
<_whitenotifier-5> [scopehal-apps] azonenberg closed pull request #666: Update build-debian-seflhosted.yml & build-ubuntu.yml to use Vulkan SDK Version 1.3.268.0 - https://github.com/ngscopeclient/scopehal-apps/pull/666
<_whitenotifier-7> [scopehal-apps] azonenberg commented on pull request #666: Update build-debian-seflhosted.yml & build-ubuntu.yml to use Vulkan SDK Version 1.3.268.0 - https://github.com/ngscopeclient/scopehal-apps/pull/666#issuecomment-1933364230
<_whitenotifier-7> [scopehal-apps] azonenberg commented on pull request #682: HiDPI support for Mac - https://github.com/ngscopeclient/scopehal-apps/pull/682#issuecomment-1933364567
<_whitenotifier-5> [scopehal-apps] azonenberg closed pull request #682: HiDPI support for Mac - https://github.com/ngscopeclient/scopehal-apps/pull/682
<_whitenotifier-5> [scopehal-apps] azonenberg closed pull request #683: Fix scaling on macOS - https://github.com/ngscopeclient/scopehal-apps/pull/683
<_whitenotifier-5> [scopehal-apps] azonenberg closed issue #625: macOS: Scale GUI for Retina displays - https://github.com/ngscopeclient/scopehal-apps/issues/625
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 2 commits to master [+0/-0/±10] https://github.com/ngscopeclient/scopehal-apps/compare/ef0aebf43c95...41c774320667
<_whitenotifier-5> [scopehal-apps] azonenberg 41c7743 - Merge pull request #683 from d235j/macos-scaling-fix Fix scaling on macOS
<d1b2> <azonenberg> @hansemro i see you still have two PRs from the summer for siglent related stuff that are marked as drafts
<d1b2> <azonenberg> against scopehal
<d1b2> <azonenberg> what's the status of those?
<_whitenotifier-5> [scopehal] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/ngscopeclient/scopehal/compare/5af1f199a2e4...f4a84df54c74
<_whitenotifier-7> [scopehal] azonenberg f4a84df - Fixed missing break in switch
<d1b2> <hansemro> We can close PR for VideoTrigger as I mostly worked on it to familiarize myself with Siglent SCPI and scopehal API. It was a sort of an experiment to see how we can support a new trigger. Nothing I needed practically. If anyone needs it, they are free to pick up it up the PR.
<azonenberg> Ok then please close for now unless you think it's polished enough to merge as-is
<_whitenotifier-7> [scopehal] hansemro closed pull request #783: Add Siglent VideoTrigger support - https://github.com/ngscopeclient/scopehal/pull/783
Stephie has quit [*.net *.split]
Degi has quit [*.net *.split]
Stary has quit [*.net *.split]
t4nk_fn has quit [*.net *.split]
florolf has quit [*.net *.split]
mxshift has quit [*.net *.split]
azonenberg has quit [*.net *.split]
josuah has quit [*.net *.split]
Ekho has quit [*.net *.split]
octorian has quit [*.net *.split]
miek has quit [*.net *.split]
balrog has quit [*.net *.split]
davidc__ has quit [*.net *.split]
gruetzkopf has quit [*.net *.split]
electronic_eel has quit [*.net *.split]
veegee has quit [*.net *.split]
vup has quit [*.net *.split]
sgstair has quit [*.net *.split]
_florent_ has quit [*.net *.split]
agg has quit [*.net *.split]
cyborg_ar has quit [*.net *.split]
Abhishek_ has quit [*.net *.split]
Yamakaja has quit [*.net *.split]
_whitenotifier-7 has quit [*.net *.split]
sorear has quit [*.net *.split]
Fridtjof has quit [*.net *.split]
Kerr has quit [*.net *.split]
juri_ has quit [*.net *.split]
lain has quit [*.net *.split]
d1b2 has quit [*.net *.split]
esden has quit [*.net *.split]
JSharp has quit [*.net *.split]
_whitenotifier-5 has quit [*.net *.split]
Darius has quit [*.net *.split]
mithro has quit [*.net *.split]
tnt has quit [*.net *.split]
elms has quit [*.net *.split]
anuejn has quit [*.net *.split]
benishor has quit [*.net *.split]
lethalbit has quit [*.net *.split]
Degi has joined #scopehal
Kerr has joined #scopehal
_whitenotifier-7 has joined #scopehal
_whitenotifier-5 has joined #scopehal
miek has joined #scopehal
sorear has joined #scopehal
Stephie has joined #scopehal
d1b2 has joined #scopehal
sgstair has joined #scopehal
_florent_ has joined #scopehal
veegee has joined #scopehal
azonenberg has joined #scopehal
balrog has joined #scopehal
juri_ has joined #scopehal
electronic_eel has joined #scopehal
cyborg_ar has joined #scopehal
Darius has joined #scopehal
anuejn has joined #scopehal
josuah has joined #scopehal
davidc__ has joined #scopehal
vup has joined #scopehal
Fridtjof has joined #scopehal
agg has joined #scopehal
Stary has joined #scopehal
benishor has joined #scopehal
Ekho has joined #scopehal
JSharp has joined #scopehal
t4nk_fn has joined #scopehal
florolf has joined #scopehal
mxshift has joined #scopehal
esden has joined #scopehal
octorian has joined #scopehal
gruetzkopf has joined #scopehal
lethalbit has joined #scopehal
mithro has joined #scopehal
elms has joined #scopehal
lain has joined #scopehal
Yamakaja has joined #scopehal
tnt has joined #scopehal
Abhishek_ has joined #scopehal
lethalbit has quit [*.net *.split]
lethalbit has joined #scopehal
anuejn has quit [*.net *.split]
benishor has quit [*.net *.split]
_whitenotifier-5 has quit [*.net *.split]
Darius has quit [*.net *.split]
mithro has quit [*.net *.split]
tnt has quit [*.net *.split]
elms has quit [*.net *.split]
benishor has joined #scopehal
anuejn has joined #scopehal
_whitenotifier-5 has joined #scopehal
Darius has joined #scopehal
mithro has joined #scopehal
elms has joined #scopehal
tnt has joined #scopehal
d1b2 has quit [*.net *.split]
esden has quit [*.net *.split]
JSharp has quit [*.net *.split]
_florent_ has quit [*.net *.split]
sgstair has quit [*.net *.split]
agg has quit [*.net *.split]
cyborg_ar has quit [*.net *.split]
Abhishek_ has quit [*.net *.split]
Yamakaja has quit [*.net *.split]
veegee has quit [*.net *.split]
vup has quit [*.net *.split]
cyborg_ar has joined #scopehal
_florent_ has joined #scopehal
sgstair has joined #scopehal
agg has joined #scopehal
Abhishek_ has joined #scopehal
Yamakaja has joined #scopehal
<_whitenotifier-5> [scopehal] azonenberg closed pull request #841: Refactor of Cmake scripts - https://github.com/ngscopeclient/scopehal/pull/841
<_whitenotifier-7> [scopehal] azonenberg 37e8e74 - Merge pull request #841 from d235j/cmake-cleanups Refactor of Cmake scripts
<_whitenotifier-5> [scopehal] azonenberg pushed 2 commits to master [+0/-0/±4] https://github.com/ngscopeclient/scopehal/compare/f4a84df54c74...37e8e749df0c
electronic_eel has quit [*.net *.split]
electronic_eel has joined #scopehal
d1b2 has joined #scopehal
esden has joined #scopehal
JSharp has joined #scopehal
d1b2 has quit [Remote host closed the connection]
vup has joined #scopehal
veegee has joined #scopehal
veegee has quit [Max SendQ exceeded]
Kerr has quit [*.net *.split]
juri_ has quit [*.net *.split]
lain has quit [*.net *.split]
Kerr has joined #scopehal
juri_ has joined #scopehal
lain has joined #scopehal
veegee has joined #scopehal
<_whitenotifier-7> [scopehal-apps] github-advanced-security[bot] commented on pull request #684: CI improvements - https://github.com/ngscopeclient/scopehal-apps/pull/684#issuecomment-1933395900
Kerr has quit [*.net *.split]
juri_ has quit [*.net *.split]
lain has quit [*.net *.split]
_whitenotifier-7 has quit [*.net *.split]
sorear has quit [*.net *.split]
Fridtjof has quit [*.net *.split]
lain has joined #scopehal
Fridtjof has joined #scopehal
juri_ has joined #scopehal
sorear has joined #scopehal
Kerr has joined #scopehal
_whitenotifier-7 has joined #scopehal
<_whitenotifier-5> [scopehal-apps] azonenberg closed pull request #684: CI improvements - https://github.com/ngscopeclient/scopehal-apps/pull/684
<_whitenotifier-5> [scopehal-apps] azonenberg fbc773f - Merge pull request #684 from d235j/ci-improvements CI improvements
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 4 commits to master [+2/-8/±28] https://github.com/ngscopeclient/scopehal-apps/compare/41c774320667...fbc773f0b0c9
<_whitenotifier-7> [scopehal-apps] azonenberg closed pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673
_whitenotifier-7 has quit [*.net *.split]
<_whitenotifier-5> [scopehal-apps] d235j commented on pull request #673: Cmake cleanups - https://github.com/ngscopeclient/scopehal-apps/pull/673#issuecomment-1933410328
_whitenotifier-7 has joined #scopehal
<_whitenotifier-5> [scopehal-apps] d235j opened pull request #685: Fix build with SANITIZE - https://github.com/ngscopeclient/scopehal-apps/pull/685
<_whitenotifier-7> [scopehal-apps] d235j commented on issue #674: macOS build fails: glslang target was not found - https://github.com/ngscopeclient/scopehal-apps/issues/674#issuecomment-1933420401
<_whitenotifier-5> [scopehal-apps] d235j edited a comment on issue #674: macOS build fails: glslang target was not found - https://github.com/ngscopeclient/scopehal-apps/issues/674#issuecomment-1913342725
<_whitenotifier-7> [scopehal] VIPQualityPost forked the repository - https://github.com/VIPQualityPost
<_whitenotifier-5> [scopehal-apps] azonenberg closed pull request #685: Fix build with SANITIZE - https://github.com/ngscopeclient/scopehal-apps/pull/685
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 2 commits to master [+0/-0/±2] https://github.com/ngscopeclient/scopehal-apps/compare/fbc773f0b0c9...e9a64cc66be2
<_whitenotifier-5> [scopehal-apps] azonenberg e9a64cc - Merge pull request #685 from d235j/fix-sanitize Fix build with SANITIZE
<_whitenotifier-5> [scopehal-apps] azonenberg 4a251c6 - Updated submodules
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±1] https://github.com/ngscopeclient/scopehal-apps/compare/e9a64cc66be2...4a251c64f700
<_whitenotifier-5> [scopehal] d235j opened pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-7> [scopehal-apps] d235j opened pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-5> [scopehal] d235j synchronize pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-7> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-5> [scopehal] azonenberg pushed 2 commits to master [+0/-0/±3] https://github.com/ngscopeclient/scopehal/compare/37e8e749df0c...af34b246b2a1
<_whitenotifier-7> [scopehal] azonenberg 517d1eb - CandumpImportFilter: made data rate configurable
<_whitenotifier-5> [scopehal] azonenberg af34b24 - Update to latest xptools
<_whitenotifier-5> [scopehal] d235j synchronize pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-7> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-5> [scopehal-apps] azonenberg 6d43215 - Updated to latest scopehal and imgui
<_whitenotifier-7> [scopehal-apps] azonenberg pushed 1 commit to master [+0/-0/±2] https://github.com/ngscopeclient/scopehal-apps/compare/4a251c64f700...6d432152e6e7
<_whitenotifier-7> [scopehal] d235j synchronize pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-5> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-5> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-5> [scopehal] d235j synchronize pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-7> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-7> [scopehal] d235j synchronize pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-5> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-5> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-5> [scopehal] d235j synchronize pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-7> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-5> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-7> [scopehal] d235j synchronize pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-7> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<azonenberg> Maybe we should turn off bot notifications for pushing to a PR
<_whitenotifier-5> [scopehal] d235j synchronize pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-7> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686
<_whitenotifier-5> [scopehal] d235j synchronize pull request #854: Fix warnings - https://github.com/ngscopeclient/scopehal/pull/854
<_whitenotifier-7> [scopehal-apps] d235j synchronize pull request #686: Fix warnings - https://github.com/ngscopeclient/scopehal-apps/pull/686