<
EshaanAgarwal[m]>
<jonpsy[m]> "I mean, you can set a filter..." <- Okay
<
EshaanAgarwal[m]>
<zoq[m]> "Eshaan Agarwal: what is the..." <- Weights have been fixed. Need to fix environment state.
<
EshaanAgarwal[m]>
Sorry for late replies I had a couple of exams.
<
shrit[m]>
looks good to me, only we need to resolve the issue with the static analysis and it is good to go
<
jonpsy[m]>
<EshaanAgarwal[m]> "Weights have been fixed. Need to..." <- Shouldn't be that hard, you need help?
<
rcurtin[m]>
shrit: as far as I could tell, all the static analysis issues that are left are false positives :(
TarekElsayed[m] has quit [Quit: You have been kicked for being idle]
<
shrit[m]>
Good, let us merge it this weekend
<
zoq[m]>
shrit[m]: Started the review on this one as well, should have it done tomorrow.
<
rcurtin[m]>
thanks! It's a lot of tedium, like most of the PRs I have opened recently 😃