rcurtin_irc changed the topic of #mlpack to: mlpack: a scalable machine learning library (https://www.mlpack.org/) -- channel logs: https://libera.irclog.whitequark.org/mlpack -- NOTE: messages sent here might not be seen by bridged users on matrix, gitter, or slack
<ShubhamAgrawal[m> <rcurtin[m]> "zoq: any comments on https://..." <- You can merge this now
<ShubhamAgrawal[m> > <@shubhamag:matrix.org> https://github.com/mlpack/mlpack/pull/3195
<ShubhamAgrawal[m> > rcurtin What should I do in this now?
<ShubhamAgrawal[m> This too
<jonpsy[m]> <rcurtin[m]> "jonpsy: I've only worked with..." <- I see, Tensorflow seems to love it, but yeah it's pretty old school. How do we provide python binding in mlpack again?
<rcurtin[m]> Shubham Agrawal: thanks for the fixes! glad we got it worked out :)
<rcurtin[m]> shrit: do you have any more comments for https://github.com/mlpack/mlpack/pull/3195? you have it marked 'requested changes' for now, which means we can't merge it yet 😄
<rcurtin[m]> jonpsy: we use various CMake generator scripts + Cython to provide custom bindings... it'
<rcurtin[m]> s a pretty complicated system... I can provide more details and code pointers if you like 😄
<shrit[m]> I will give it a quick review
<rcurtin[m]> thanks! if you're happy with it, go ahead and merge too 👍️ I approved just now
<shrit[m]> Perfect, will do once finished reviewing