12:45 <Grimler> Hi, @krzk after 7fbf6b731b ("power: supply: max17042: Do not enforce (incorrect) interrupt trigger type") and 8a45f33bd3 ("ARM: dts: exynos: correct fuel gauge interrupt trigger level on Midas family") I am seeing lots of "max17042 12-0036: SOC threshold INTR" messages on exynos4412-i9300.

12:46 <Grimler> It sounds like Marek saw the same on trats2, based on https://patchwork.kernel.org/project/linux-samsung-soc/patch/20201210212534.216197-3-krzk@kernel.org/

12:46 <Grimler> Changing back to `IRQ_TYPE_EDGE_FALLING` for i930{0,5} (in exynos4412-galaxy-s3.dtsi) works to silence the message. Would this be an acceptable patch or should this be fixed, properly, somewhere else?

13:59 <krzk> Grimler: if the interrupt level is edge, such patch would be good, but interrupt is not edge, AFAIK :)

14:00 <krzk> Therefore this should be fixed differently.

14:00 <krzk> Or rather - real cause should be found.

14:09 <krzk> Grimler: interrupt line should be pulled by external resistor, so it might mean that fuel gauge is reporting error all the time

14:09 <krzk> Grimler: if you boot with my patch reverted, what is visible in "grep . /sys/class/power_supply/*/*"?

14:30 <krzk> Grimler: can you try following patch and report what it prints?

14:30 <krzk> https://pastebin.ubuntu.com/p/CWgfGnfwsb/

14:31 <krzk> Grimler: I wonder why the interrupt happens - DTS should be correct so I suspect the fuel gauge

15:05 <Grimler> Here's the grep output: https://paste.sr.ht/~grimler/1f2de17f3adda24af3979edcaae354c244860019, AAA debug output and full dmesg

15:09 <Grimler> @krzk The max17042 and/or max77693 driver could be improved for i9300, charging does not work and the battery percentage is not reported correctly (the latter seem to be fixable with https://github.com/Midas-Mainline/android_kernel_samsung_smdk4412/commit/1287ea6219ef4ebc461214e67d6b98ee99023b3e)

15:11 <Viciouss> @krzk @Grimler it's the same for the n8010, I also noticed all the messages after the patch

15:18 <Viciouss> the vendor kernel has IRQF_TRIGGER_FALLING set in the config

15:20 <Grimler> Viciouss: I guess it is the same on i9100 then as well

15:20 <Grimler> > he vendor kernel has IRQF_TRIGGER_FALLING set

15:20 <Grimler> Could you link to where this is set? I failed to find the related code on downstream kernel for i9300

15:35 <Viciouss> https://github.com/Viciouss/samsung_p4note_kernel_backup/blob/a1b229945b91ace62866dedf636d501bf9aae234/drivers/power/sec_battery_px.c#L2862

16:07 <Grimler> Viciouss: big thanks! Looks like i9300 also has IRQF_TRIGGER_FALLING: https://github.com/LineageOS/android_kernel_samsung_smdk4412/blob/lineage-17.0/drivers/battery/max17047_fuelgauge.c#L909