#buildbot on 2023-06-30 — irc logs at libera.irclog.whitequark.org

2022-03-07 03:24 verm__ changed the topic of #buildbot to: A Software Freedom Conservancy Project | Buildbot-3.5.0 | docs: http://docs.buildbot.net/current/ | tutorial: http://docs.buildbot.net/current/tutorial | irclogs: https://libera.irclog.whitequark.org/buildbot

02:22 Cheyenne has quit [Quit: ZNC 1.8.2 - https://znc.in]

02:25 Cheyenne has joined #buildbot

09:41 mark_ is now known as mjw

10:59 vext01_ has joined #buildbot

10:59 <vext01_> How can i get the plain text of a secret to pass to an attribute that doesn't understanbd secrets?

10:59 <vext01_> I have a util.Secret

11:00 <vext01_> s/attribute/argument/

11:00 <cmouse> ?

11:00 <cmouse> util.Interpolate("%s(secret:name)_")

11:01 <cmouse> but that's going to end up exactly same as util.Secert

11:01 <cmouse> vext01_: can you give bit more context?

11:10 <vext01_> I've made a reporter for pushing messages to mattermost

11:10 <vext01_> it takes a serverUrl, like many reporters

11:10 <vext01_> but the URL itself is secret

11:11 <vext01_> serverUrl=util.Secret("yk-mm-nightly-webhook"),

11:13 <vext01_> doesn't work

11:14 <vext01_> builtins.AttributeError: 'Secret' object has no attribute 'endswith'

11:15 <vext01_> so either the plugin renders the secret somehow, or i pass plain text

11:15 <vext01_> cmouse: makes sense?

11:17 <vext01_> self.renderSecrets(token) maybe?

11:21 <cmouse> yeah

11:21 <cmouse> or yield util.Secret()

11:21 <cmouse> it's a deferred object so it needs to be yielded

11:21 <vext01_> seems to have worked

11:22 <vext01_> next question, should I attempt to upstream this?

11:22 <cmouse> upstream what?

11:22 <vext01_> I've only implemented the bare minimum of what our team needs

11:22 <vext01_> a mattermost notifier

11:22 <vext01_> or reporter

11:22 <cmouse> ah, there wasn't one already?

11:22 <vext01_> whatever you call it

11:22 <cmouse> did you build it over HTTPNotifier?

11:23 <cmouse> or Reporter

11:24 <vext01_> i copied reporters/http.py and ammended it

11:24 <cmouse> you could've use that as base class

11:24 <cmouse> instead of amending it

11:24 <vext01_> yeah, i got confused by the complexity of it all and just started hacking

11:24 <cmouse> idk about upstreaming, feel free to open issue (i'm not a developer here)

11:25 <vext01_> it should be doable with no buildbot changes using the http pusher

11:25 <vext01_> but the docs are wrong and I couldnt figure it out

11:25 <vext01_> https://github.com/buildbot/buildbot/issues/6914

11:27 <vext01_> I wish I'd subclassed it now

11:27 <vext01_> maybe it isn't so hard

11:28 <cmouse> it's usually super easy

11:28 <cmouse> there are already some other http reporters

11:50 <vext01_> uh, my version of buildbot is old enough that none of the reporters actually subclass the http one

13:39 Cheyenne has quit [Quit: ZNC 1.8.2 - https://znc.in]

13:41 Cheyenne has joined #buildbot

14:07 SirScott has quit [Quit: The Lounge - https://thelounge.chat]

14:08 SirScott has joined #buildbot

14:15 <cmouse> heh

14:55 halstead has quit [Server closed connection]

14:56 halstead has joined #buildbot

15:53 vmeson has quit [Quit: Konversation terminated!]

15:56 vvmeson has joined #buildbot

17:06 mjw has quit [Killed (NickServ (GHOST command used by mark_!~mjw@gnu.wildebeest.org))]

17:06 mark_ has joined #buildbot

23:48 Cheyenne has quit [Quit: ZNC 1.8.2 - https://znc.in]

23:49 Cheyenne has joined #buildbot